Re: [PATCH 08/18] drm/i915: Add a relay backed debugfs interface for capturing GuC logs

Chris Wilson
2016-08-15T16:47:12Z

On Mon, Aug 15, 2016 at 10:08:15PM +0530, Goel, Akash wrote:
>
>
> On 8/15/2016 9:42 PM, Chris Wilson wrote:
> >On Mon, Aug 15, 2016 at 05:09:45PM +0100, Chris Wilson wrote:
> >>On Mon, Aug 15, 2016 at 08:19:49PM +0530, akash.goel@intel.com wrote:
> >>>+void i915_guc_register(struct drm_i915_private *dev_priv)
> >>>+{
> >>>+ if (!i915.enable_guc_submission)
> >>>+ return;
> >>
> >>The final state of i915.enable_guc_submission is not known at this time.
>
> As per the below sequence, i915.enable_guc_submission would have
> been set to its final value by this time,
>
> i915_driver_load
> i915_load_modeset_init
> i915_gem_init_hw
> intel_guc_setup
> i915_guc_submission_init
> i915_guc_submission_enable
> i915_driver_register
> i915_debugfs_register
> i915_guc_register

I was under the impression that intel_guc_setup() was asynchronous, that
it waited for the firmware to be loaded.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre