Re: [PATCH 08/18] drm/i915: Add a relay backed debugfs interface for capturing GuC logs

Chris Wilson
2016-08-15T16:12:58Z

On Mon, Aug 15, 2016 at 05:09:45PM +0100, Chris Wilson wrote:
> On Mon, Aug 15, 2016 at 08:19:49PM +0530, akash.goel@intel.com wrote:
> > +void i915_guc_register(struct drm_i915_private *dev_priv)
> > +{
> > + if (!i915.enable_guc_submission)
> > + return;
>
> The final state of i915.enable_guc_submission is not known at this time.
> Does it matter if you set up the log even though guc is not used?
>
> Would this not be better driver from guc_submission_enable and
> guc_submission_disable?

With the caveat that you probably need both. i.e. you have to wait for
both the GuC to be enabled and for sysfs to be available.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre