* [PATCH 1/2] drm/i915: Mark the static key for movntqda as static
@ 2016-08-17 11:09 Chris Wilson
2016-08-17 11:09 ` [PATCH 2/2] drm/i915: Mark i915_hpd_poll_init_work " Chris Wilson
2016-08-17 11:28 ` [PATCH 1/2] drm/i915: Mark the static key for movntqda " Tvrtko Ursulin
0 siblings, 2 replies; 4+ messages in thread
From: Chris Wilson @ 2016-08-17 11:09 UTC (permalink / raw)
To: intel-gfx; +Cc: Akash Goel, Mika Kuoppala
Silence sparse who warns that the global variable is not declared
static.
Fixes: 0b1de5d58e19 ("drm/i915: Use SSE4.1 movntdqa to ...")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Akash Goel <akash.goel@intel.com>
Cc: Damien Lespiau <damien.lespiau@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/i915_memcpy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_memcpy.c b/drivers/gpu/drm/i915/i915_memcpy.c
index 6f1df0ec8a81..49a079494b68 100644
--- a/drivers/gpu/drm/i915/i915_memcpy.c
+++ b/drivers/gpu/drm/i915/i915_memcpy.c
@@ -27,7 +27,7 @@
#include "i915_drv.h"
-DEFINE_STATIC_KEY_FALSE(has_movntdqa);
+static DEFINE_STATIC_KEY_FALSE(has_movntdqa);
#ifdef CONFIG_AS_MOVNTDQA
static void __memcpy_ntdqa(void *dst, const void *src, unsigned long len)
--
2.8.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] drm/i915: Mark i915_hpd_poll_init_work as static
2016-08-17 11:09 [PATCH 1/2] drm/i915: Mark the static key for movntqda as static Chris Wilson
@ 2016-08-17 11:09 ` Chris Wilson
2016-08-17 11:29 ` Tvrtko Ursulin
2016-08-17 11:28 ` [PATCH 1/2] drm/i915: Mark the static key for movntqda " Tvrtko Ursulin
1 sibling, 1 reply; 4+ messages in thread
From: Chris Wilson @ 2016-08-17 11:09 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter
Local function with forgotten static declaration.
Fixes: 19625e85c6ec ("drm/i915: Enable polling when we don't have hpd")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Lyude <cpaul@redhat.com>
---
drivers/gpu/drm/i915/intel_hotplug.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_hotplug.c b/drivers/gpu/drm/i915/intel_hotplug.c
index 5dc2c20f6ca1..334d47b5811a 100644
--- a/drivers/gpu/drm/i915/intel_hotplug.c
+++ b/drivers/gpu/drm/i915/intel_hotplug.c
@@ -477,7 +477,8 @@ void intel_hpd_init(struct drm_i915_private *dev_priv)
spin_unlock_irq(&dev_priv->irq_lock);
}
-void i915_hpd_poll_init_work(struct work_struct *work) {
+static void i915_hpd_poll_init_work(struct work_struct *work)
+{
struct drm_i915_private *dev_priv =
container_of(work, struct drm_i915_private,
hotplug.poll_init_work);
--
2.8.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] drm/i915: Mark i915_hpd_poll_init_work as static
2016-08-17 11:09 ` [PATCH 2/2] drm/i915: Mark i915_hpd_poll_init_work " Chris Wilson
@ 2016-08-17 11:29 ` Tvrtko Ursulin
0 siblings, 0 replies; 4+ messages in thread
From: Tvrtko Ursulin @ 2016-08-17 11:29 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Daniel Vetter
On 17/08/16 12:09, Chris Wilson wrote:
> Local function with forgotten static declaration.
>
> Fixes: 19625e85c6ec ("drm/i915: Enable polling when we don't have hpd")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Lyude <cpaul@redhat.com>
> ---
> drivers/gpu/drm/i915/intel_hotplug.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hotplug.c b/drivers/gpu/drm/i915/intel_hotplug.c
> index 5dc2c20f6ca1..334d47b5811a 100644
> --- a/drivers/gpu/drm/i915/intel_hotplug.c
> +++ b/drivers/gpu/drm/i915/intel_hotplug.c
> @@ -477,7 +477,8 @@ void intel_hpd_init(struct drm_i915_private *dev_priv)
> spin_unlock_irq(&dev_priv->irq_lock);
> }
>
> -void i915_hpd_poll_init_work(struct work_struct *work) {
> +static void i915_hpd_poll_init_work(struct work_struct *work)
> +{
> struct drm_i915_private *dev_priv =
> container_of(work, struct drm_i915_private,
> hotplug.poll_init_work);
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] drm/i915: Mark the static key for movntqda as static
2016-08-17 11:09 [PATCH 1/2] drm/i915: Mark the static key for movntqda as static Chris Wilson
2016-08-17 11:09 ` [PATCH 2/2] drm/i915: Mark i915_hpd_poll_init_work " Chris Wilson
@ 2016-08-17 11:28 ` Tvrtko Ursulin
1 sibling, 0 replies; 4+ messages in thread
From: Tvrtko Ursulin @ 2016-08-17 11:28 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Akash Goel, Mika Kuoppala
On 17/08/16 12:09, Chris Wilson wrote:
> Silence sparse who warns that the global variable is not declared
> static.
>
> Fixes: 0b1de5d58e19 ("drm/i915: Use SSE4.1 movntdqa to ...")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Akash Goel <akash.goel@intel.com>
> Cc: Damien Lespiau <damien.lespiau@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> drivers/gpu/drm/i915/i915_memcpy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_memcpy.c b/drivers/gpu/drm/i915/i915_memcpy.c
> index 6f1df0ec8a81..49a079494b68 100644
> --- a/drivers/gpu/drm/i915/i915_memcpy.c
> +++ b/drivers/gpu/drm/i915/i915_memcpy.c
> @@ -27,7 +27,7 @@
>
> #include "i915_drv.h"
>
> -DEFINE_STATIC_KEY_FALSE(has_movntdqa);
> +static DEFINE_STATIC_KEY_FALSE(has_movntdqa);
>
> #ifdef CONFIG_AS_MOVNTDQA
> static void __memcpy_ntdqa(void *dst, const void *src, unsigned long len)
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-17 11:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-17 11:09 [PATCH 1/2] drm/i915: Mark the static key for movntqda as static Chris Wilson
2016-08-17 11:09 ` [PATCH 2/2] drm/i915: Mark i915_hpd_poll_init_work " Chris Wilson
2016-08-17 11:29 ` Tvrtko Ursulin
2016-08-17 11:28 ` [PATCH 1/2] drm/i915: Mark the static key for movntqda " Tvrtko Ursulin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox