From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 29/40] drm/i915: Differentiate between ggtt->mutex and ppgtt->mutex Date: Mon, 24 Sep 2018 14:04:42 +0100 Message-ID: <58bff06f-c24f-6bfb-f86f-e7b1b40c8b26@linux.intel.com> References: <20180919195544.1511-1-chris@chris-wilson.co.uk> <20180919195544.1511-29-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id B3EEA89E3E for ; Mon, 24 Sep 2018 13:10:33 +0000 (UTC) In-Reply-To: <20180919195544.1511-29-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE5LzA5LzIwMTggMjA6NTUsIENocmlzIFdpbHNvbiB3cm90ZToKPiBXZSBoYXZlIHR3byBj bGFzc2VzIG9mIFZNLCBnbG9iYWwgR1RUIGFuZCBwZXItcHJvY2VzcyBHVFQuIEluIG9yZGVyIHRv Cj4gYWxsb3cgb3Vyc2VsdmVzIHRoZSBmcmVlZG9tIHRvIG1peCBib3RoIGFsb25nIGNhbGwgY2hh aW5zLCBkaXN0aW5ndWlzaAo+IHRoZSB0d28gY2xhc3NlcyB3aXRoIHJlZ2FyZHMgdG8gdGhlaXIg bXV0ZXggYW5kIGxvY2tkZXAgbWFwcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24g PGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtX2d0dC5jICAgICAgIHwgMTAgKysrKystLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW1fZ3R0LmggICAgICAgfCAgMiArKwo+ICAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvc2VsZnRlc3RzL21vY2tfZ3R0LmMgfCAgNiArKystLS0KPiAgIDMgZmlsZXMgY2hhbmdlZCwg MTAgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbV9ndHQuYwo+IGluZGV4IGVmMzhkMDliNmNlMC4uNzE5ZTFhYzIxMmMxIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiBAQCAtNTIzLDggKzUyMyw3IEBAIHN0YXRpYyB2 b2lkIHZtX2ZyZWVfcGFnZShzdHJ1Y3QgaTkxNV9hZGRyZXNzX3NwYWNlICp2bSwgc3RydWN0IHBh Z2UgKnBhZ2UpCj4gICAJc3Bpbl91bmxvY2soJnZtLT5mcmVlX3BhZ2VzLmxvY2spOwo+ICAgfQo+ ICAgCj4gLXN0YXRpYyB2b2lkIGk5MTVfYWRkcmVzc19zcGFjZV9pbml0KHN0cnVjdCBpOTE1X2Fk ZHJlc3Nfc3BhY2UgKnZtLAo+IC0JCQkJICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdikKPiArc3RhdGljIHZvaWQgaTkxNV9hZGRyZXNzX3NwYWNlX2luaXQoc3RydWN0IGk5MTVf YWRkcmVzc19zcGFjZSAqdm0sIGludCBzdWJjbGFzcykKPiAgIHsKPiAgIAkvKgo+ICAgCSAqIFRo ZSB2bS0+bXV0ZXggbXVzdCBiZSByZWNsYWltIHNhZmUgKGZvciB1c2UgaW4gdGhlIHNocmlua2Vy KS4KPiBAQCAtNTMyLDYgKzUzMSw3IEBAIHN0YXRpYyB2b2lkIGk5MTVfYWRkcmVzc19zcGFjZV9p bml0KHN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtLAo+ICAgCSAqIGF0dGVtcHQgaG9sZGlu ZyB0aGUgbG9jayBpcyBpbW1lZGlhdGVseSByZXBvcnRlZCBieSBsb2NrZGVwLgo+ICAgCSAqLwo+ ICAgCW11dGV4X2luaXQoJnZtLT5tdXRleCk7Cj4gKwlsb2NrZGVwX3NldF9zdWJjbGFzcygmdm0t Pm11dGV4LCBzdWJjbGFzcyk7Cj4gICAJaTkxNV9nZW1fc2hyaW5rZXJfdGFpbnRzX211dGV4KCZ2 bS0+bXV0ZXgpOwo+ICAgCj4gICAJR0VNX0JVR19PTighdm0tPnRvdGFsKTsKPiBAQCAtMTY1OCw3 ICsxNjU4LDcgQEAgc3RhdGljIHN0cnVjdCBpOTE1X2h3X3BwZ3R0ICpnZW44X3BwZ3R0X2NyZWF0 ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkKPiAgIAkgKi8KPiAgIAlwcGd0dC0+dm0u aGFzX3JlYWRfb25seSA9ICFpbnRlbF92Z3B1X2FjdGl2ZShpOTE1KTsKPiAgIAo+IC0JaTkxNV9h ZGRyZXNzX3NwYWNlX2luaXQoJnBwZ3R0LT52bSwgaTkxNSk7Cj4gKwlpOTE1X2FkZHJlc3Nfc3Bh Y2VfaW5pdCgmcHBndHQtPnZtLCBWTV9DTEFTU19QUEdUVCk7Cj4gICAKPiAgIAkvKiBUaGVyZSBh cmUgb25seSBmZXcgZXhjZXB0aW9ucyBmb3IgZ2VuID49Ni4gY2h2IGFuZCBieHQuCj4gICAJICog QW5kIHdlIGFyZSBub3Qgc3VyZSBhYm91dCB0aGUgbGF0dGVyIHNvIHBsYXkgc2FmZSBmb3Igbm93 Lgo+IEBAIC0yMTY1LDcgKzIxNjUsNyBAQCBzdGF0aWMgc3RydWN0IGk5MTVfaHdfcHBndHQgKmdl bjZfcHBndHRfY3JlYXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ICAgCj4gICAJ cHBndHQtPmJhc2Uudm0udG90YWwgPSBJOTE1X1BERVMgKiBHRU42X1BURVMgKiBJOTE1X0dUVF9Q QUdFX1NJWkU7Cj4gICAKPiAtCWk5MTVfYWRkcmVzc19zcGFjZV9pbml0KCZwcGd0dC0+YmFzZS52 bSwgaTkxNSk7Cj4gKwlpOTE1X2FkZHJlc3Nfc3BhY2VfaW5pdCgmcHBndHQtPmJhc2Uudm0sIFZN X0NMQVNTX1BQR1RUKTsKPiAgIAo+ICAgCXBwZ3R0LT5iYXNlLnZtLmFsbG9jYXRlX3ZhX3Jhbmdl ID0gZ2VuNl9hbGxvY192YV9yYW5nZTsKPiAgIAlwcGd0dC0+YmFzZS52bS5jbGVhcl9yYW5nZSA9 IGdlbjZfcHBndHRfY2xlYXJfcmFuZ2U7Cj4gQEAgLTM2MDcsNyArMzYwNyw3IEBAIGludCBpOTE1 X2dndHRfaW5pdF9odyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICAJICog YW5kIGJleW9uZCB0aGUgZW5kIG9mIHRoZSBHVFQgaWYgd2UgZG8gbm90IHByb3ZpZGUgYSBndWFy ZC4KPiAgIAkgKi8KPiAgIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+ZHJtLnN0cnVjdF9tdXRleCk7 Cj4gLQlpOTE1X2FkZHJlc3Nfc3BhY2VfaW5pdCgmZ2d0dC0+dm0sIGRldl9wcml2KTsKPiArCWk5 MTVfYWRkcmVzc19zcGFjZV9pbml0KCZnZ3R0LT52bSwgVk1fQ0xBU1NfR0dUVCk7Cj4gICAKPiAg IAlnZ3R0LT52bS5pc19nZ3R0ID0gdHJ1ZTsKPiAgIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt X2d0dC5oCj4gaW5kZXggN2UyYWY1ZjRmMzliLi44NDlhMWY2N2IwMzcgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmgKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbV9ndHQuaAo+IEBAIC0yODYsNiArMjg2LDggQEAgc3RydWN0IGk5MTVf YWRkcmVzc19zcGFjZSB7Cj4gICAJYm9vbCBjbG9zZWQ7Cj4gICAKPiAgIAlzdHJ1Y3QgbXV0ZXgg bXV0ZXg7IC8qIHByb3RlY3RzIHZtYSBhbmQgb3VyIGxpc3RzICovCj4gKyNkZWZpbmUgVk1fQ0xB U1NfR0dUVCAwCj4gKyNkZWZpbmUgVk1fQ0xBU1NfUFBHVFQgMQo+ICAgCj4gICAJc3RydWN0IGk5 MTVfcGFnZV9kbWEgc2NyYXRjaF9wYWdlOwo+ICAgCXN0cnVjdCBpOTE1X3BhZ2VfdGFibGUgKnNj cmF0Y2hfcHQ7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9t b2NrX2d0dC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL21vY2tfZ3R0LmMKPiBp bmRleCA2YWU0MThjNzYwMTUuLjk3NmM4NjJiMzg0MiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9zZWxmdGVzdHMvbW9ja19ndHQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L3NlbGZ0ZXN0cy9tb2NrX2d0dC5jCj4gQEAgLTcwLDcgKzcwLDcgQEAgbW9ja19wcGd0dChz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwKPiAgIAlwcGd0dC0+dm0udG90YWwgPSByb3Vu ZF9kb3duKFU2NF9NQVgsIFBBR0VfU0laRSk7Cj4gICAJcHBndHQtPnZtLmZpbGUgPSBFUlJfUFRS KC1FTk9ERVYpOwo+ICAgCj4gLQlpOTE1X2FkZHJlc3Nfc3BhY2VfaW5pdCgmcHBndHQtPnZtLCBp OTE1KTsKPiArCWk5MTVfYWRkcmVzc19zcGFjZV9pbml0KCZwcGd0dC0+dm0sIFZNX0NMQVNTX1BQ R1RUKTsKPiAgIAo+ICAgCXBwZ3R0LT52bS5jbGVhcl9yYW5nZSA9IG5vcF9jbGVhcl9yYW5nZTsK PiAgIAlwcGd0dC0+dm0uaW5zZXJ0X3BhZ2UgPSBtb2NrX2luc2VydF9wYWdlOwo+IEBAIC0xMDIs NiArMTAyLDcgQEAgdm9pZCBtb2NrX2luaXRfZ2d0dChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq aTkxNSkKPiAgIAlzdHJ1Y3QgaTkxNV9nZ3R0ICpnZ3R0ID0gJmk5MTUtPmdndHQ7Cj4gICAKPiAg IAlnZ3R0LT52bS5pOTE1ID0gaTkxNTsKPiArCWdndHQtPnZtLmlzX2dndHQgPSB0cnVlOwo+ICAg Cj4gICAJZ2d0dC0+Z21hZHIgPSAoc3RydWN0IHJlc291cmNlKSBERUZJTkVfUkVTX01FTSgwLCAy MDQ4ICogUEFHRV9TSVpFKTsKPiAgIAlnZ3R0LT5tYXBwYWJsZV9lbmQgPSByZXNvdXJjZV9zaXpl KCZnZ3R0LT5nbWFkcik7Cj4gQEAgLTExNyw5ICsxMTgsOCBAQCB2b2lkIG1vY2tfaW5pdF9nZ3R0 KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ICAgCWdndHQtPnZtLnZtYV9vcHMuc2V0 X3BhZ2VzICAgPSBnZ3R0X3NldF9wYWdlczsKPiAgIAlnZ3R0LT52bS52bWFfb3BzLmNsZWFyX3Bh Z2VzID0gY2xlYXJfcGFnZXM7Cj4gICAKPiAtCWk5MTVfYWRkcmVzc19zcGFjZV9pbml0KCZnZ3R0 LT52bSwgaTkxNSk7Cj4gICAKPiAtCWdndHQtPnZtLmlzX2dndHQgPSB0cnVlOwo+ICsJaTkxNV9h ZGRyZXNzX3NwYWNlX2luaXQoJmdndHQtPnZtLCBWTV9DTEFTU19HR1RUKTsKPiAgIH0KPiAgIAo+ ICAgdm9pZCBtb2NrX2ZpbmlfZ2d0dChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkKPiAK ClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoK UmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK