From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATH v2 6/6] Xv: dont call intel_wait_for_scanline on Sandybridge Date: Fri, 29 Oct 2010 09:20:11 +0100 Message-ID: <5b55a1$iglnjn@fmsmga002.fm.intel.com> References: <1288145853-25252-1-git-send-email-haihao.xiang@intel.com> <1288145853-25252-7-git-send-email-haihao.xiang@intel.com> <201010282342.05806.kenneth@whitecape.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id A71FA9E78C for ; Fri, 29 Oct 2010 01:20:14 -0700 (PDT) In-Reply-To: <201010282342.05806.kenneth@whitecape.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Kenneth Graunke , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 28 Oct 2010 23:42:05 -0700, Kenneth Graunke wrote: > On Tuesday 26 October 2010 19:17:33 Xiang, Haihao wrote: > > MI_LOAD_SCAN_LINE_INCL command is not available on sandybridge. > > > > Signed-off-by: Xiang, Haihao > > --- > > src/intel_video.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/src/intel_video.c b/src/intel_video.c > > index afc2405..cdff149 100644 > > --- a/src/intel_video.c > > +++ b/src/intel_video.c > > @@ -1578,7 +1578,7 @@ I830PutImageTextured(ScrnInfoPtr scrn, > > return BadAlloc; > > } > > > > - if (crtc && adaptor_priv->SyncToVblank != 0) { > > + if (crtc && adaptor_priv->SyncToVblank != 0 && INTEL_INFO(intel)->gen < > > 60) { intel_wait_for_scanline(scrn, pixmap, crtc, clipBoxes); > > } > > I think you mean < 6 here (not 60)? No, 60. It's generation*10 + minor revision, just so that g33 and g45 could be easily identified from their gen3 and gen4 brethen. -Chris -- Chris Wilson, Intel Open Source Technology Centre