From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] drm/i915: Add aub debug support for kernel
Date: Fri, 05 Nov 2010 17:11:33 +0000
Message-ID: <5b55a1$ij0t3g@fmsmga002.fm.intel.com>
References: <1288689096-23230-1-git-send-email-yuanhan.liu@intel.com>
	<849307$a7if4n@azsmga001.ch.intel.com>
	<AANLkTi=vT-WYVxsh0GcXBhrVXjku6A86bZN3bcS_T72F@mail.gmail.com>
	<F26D193E20BBDC42A43B611D1BDEDE7121C0635DD4@shsmsx502.ccr.corp.intel.com>
	<c6d829$pega7u@fmsmga001.fm.intel.com>
	<AANLkTik_K1iv-Xp8ZEMPWPKf5kN5PoS+TudJ2ih4AnRJ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by gabe.freedesktop.org (Postfix) with ESMTP id E34529EF4C
	for <intel-gfx@lists.freedesktop.org>;
	Fri,  5 Nov 2010 10:11:36 -0700 (PDT)
In-Reply-To: <AANLkTik_K1iv-Xp8ZEMPWPKf5kN5PoS+TudJ2ih4AnRJ@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Liu Aleaxander <aleaxander@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Sat, 6 Nov 2010 00:43:46 +0800, Liu Aleaxander <aleaxander@gmail.com> wrote:
> Well, what are the steps you excepted to get an aub file? Please tell
> me, then I may know your
> points better.
> 
> 
> >
> > Still requires post-processing to add the aub headers, but this will allow
> > runtime enabling of the capture. How does this sound?
> 
> Yes, runtime enabling of the capture is great. And post-processing
> isn't that bad at all.
> What I concerned is how much hard or easy for user to generate an aub
> file. As Nanhai said,
> if user met some problem, we can ask him for an aub file, then we
> might know what was going
> wrong. This is the biggest advantage of aub file. So, I'm not trying
> to ask you give up the
> tracepoints(it really nice for tracing something down), I just want an
> easy way to get an aub file
> for us, and especially for user.

Right. If we want to ask the user to gather some debug info, it
essentially has to be from within X and be as simple as run
'intel-gpu-trace myapp'. Using ftrace is the simplest way to achieve
that. Having to rmmod i915.ko rules out mmiotrace as a viable candidate.
But we can easy add two tracepoints to I915_READ and I915_WRITE which can
be enabled at runtime, exported via /sys/kernel/debug/tracing and
automated in a little tool.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre