From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sripada, Radhakrishna" Subject: Re: [PATCH v3] drm/i915/icl: Fix clockgating issue when using scalers Date: Mon, 25 Mar 2019 19:45:39 +0000 Message-ID: <5bf9d99727d53ee2333faf5dbcb67a02ca5ce9da.camel@intel.com> References: <20190315221838.22444-1-radhakrishna.sripada@intel.com> <20190321214431.515-1-radhakrishna.sripada@intel.com> <20190322131449.GQ3888@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id E188F6E73E for ; Mon, 25 Mar 2019 19:45:41 +0000 (UTC) In-Reply-To: <20190322131449.GQ3888@intel.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "ville.syrjala@linux.intel.com" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAyMDE5LTAzLTIyIGF0IDE1OjE0ICswMjAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6 DQo+IE9uIFRodSwgTWFyIDIxLCAyMDE5IGF0IDAyOjQ0OjMxUE0gLTA3MDAsIFJhZGhha3Jpc2hu YSBTcmlwYWRhIHdyb3RlOg0KPiA+IEZpeGVzIHRoZSBjbG9jay1nYXRpbmcgaXNzdWUgd2hlbiBw aXBlIHNjYWxpbmcgaXMgZW5hYmxlZC4NCj4gPiAoTGluZWFnZSAjMjAwNjYwNDMxMikNCj4gPiAN Cj4gPiBWMjogRml4IHR5cG8gaW4gaGVhZGxpbmUoQ2hyaXMpDQo+ID4gICAgIEhhbmRsZSB0aGUg bm9uIGRvdWJsZSBidWZmZXJlZCBuYXR1cmUgb2YgdGhlIHJlZ2lzdGVyKFZpbGxlKQ0KPiA+IFYz OiBGaXggY2hlY2twYXRjaCB3YXJuaW5nLiBCQVQgZmFpbHVyZSBmb3IgVjIgb24gZ2VuMyBsb29r cw0KPiA+IHVucmVsYXRlZC4NCj4gPiANCj4gPiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJp cy13aWxzb24uY28udWs+DQo+ID4gQ2M6IFZpbGxlIFN5cmphbGEgPHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tPg0KPiA+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5j b20+DQo+ID4gQ2M6IEFkaXR5YSBTd2FydXAgPGFkaXR5YS5zd2FydXBAaW50ZWwuY29tPg0KPiA+ IFNpZ25lZC1vZmYtYnk6IFJhZGhha3Jpc2huYSBTcmlwYWRhIDxyYWRoYWtyaXNobmEuc3JpcGFk YUBpbnRlbC5jb20NCj4gPiA+DQo+ID4gLS0tDQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYyB8IDQzICsrKysrKysrKysrKysrKysrLS0tLS0tLQ0KPiA+IC0tLS0NCj4g PiAgMSBmaWxlIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQ0KPiA+ IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMN Cj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYw0KPiA+IGluZGV4IDdj MTViNDI4ZmY4NC4uY2ZhMTlhZTEyZTIyIDEwMDY0NA0KPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYw0KPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYw0KPiA+IEBAIC00NjksMTMgKzQ2OSwyMiBAQCBzdGF0aWMgY29uc3Qgc3Ry dWN0IGludGVsX2xpbWl0DQo+ID4gaW50ZWxfbGltaXRzX2J4dCA9IHsNCj4gPiAgc3RhdGljIHZv aWQNCj4gPiAgc2tsX3dhX2Nsa2dhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LCBpbnQgcGlwZSwgYm9vbA0KPiA+IGVuYWJsZSkNCj4gPiAgew0KPiA+ICsJdTMyIHZhbCA9IDA7 DQo+ID4gKw0KPiA+ICsJLyoNCj4gPiArCSAqIFdhXzIwMDY2MDQzMTI6aWNsDQo+ID4gKwkgKi8N Cj4gPiArCWlmIChJU19JQ0VMQUtFKGRldl9wcml2KSkNCj4gPiArCQl2YWwgPSBEUEZSX0dBVElO R19ESVM7DQo+ID4gKwllbHNlDQo+ID4gKwkJdmFsID0gRFVQUzFfR0FUSU5HX0RJUyB8IERVUFMy X0dBVElOR19ESVM7DQo+ID4gKw0KPiA+ICsJLyogV0EgRGlzcGxheSAjMDgyNzogR2VuOTphbGwg Ki8NCj4gDQo+IFlvdSdyZSBub3cgY29uZmxhdGluZyB0d28gd29ya2Fyb3VuZCBhbmQgc3BsaXR0 aW5nIHRoZWlyDQo+IGltcGxlbWVudGF0aW9uDQo+IGJldHdlZW4gdHdvIGZ1bmN0aW9ucyBpbiBh IGNvbmZ1c2luZyB3YXkuIEJldHRlciB0byBrZWVwIHRoZW0NCj4gc2VwYXJhdGUNCj4gSU1PLg0K DQpJIGVuY291bnRlcmVkIGEgc2ltaWxhciBxdWVzdGlvbiB3aGlsZSB3cml0aW5nIHRoZSBjb2Rl LiBJIGRpc2N1c3NlZA0Kd2l0aCBSb2RyaWdvIGFib3V0IGEgcG9zc2libGUgd2F5IG9mIGltcGxl bWVudGluZyBhIGZ1bmN0aW9uIHBvaW50ZXINCmtpbmQgb2YgcHJvdG90eXBlIGZvbGxvd2VkIGJ5 IElDTC9TS0wgd2EgdG8gZGlmZmVyZW50aWF0ZSBiL3dlZW4gdGhlDQp0d28gaW1wbGVtZW50YXRp b25zLiBJdCB3YXMgc3VnZ2VzdGVkIHRoYXQgdGhlIGFwcHJvYWNoIGlzIG92ZXJseQ0KY29tcGxp Y2F0ZWQuIFNpbmNlIHdlIGRvIHVzZSB0aGUgc2FtZSByZWdpc3RlciBpbiBib3RoIGNhc2VzIGFu ZCBkdWUgdG8NCnRoZSBub24gZG91YmxlIGJ1ZmZlcmVkIG5hdHVyZSBvZiB0aGUgcmVnaXN0ZXIg SSBoYXZlIHJlc29ydGVkIHRvIHRoZQ0Kc3R1cGlkL2RpcnR5IHdheS4gRG8geW91IHN1Z2dlc3Qg b3RoZXJ3aXNlPw0KDQotIFJhZGhha3Jpc2huYShSSykgU3JpcGFkYSANCj4gDQo+ID4gIAlpZiAo ZW5hYmxlKQ0KPiA+IC0JCUk5MTVfV1JJVEUoQ0xLR0FURV9ESVNfUFNMKHBpcGUpLA0KPiA+IC0J CQkgICBEVVBTMV9HQVRJTkdfRElTIHwgRFVQUzJfR0FUSU5HX0RJUyk7DQo+ID4gKwkJSTkxNV9X UklURShDTEtHQVRFX0RJU19QU0wocGlwZSksIHZhbCk7DQo+ID4gIAllbHNlDQo+ID4gIAkJSTkx NV9XUklURShDTEtHQVRFX0RJU19QU0wocGlwZSksDQo+ID4gLQkJCSAgIEk5MTVfUkVBRChDTEtH QVRFX0RJU19QU0wocGlwZSkpICYNCj4gPiAtCQkJICAgfihEVVBTMV9HQVRJTkdfRElTIHwgRFVQ UzJfR0FUSU5HX0RJUykpOw0KPiA+ICsJCQkgICBJOTE1X1JFQUQoQ0xLR0FURV9ESVNfUFNMKHBp cGUpKSAmIH52YWwpOw0KPiA+ICB9DQo+ID4gIA0KPiA+ICBzdGF0aWMgYm9vbA0KPiA+IEBAIC01 NDgxLDE0ICs1NDkwLDE4IEBAIHN0YXRpYyBib29sDQo+ID4gaHN3X3Bvc3RfdXBkYXRlX2VuYWJs ZV9pcHMoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUNCj4gPiAqb2xkX2NydGNfcw0KPiA+ ICAJcmV0dXJuICFvbGRfY3J0Y19zdGF0ZS0+aXBzX2VuYWJsZWQ7DQo+ID4gIH0NCj4gPiAgDQo+ ID4gLXN0YXRpYyBib29sIG5lZWRzX252MTJfd2Eoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2LA0KPiA+IC0JCQkgIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0 YXRlKQ0KPiA+ICtzdGF0aWMgYm9vbCBza2xfbmVlZHNfY2xrX3dhKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiwNCj4gPiArCQkJICAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19z dGF0ZSAqY3J0Y19zdGF0ZSkNCj4gPiAgew0KPiA+IC0JaWYgKCFjcnRjX3N0YXRlLT5udjEyX3Bs YW5lcykNCj4gPiAtCQlyZXR1cm4gZmFsc2U7DQo+ID4gLQ0KPiA+ICAJLyogV0EgRGlzcGxheSAj MDgyNzogR2VuOTphbGwgKi8NCj4gPiAtCWlmIChJU19HRU4oZGV2X3ByaXYsIDkpICYmICFJU19H RU1JTklMQUtFKGRldl9wcml2KSkNCj4gPiArCWlmICghIWNydGNfc3RhdGUtPm52MTJfcGxhbmVz ICYmIElTX0dFTihkZXZfcHJpdiwgOSkgJiYNCj4gPiArCSAgICAhSVNfR0VNSU5JTEFLRShkZXZf cHJpdikpDQo+ID4gKwkJcmV0dXJuIHRydWU7DQo+ID4gKw0KPiA+ICsJLyoNCj4gPiArCSAqIFdh XzIwMDY2MDQzMTI6aWNsDQo+ID4gKwkgKi8NCj4gPiArCWlmIChJU19JQ0VMQUtFKGRldl9wcml2 KSAmJiBjcnRjX3N0YXRlLT5wY2hfcGZpdC5lbmFibGVkKQ0KPiA+ICAJCXJldHVybiB0cnVlOw0K PiA+ICANCj4gPiAgCXJldHVybiBmYWxzZTsNCj4gPiBAQCAtNTUyNyw5ICs1NTQwLDggQEAgc3Rh dGljIHZvaWQgaW50ZWxfcG9zdF9wbGFuZV91cGRhdGUoc3RydWN0DQo+ID4gaW50ZWxfY3J0Y19z dGF0ZSAqb2xkX2NydGNfc3RhdGUpDQo+ID4gIAkJCWludGVsX3Bvc3RfZW5hYmxlX3ByaW1hcnko JmNydGMtPmJhc2UsDQo+ID4gcGlwZV9jb25maWcpOw0KPiA+ICAJfQ0KPiA+ICANCj4gPiAtCS8q IERpc3BsYXkgV0EgODI3ICovDQo+ID4gLQlpZiAobmVlZHNfbnYxMl93YShkZXZfcHJpdiwgb2xk X2NydGNfc3RhdGUpICYmDQo+ID4gLQkgICAgIW5lZWRzX252MTJfd2EoZGV2X3ByaXYsIHBpcGVf Y29uZmlnKSkgew0KPiA+ICsJaWYgKHNrbF9uZWVkc19jbGtfd2EoZGV2X3ByaXYsIG9sZF9jcnRj X3N0YXRlKSAmJg0KPiA+ICsJICAgICFza2xfbmVlZHNfY2xrX3dhKGRldl9wcml2LCBwaXBlX2Nv bmZpZykpIHsNCj4gPiAgCQlza2xfd2FfY2xrZ2F0ZShkZXZfcHJpdiwgY3J0Yy0+cGlwZSwgZmFs c2UpOw0KPiA+ICAJfQ0KPiA+ICB9DQo+ID4gQEAgLTU1NjYsOSArNTU3OCw4IEBAIHN0YXRpYyB2 b2lkIGludGVsX3ByZV9wbGFuZV91cGRhdGUoc3RydWN0DQo+ID4gaW50ZWxfY3J0Y19zdGF0ZSAq b2xkX2NydGNfc3RhdGUsDQo+ID4gIAkJCWludGVsX3NldF9jcHVfZmlmb191bmRlcnJ1bl9yZXBv cnRpbmcoZGV2X3ByaXYsDQo+ID4gY3J0Yy0+cGlwZSwgZmFsc2UpOw0KPiA+ICAJfQ0KPiA+ICAN Cj4gPiAtCS8qIERpc3BsYXkgV0EgODI3ICovDQo+ID4gLQlpZiAoIW5lZWRzX252MTJfd2EoZGV2 X3ByaXYsIG9sZF9jcnRjX3N0YXRlKSAmJg0KPiA+IC0JICAgIG5lZWRzX252MTJfd2EoZGV2X3By aXYsIHBpcGVfY29uZmlnKSkgew0KPiA+ICsJaWYgKCFza2xfbmVlZHNfY2xrX3dhKGRldl9wcml2 LCBvbGRfY3J0Y19zdGF0ZSkgJiYNCj4gPiArCSAgICBza2xfbmVlZHNfY2xrX3dhKGRldl9wcml2 LCBwaXBlX2NvbmZpZykpIHsNCj4gPiAgCQlza2xfd2FfY2xrZ2F0ZShkZXZfcHJpdiwgY3J0Yy0+ cGlwZSwgdHJ1ZSk7DQo+ID4gIAl9DQo+ID4gIA0KPiA+IC0tIA0KPiA+IDIuMjAuMC5yYzIuNy5n OTY1Nzk4ZDFmMjk5DQo+IA0KPiANCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeA==