From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 03/12] drm/i915/execlists: Suppress redundant preemption Date: Mon, 4 Feb 2019 12:05:34 +0000 Message-ID: <5ee05d8e-2f0f-831f-ed6b-69b85fc1c3be@linux.intel.com> References: <20190204084116.3013-1-chris@chris-wilson.co.uk> <20190204084116.3013-3-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C61E6E164 for ; Mon, 4 Feb 2019 12:05:27 +0000 (UTC) In-Reply-To: <20190204084116.3013-3-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA0LzAyLzIwMTkgMDg6NDEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiB1bndpbmRpbmcg dGhlIGFjdGl2ZSByZXF1ZXN0IHdlIGdpdmUgaXQgYSBzbWFsbCAobGltaXRlZCB0byBpbnRlcm5h bAo+IHByaW9yaXR5IGxldmVscykgYm9vc3QgdG8gcHJldmVudCBpdCBmcm9tIGJlaW5nIGdhenVt cGVkIGEgc2Vjb25kIHRpbWUuCj4gSG93ZXZlciwgdGhpcyBtZWFucyB0aGF0IGl0IGNhbiBiZSBw cm9tb3RlZCB0byBhYm92ZSB0aGUgcmVxdWVzdCB0aGF0Cj4gdHJpZ2dlcmVkIHRoZSBwcmVlbXB0 aW9uIHJlcXVlc3QsIGNhdXNpbmcgYSBwcmVlbXB0LXRvLWlkbGUgY3ljbGUgZm9yIG5vCj4gY2hh bmdlLiBXZSBjYW4gYXZvaWQgdGhpcyBpZiB3ZSB0YWtlIHRoZSBib29zdCBpbnRvIGFjY291bnQg d2hlbgo+IGNoZWNraW5nIGlmIHRoZSBwcmVlbXB0aW9uIHJlcXVlc3QgaXMgdmFsaWQuCgpBZnRl ciB0aGUgcHJldmlvdXMgcGF0Y2ggdG8gbm90IHByZWVtcHQgb24gd2FpdCB0aGlzIGlzIG5vdCB0 cnVlIGFueSAKbW9yZSByaWdodD8KCj4gCj4gdjI6IEFmdGVyIHByZWVtcHRpb24gdGhlIGFjdGl2 ZSByZXF1ZXN0IHdpbGwgYmUgYWZ0ZXIgdGhlIHByZWVtcHRlZSBpZgo+IHRoZXkgZW5kIHVwIHdp dGggZXF1YWwgcHJpb3JpdHkuCj4gCj4gdjM6IFR2cnRrbyBwb2ludGVkIG91dCB0aGF0IHRoaXMs IHRoZSBleGlzdGluZyBsb2dpYywgbWFrZXMKPiBJOTE1X1BSSU9SSVRZX1dBSVQgbm9uLXByZWVt cHRpYmxlLiBEb2N1bWVudCB0aGlzIGludGVyZXN0aW5nIHF1aXJrIQo+IAo+IHY0OiBQcm92ZSBU dnJ0a28gd2FzIHJpZ2h0IGFib3V0IFdBSVQgYmVpbmcgbm9uLXByZWVtcHRpYmxlIGFuZCB0ZXN0 IGl0Lgo+IHY1OiBFeGNlcHQgbm90IGFsbCBwcmlvcml0aWVzIHdlcmUgbWFkZSBlcXVhbCwgYW5k IHRoZSBXQUlUIG5vdCBwcmVlbXB0aW5nCj4gaXMgb25seSBpZiB3ZSBzdGFydCBvZmYgYXMgIU5F V0NMSUVOVC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp bHNvbi5jby51az4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNv bT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIHwgMzggKysrKysr KysrKysrKysrKysrKysrKysrKysrKy0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAzNCBpbnNlcnRp b25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gaW5k ZXggNzczZGYwYmQ2ODViLi45YjZiM2FjYjkwNzAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9s cmMuYwo+IEBAIC0xNjQsNiArMTY0LDggQEAKPiAgICNkZWZpbmUgV0FfVEFJTF9EV09SRFMgMgo+ ICAgI2RlZmluZSBXQV9UQUlMX0JZVEVTIChzaXplb2YodTMyKSAqIFdBX1RBSUxfRFdPUkRTKQo+ ICAgCj4gKyNkZWZpbmUgQUNUSVZFX1BSSU9SSVRZIChJOTE1X1BSSU9SSVRZX05FV0NMSUVOVCkK PiArCj4gICBzdGF0aWMgaW50IGV4ZWNsaXN0c19jb250ZXh0X2RlZmVycmVkX2FsbG9jKHN0cnVj dCBpOTE1X2dlbV9jb250ZXh0ICpjdHgsCj4gICAJCQkJCSAgICBzdHJ1Y3QgaW50ZWxfZW5naW5l X2NzICplbmdpbmUsCj4gICAJCQkJCSAgICBzdHJ1Y3QgaW50ZWxfY29udGV4dCAqY2UpOwo+IEBA IC0xOTAsOCArMTkyLDMwIEBAIHN0YXRpYyBpbmxpbmUgaW50IHJxX3ByaW8oY29uc3Qgc3RydWN0 IGk5MTVfcmVxdWVzdCAqcnEpCj4gICAKPiAgIHN0YXRpYyBpbnQgZWZmZWN0aXZlX3ByaW8oY29u c3Qgc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEpCj4gICB7Cj4gKwlpbnQgcHJpbyA9IHJxX3ByaW8o cnEpOwo+ICsKPiArCS8qCj4gKwkgKiBPbiB1bndpbmRpbmcgdGhlIGFjdGl2ZSByZXF1ZXN0LCB3 ZSBnaXZlIGl0IGEgcHJpb3JpdHkgYnVtcAo+ICsJICogZXF1aXZhbGVudCB0byBhIGZyZXNobHkg c3VibWl0dGVkIHJlcXVlc3QuIFRoaXMgcHJvdGVjdHMgaXQgZnJvbQo+ICsJICogYmVpbmcgZ2F6 dW1wZWQgYWdhaW4sIGJ1dCBpdCB3b3VsZCBiZSBwcmVmZXJhYmxlIGlmIHdlIGRpZG4ndAo+ICsJ ICogbGV0IGl0IGJlIGdhenVtcGVkIGluIHRoZSBmaXJzdCBwbGFjZSEKPiArCSAqCj4gKwkgKiBT ZWUgX191bndpbmRfaW5jb21wbGV0ZV9yZXF1ZXN0cygpCj4gKwkgKi8KPiArCWlmICh+cHJpbyAm IEFDVElWRV9QUklPUklUWSAmJiBfX2k5MTVfcmVxdWVzdF9oYXNfc3RhcnRlZChycSkpIHsKClNv IGVmZmVjdGl2ZWx5IGEgc3RhcnRlZCByZXF1ZXN0IGNhbm5vdCBiZSBwcmVlbXB0ZWQgYnkgYSBu ZXcgY2xpZW50LCBvbiAKdGhlIHNhbWUgYmFzZSBwcmlvcml0eSBsZXZlbC4KCkkgYW0gc3RpbGwg bm90IHN1cmUgdGhhdCB3ZSBzaG91bGQgZ2l2ZSBzcGVjaWFsIG1lYW5pbmcgdG8gYSBzdGFydGVk IApyZXF1ZXN0LiBXZSBkb24ndCBrbm93IGhvdyBsb25nIGl0IHdvdWxkIGV4ZWN1dGUgb3IgYW55 dGhpbmcuIEl0IG1heSBiZSAKdGhlIG9ubHkgcmVxdWVzdCwgb3IgaXQgbWF5IGJlIGEgbGFzdCBp biBhIGNvYWxlc2NlZCBjb250ZXh0LiBBbmQgaW4gCmJvdGggY2FzZXMgaXQgY2FuIGJlIGVpdGhl ciBzaG9ydCBvciBsb25nLgoKPiArCQkvKgo+ICsJCSAqIEFmdGVyIHByZWVtcHRpb24sIHdlIGlu c2VydCB0aGUgYWN0aXZlIHJlcXVlc3QgYXQgdGhlCj4gKwkJICogZW5kIG9mIHRoZSBuZXcgcHJp b3JpdHkgbGV2ZWwuIFRoaXMgbWVhbnMgdGhhdCB3ZSB3aWxsIGJlCj4gKwkJICogX2xvd2VyXyBw cmlvcml0eSB0aGFuIHRoZSBwcmVlbXB0ZWUgYWxsIHRoaW5ncyBlcXVhbCAoYW5kCj4gKwkJICog c28gdGhlIHByZWVtcHRpb24gaXMgdmFsaWQpLCBzbyBhZGp1c3Qgb3VyIGNvbXBhcmlzb24KPiAr CQkgKiBhY2NvcmRpbmdseS4KPiArCQkgKi8KPiArCQlwcmlvIHw9IEFDVElWRV9QUklPUklUWTsK PiArCQlwcmlvLS07Cj4gKwl9Cj4gKwo+ICAgCS8qIFJlc3RyaWN0IG1lcmUgV0FJVCBib29zdHMg ZnJvbSB0cmlnZ2VyaW5nIHByZWVtcHRpb24gKi8KPiAtCXJldHVybiBycV9wcmlvKHJxKSB8IF9f Tk9fUFJFRU1QVElPTjsKPiArCXJldHVybiBwcmlvIHwgX19OT19QUkVFTVBUSU9OOwo+ICAgfQo+ ICAgCj4gICBzdGF0aWMgaW50IHF1ZXVlX3ByaW8oY29uc3Qgc3RydWN0IGludGVsX2VuZ2luZV9l eGVjbGlzdHMgKmV4ZWNsaXN0cykKPiBAQCAtMzYwLDcgKzM4NCw3IEBAIF9fdW53aW5kX2luY29t cGxldGVfcmVxdWVzdHMoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgewo+ICAg CXN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxLCAqcm4sICphY3RpdmUgPSBOVUxMOwo+ICAgCXN0cnVj dCBsaXN0X2hlYWQgKnVuaW5pdGlhbGl6ZWRfdmFyKHBsKTsKPiAtCWludCBwcmlvID0gSTkxNV9Q UklPUklUWV9JTlZBTElEIHwgSTkxNV9QUklPUklUWV9ORVdDTElFTlQ7Cj4gKwlpbnQgcHJpbyA9 IEk5MTVfUFJJT1JJVFlfSU5WQUxJRCB8IEFDVElWRV9QUklPUklUWTsKPiAgIAo+ICAgCWxvY2tk ZXBfYXNzZXJ0X2hlbGQoJmVuZ2luZS0+dGltZWxpbmUubG9jayk7Cj4gICAKPiBAQCAtMzkxLDkg KzQxNSwxNSBAQCBfX3Vud2luZF9pbmNvbXBsZXRlX3JlcXVlc3RzKHN0cnVjdCBpbnRlbF9lbmdp bmVfY3MgKmVuZ2luZSkKPiAgIAkgKiBUaGUgYWN0aXZlIHJlcXVlc3QgaXMgbm93IGVmZmVjdGl2 ZWx5IHRoZSBzdGFydCBvZiBhIG5ldyBjbGllbnQKPiAgIAkgKiBzdHJlYW0sIHNvIGdpdmUgaXQg dGhlIGVxdWl2YWxlbnQgc21hbGwgcHJpb3JpdHkgYnVtcCB0byBwcmV2ZW50Cj4gICAJICogaXQg YmVpbmcgZ2F6dW1wZWQgYSBzZWNvbmQgdGltZSBieSBhbm90aGVyIHBlZXIuCj4gKwkgKgo+ICsJ ICogT25lIGNvbnNlcXVlbmNlIG9mIHRoaXMgcHJlZW1wdGlvbiBib29zdCBpcyB0aGF0IHdlIG1h eSBqdW1wCj4gKwkgKiBvdmVyIGxlc3NlciBwcmlvcml0aWVzIChzdWNoIGFzIEk5MTVfUFJJT1JJ VFlfV0FJVCksIGVmZmVjdGl2ZWx5Cj4gKwkgKiBtYWtpbmcgdGhvc2UgcHJpb3JpdGllcyBub24t cHJlZW1wdGlibGUuIFRoZXkgd2lsbCBiZSBtb3ZlZCAKZm9yd2FyZAoKTm90IGZ1bGx5IHByZWVt cHRpYmxlLCBqdXN0IGluIHRoZSBzYW1lIHVzZXIgcHJpbyBidWNrZXQuCgo+ICsJICogaW4gdGhl IHByaW9yaXR5IHF1ZXVlLCBidXQgdGhleSB3aWxsIG5vdCBnYWluIGltbWVkaWF0ZSBhY2Nlc3Mg dG8KPiArCSAqIHRoZSBHUFUuCj4gICAJICovCj4gLQlpZiAoIShwcmlvICYgSTkxNV9QUklPUklU WV9ORVdDTElFTlQpKSB7Cj4gLQkJcHJpbyB8PSBJOTE1X1BSSU9SSVRZX05FV0NMSUVOVDsKPiAr CWlmICh+cHJpbyAmIEFDVElWRV9QUklPUklUWSAmJiBfX2k5MTVfcmVxdWVzdF9oYXNfc3RhcnRl ZChhY3RpdmUpKSB7Cj4gKwkJcHJpbyB8PSBBQ1RJVkVfUFJJT1JJVFk7Cj4gICAJCWFjdGl2ZS0+ c2NoZWQuYXR0ci5wcmlvcml0eSA9IHByaW87Cj4gICAJCWxpc3RfbW92ZV90YWlsKCZhY3RpdmUt PnNjaGVkLmxpbmssCj4gICAJCQkgICAgICAgaTkxNV9zY2hlZF9sb29rdXBfcHJpb2xpc3QoZW5n aW5lLCBwcmlvKSk7Cj4gCgpBbmQgaGVyZSBpdCBpcyBhIGJpZyBjaGFuZ2UgYXMgd2VsbC4gV2Ug d291bGQgc3RvcCBnaXZpbmcgYm9vc3QgdG8gCnByZWVtcHRlZCByZXF1ZXN0cyBpZiB0aGV5IGhh dmVuJ3Qgc3RhcnRlZCBleGVjdXRpbmcgeWV0LiBBbmQgd2UgaGF2ZSBubyAKYWNjb3VudGluZyB0 byBob3cgbWFueSB0aW1lcyBzb21ldGhpbmcgaXMgcHJlZW1wdGVkLCB0byBtYXliZSBrZWVwIApi dW1waW5nIHRoZWlyIHByaW9yaXRpZXMgaW4gdGhvc2UgY2FzZXMuIFdoaWNoIHdvdWxkIHByb2Jh Ymx5IG1vdmUgCnRvd2FyZHMgZGlmZmVyZW50IHByaW9yaXR5IG1hbmFnZW1lbnQuIExpa2U6CgoJ aWYgKHByZWVtcHRlZCB8fCBuZXdfY2xpZW50IHx8IHdhaXQpCgkJcnEtPmVmZmVjdGl2ZV9wcmlv Kys7CgojZGVmaW5lIFVTRVJfUFJJT19TSElGVCAxNiAvLyA2NTUzNiBwcmlvIGJ1bXBzIGJlZm9y ZSBvdmVyZmxvdz8KCkkgZG9uJ3Qga25vdywgSSBmaW5kIHRoZSB0b3RhbCBsb2dpYyAoYWxsIHRo ZXNlIHBhdGNoZXMgY29tYmluZWQpIHF1aXRlIApoYXJkIHRvIHVuZGVyc3RhbmQgc28gSSBzdGFy dGVkIHRvIHRoaW5rIGlmIHdlIGNvdWxkIGhhdmUgc29tZXRoaW5nIG1vcmUgCmdlbmVyaWMgYW5k IHNpbXBsZXIuCgpSZWdhcmRzLAoKVHZydGtvCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==