From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52923C5478C for ; Tue, 27 Feb 2024 09:26:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C94D410E8B0; Tue, 27 Feb 2024 09:26:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="kPfiIP2C"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A49410E8B0; Tue, 27 Feb 2024 09:26:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709025987; x=1740561987; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=d7qvb68AxhQIcifAepC6POl/VMX++0DCVgcmzXKpFRs=; b=kPfiIP2CpdS4qRkn6a7hSieKfQ1PHGxpxaUkpvXrPFhl++msnbQ92PR6 5oCwK7OGo4mQ4H1hIRuRaEExAXOKYtaEsN0iwHy+VmukgxnzT4qCvLdEo N1nSAZHxkpYoC3UZBzpJQD47qRD5o0dhWPV4vYIJGeYbvN98RspMCfhdB s3JLCinfk4QOKr1Gw4Z/qg8Pa0L3kIjB6vWv7aE7c13cTnJ4b/rbKEhSM Gv8b9e//dQra/T/w+KikMDRHMjyulSjJWP+c+pyGcCepqnqnHh2X3YUyT LTQJWuDRQ4SNqn4EjX4NPza5zCOdI9gBet2uk7YJKQQsh9AeSxaTiFmSu w==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="25821277" X-IronPort-AV: E=Sophos;i="6.06,187,1705392000"; d="scan'208";a="25821277" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 01:26:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,187,1705392000"; d="scan'208";a="6843722" Received: from nirmoyda-mobl.ger.corp.intel.com (HELO [10.94.250.221]) ([10.94.250.221]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 01:26:25 -0800 Message-ID: <5f37d10a-d27f-4365-9411-7d5692633df6@linux.intel.com> Date: Tue, 27 Feb 2024 10:26:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/i915: check before removing mm notifier Content-Language: en-US To: Tvrtko Ursulin , Nirmoy Das , intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, Andi Shyti , Shawn Lee References: <20240219125047.28906-1-nirmoy.das@intel.com> <3c1a25f9-b1ee-4832-a89c-68813cc72416@linux.intel.com> <96eec421-090a-4420-ab94-098414334e29@linux.intel.com> From: Nirmoy Das In-Reply-To: <96eec421-090a-4420-ab94-098414334e29@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Tvrtko, On 2/27/2024 10:04 AM, Tvrtko Ursulin wrote: > > On 21/02/2024 11:52, Nirmoy Das wrote: >> Merged it to drm-intel-gt-next with s/check/Check > > Shouldn't this have had: > > Fixes: ed29c2691188 ("drm/i915: Fix userptr so we do not have to worry > about obj->mm.lock, v7.") > Cc: # v5.13+ > > ? > Yes. Sorry, I missed that. Can we still the tag ? Thanks, Nirmoy > Regards, > > Tvrtko > >> On 2/19/2024 1:50 PM, Nirmoy Das wrote: >>> Error in mmu_interval_notifier_insert() can leave a NULL >>> notifier.mm pointer. Catch that and return early. >>> >>> Cc: Andi Shyti >>> Cc: Shawn Lee >>> Signed-off-by: Nirmoy Das >>> --- >>>   drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 3 +++ >>>   1 file changed, 3 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c >>> b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c >>> index 0e21ce9d3e5a..61abfb505766 100644 >>> --- a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c >>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c >>> @@ -349,6 +349,9 @@ i915_gem_userptr_release(struct >>> drm_i915_gem_object *obj) >>>   { >>>       GEM_WARN_ON(obj->userptr.page_ref); >>> +    if (!obj->userptr.notifier.mm) >>> +        return; >>> + >>> mmu_interval_notifier_remove(&obj->userptr.notifier); >>>       obj->userptr.notifier.mm = NULL; >>>   }