From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v3] drm/i915/execlists: Use coherent writes into the context image Date: Fri, 14 Sep 2018 10:12:15 +0100 Message-ID: <5f63bf2f-6b8d-7491-a26c-c18cba2024f6@linux.intel.com> References: <20180913173243.2667-2-chris@chris-wilson.co.uk> <20180913193302.25446-1-chris@chris-wilson.co.uk> <153691330743.23741.371785054285403111@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id F051B6E647 for ; Fri, 14 Sep 2018 09:12:20 +0000 (UTC) In-Reply-To: <153691330743.23741.371785054285403111@skylake-alporthouse-com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE0LzA5LzIwMTggMDk6MjEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTA5LTE0IDA5OjE0OjU0KQo+Pgo+PiBPbiAxMy8wOS8yMDE4IDIwOjMz LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+Pj4gaW5k ZXggZDdmY2JiYThlOTgyLi43YjFmMzIyZjIzMmIgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfbHJjLmMKPj4+IEBAIC0xMjk0LDcgKzEyOTQsNyBAQCBzdGF0aWMgaW50IF9fY29udGV4dF9w aW4oc3RydWN0IGk5MTVfZ2VtX2NvbnRleHQgKmN0eCwgc3RydWN0IGk5MTVfdm1hICp2bWEpCj4+ PiAgICAgICAgICogb24gYW4gYWN0aXZlIGNvbnRleHQgKHdoaWNoIGJ5IG5hdHVyZSBpcyBhbHJl YWR5IG9uIHRoZSBHUFUpLgo+Pj4gICAgICAgICAqLwo+Pj4gICAgICAgIGlmICghKHZtYS0+Zmxh Z3MgJiBJOTE1X1ZNQV9HTE9CQUxfQklORCkpIHsKPj4+IC0gICAgICAgICAgICAgZXJyID0gaTkx NV9nZW1fb2JqZWN0X3NldF90b19ndHRfZG9tYWluKHZtYS0+b2JqLCB0cnVlKTsKPj4+ICsgICAg ICAgICAgICAgZXJyID0gaTkxNV9nZW1fb2JqZWN0X3NldF90b193Y19kb21haW4odm1hLT5vYmos IHRydWUpOwo+Pgo+PiBJIGFtIHN0aWxsIGNvbmZ1c2VkIGJ5IHRoaXMuIENhY2hlIGZsdXNoaW5n IGVmZmVjdHMgb2YgdGhlIG9sZCBhbmQgbmV3Cj4+IGNhbGwgc2VlbSB0aGUgc2FtZSBkdWUgb2Jq ZWN0IGJlaW5nIGluIENQVSB3cml0ZSBkb21haW4gYXQgdGhpcyBwb2ludC4KPj4gV2hhdCBjaGFu Z2VzIGlzIHRoYXQgaXQgd2lsbCBiZSBtYXJrZWQgZGlmZmVyZW50bHkgZnJvbSB0aGlzIHBvaW50 IG9uZS4KPj4gRG9lcyB0aGF0IGNvbWUgaW50byBwbGF5IGxhdGVyIGluIHRoZSBvYmplY3RzIGxp ZmV0aW1lIGFuZCB3aGVyZT8KPiAKPiBObywganVzdCB0YWtpbmcgdGhlIG9wcG9ydHVuaXR5IHRv IHVzZSBhIG1vcmUgY29ycmVjdCBkb21haW4gbm93IHRoYXQgaXQKPiBleGlzdHMgYW5kIGxvZ2lj YWxseSB0aWVzIGluIHdpdGggdXNpbmcgV0MuCgpPay4KCj4+PiAgICAgICAgICAgICAgICBpZiAo ZXJyKQo+Pj4gICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gZXJyOwo+Pj4gICAgICAgIH0K Pj4+IEBAIC0xMzIyLDcgKzEzMjIsOSBAQCBfX2V4ZWNsaXN0c19jb250ZXh0X3BpbihzdHJ1Y3Qg aW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4+PiAgICAgICAgaWYgKHJldCkKPj4+ICAgICAgICAg ICAgICAgIGdvdG8gZXJyOwo+Pj4gICAgCj4+PiAtICAgICB2YWRkciA9IGk5MTVfZ2VtX29iamVj dF9waW5fbWFwKGNlLT5zdGF0ZS0+b2JqLCBJOTE1X01BUF9XQik7Cj4+PiArICAgICB2YWRkciA9 IGk5MTVfZ2VtX29iamVjdF9waW5fbWFwKGNlLT5zdGF0ZS0+b2JqLAo+Pj4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBpOTE1X2NvaGVyZW50X21hcF90eXBlKGN0eC0+aTkx NSkgfAo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBJOTE1X01BUF9P VkVSUklERSk7Cj4+Cj4+IE92ZXJyaWRlIE1BUF9XQiBmcm9tIHBvcHVsYXRlX2xyX2NvbnRleHQg LSBPSyBJIHRoaW5rLgo+Pgo+Pj4gICAgICAgIGlmIChJU19FUlIodmFkZHIpKSB7Cj4+PiAgICAg ICAgICAgICAgICByZXQgPSBQVFJfRVJSKHZhZGRyKTsKPj4+ICAgICAgICAgICAgICAgIGdvdG8g dW5waW5fdm1hOwo+Pj4gQEAgLTI3NTMsNyArMjc1NSw3IEBAIHBvcHVsYXRlX2xyX2NvbnRleHQo c3RydWN0IGk5MTVfZ2VtX2NvbnRleHQgKmN0eCwKPj4+ICAgICAgICAgICAgICAgIHZvaWQgKmRl ZmF1bHRzOwo+Pj4gICAgCj4+PiAgICAgICAgICAgICAgICBkZWZhdWx0cyA9IGk5MTVfZ2VtX29i amVjdF9waW5fbWFwKGVuZ2luZS0+ZGVmYXVsdF9zdGF0ZSwKPj4+IC0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBJOTE1X01BUF9XQik7Cj4+PiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSTkxNV9NQVBfRk9SQ0Vf V0IpOwo+Pj4gICAgICAgICAgICAgICAgaWYgKElTX0VSUihkZWZhdWx0cykpIHsKPj4+ICAgICAg ICAgICAgICAgICAgICAgICAgcmV0ID0gUFRSX0VSUihkZWZhdWx0cyk7Cj4+PiAgICAgICAgICAg ICAgICAgICAgICAgIGdvdG8gZXJyX3VucGluX2N0eDsKPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9yaW5nYnVmZmVyLmMKPj4+IGluZGV4IGQwZWY1MGJmOTMwYS4uMWViNjhkNzdiNjZjIDEw MDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4+ PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPj4+IEBAIC0x Mjg4LDcgKzEyODgsNyBAQCBhbGxvY19jb250ZXh0X3ZtYShzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz ICplbmdpbmUpCj4+PiAgICAgICAgICAgICAgICB9Cj4+PiAgICAKPj4+ICAgICAgICAgICAgICAg IGRlZmF1bHRzID0gaTkxNV9nZW1fb2JqZWN0X3Bpbl9tYXAoZW5naW5lLT5kZWZhdWx0X3N0YXRl LAo+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEk5 MTVfTUFQX1dCKTsKPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBJOTE1X01BUF9GT1JDRV9XQik7Cj4+PiAgICAgICAgICAgICAgICBpZiAoSVNfRVJS KGRlZmF1bHRzKSkgewo+Pj4gICAgICAgICAgICAgICAgICAgICAgICBlcnIgPSBQVFJfRVJSKGRl ZmF1bHRzKTsKPj4+ICAgICAgICAgICAgICAgICAgICAgICAgZ290byBlcnJfbWFwOwo+Pj4KPj4K Pj4gVGhlc2UgdHdvIGRvIG5vdCBuZWVkIHRvIGJlIGNoYW5nZWQgQUZBSUNULgo+IAo+IEkgdGhp bmsgd2UgY2Fubm90IHJlbHkgb24gZW5naW5lLT5kZWZhdWx0X3N0YXRlIGFsd2F5cyBiZWluZyBN QVBfV0IKPiBhbHJlYWR5IGF0IHRoaXMgcG9pbnQsIGR1ZSB0byBub3QgaGF2aW5nIGFuIGlkbGUg Y3ljbGUgYmV0d2VlbiBjcmVhdGlvbgo+IG9mIGVuZ2luZS0+ZGVmYXVsdF9zdGF0ZSBvbiBtb2R1 bGVfbG9hZCBhbmQgZmlyc3QgdXNlLgogPgogPiBIYXZpbmcgdGhvdWdodCBvZiB0aGF0IGxhc3Qg bmlnaHQsIEkgZGlkIG1lYW4gdG8gYWRkIGEgY2FsbCB0bwogPiBfX2k5MTVfZ2VtX3BhcmsoKSBk dXJpbmcgaW5pdCBzbyB3ZSBmb3JjZWQgb3Vyc2VsdmVzIHRvIGlkbGUuCgpJIGRvbid0IGZvbGxv dyAtIGFsbCBwbGFjZXMgd2hlcmUgd2UgbWFwIGl0IHVzZSBNQVBfV0IuIElzbid0IGZvcmNlIGZs YWcgCmp1c3QgdG8gb3ZlcnJpZGUgdGhlIGV4aXN0aW5nIGRpZmZlcmVudCBtYXBwaW5nPwoKUmVn YXJkcywKClR2cnRrbwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==