From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Auld Subject: Re: [PATCH 02/22] drm/i915/gtt: Serialise both updates to PDE and our shadow Date: Mon, 17 Jun 2019 11:36:36 +0100 Message-ID: <5fcbdb69-4b40-f433-4977-381bdb4907c3@intel.com> References: <20190617071912.20256-1-chris@chris-wilson.co.uk> <20190617071912.20256-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 67D2A89159 for ; Mon, 17 Jun 2019 10:36:39 +0000 (UTC) In-Reply-To: <20190617071912.20256-2-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: mika.kuoppala@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gMTcvMDYvMjAxOSAwODoxOCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+IEN1cnJlbnRseSwgd2Ug cGVyZm9ybSBhIGxvY2tlZCB1cGRhdGUgb2YgdGhlIHNoYWRvdyBlbnRyeSB3aGVuCj4gYWxsb2Nh dGluZyBhIHBhZ2UgZGlyZWN0b3J5IGVudHJ5IHN1Y2ggdGhhdCBpZiB0d28gY2xpZW50cyBhcmUK PiBjb25jdXJyZW50bHkgYWxsb2NhdGluZyBuZWlnaGJvdXJpbmcgcmFuZ2VzIHdlIG9ubHkgaW5z ZXJ0IG9uZSBuZXcgZW50cnkKPiBmb3IgdGhlIHBhaXIgb2YgdGhlbS4gSG93ZXZlciwgd2UgYWxz byBuZWVkIHRvIHNlcmlhbGlzZSBib3RoIGNsaWVudHMKPiB3cnQgdG8gdGhlIGFjdHVhbCBlbnRy eSBpbiB0aGUgSFcgdGFibGUsIG9yIGVsc2Ugd2UgbWF5IGFsbG93IG9uZSBjbGllbnQKPiBvciBl dmVuIGEgdGhpcmQgY2xpZW50IHRvIHByb2NlZWQgYWhlYWQgb2YgdGhlIEhXIHdyaXRlLiBNeSBo YW5kd2F2ZQo+IGJlZm9yZSB3YXMgdGhhdCB1bmRlciB0aGUgX3BhdGhvbG9naWNhbF8gY29uZGl0 aW9uIHdlIHdvdWxkIHNlZSB0aGUKPiBzY3JhdGNoIGVudHJ5IGluc3RlYWQgb2YgdGhlIGV4cGVj dGVkIGVudHJ5LCBjYXVzaW5nIGEgdGVtcG9yYXJ5Cj4gZ2xpdGNoLiBUaGF0IHN0YXJ2YXRpb24g Y29uZGl0aW9uIHdpbGwgZXZlbnR1YWxseSBzaG93IHVwIGluIHByYWN0aWNlLCBzbwo+IGZpeCBp dC4KPiAKPiBUaGUgcmVhc29uIGZvciB0aGUgcHJldmlvdXMgY2hlYXQgd2FzIHRvIGF2b2lkIGhh dmluZyB0byBmcmVlIHRoZSBleHRyYQo+IGFsbG9jYXRpb24gd2hpbGUgdW5kZXIgdGhlIHNwaW5s b2NrLiBOb3csIHdlIGtlZXAgdGhlIGV4dHJhIGVudHJ5Cj4gYWxsb2NhdGVkIHVudGlsIHRoZSBl bmQgaW5zdGVhZC4KPiAKPiBGaXhlczogMWQxYjU0OTBiOTFjICgiZHJtL2k5MTUvZ3R0OiBSZXBs YWNlIHN0cnVjdF9tdXRleCBzZXJpYWxpc2F0aW9uIGZvciBhbGxvY2F0aW9uIikKPiBTaWduZWQt b2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogTWF0 dGhldyBBdWxkIDxtYXR0aGV3LmF1bGRAaW50ZWwuY29tPgo+IENjOiBNaWthIEt1b3BwYWxhIDxt aWthLmt1b3BwYWxhQGludGVsLmNvbT4KPiAtLS0KCltzbmlwXQoKPiAgIAo+ICAgc3RhdGljIGlu dCBnZW44X3ByZWFsbG9jYXRlX3RvcF9sZXZlbF9wZHAoc3RydWN0IGk5MTVfcHBndHQgKnBwZ3R0 KQo+IEBAIC0xODE5LDExICsxODMxLDEzIEBAIHN0YXRpYyBpbnQgZ2VuNl9hbGxvY192YV9yYW5n ZShzdHJ1Y3QgaTkxNV9hZGRyZXNzX3NwYWNlICp2bSwKPiAgIAkJCSAgICAgICB1NjQgc3RhcnQs IHU2NCBsZW5ndGgpCj4gICB7Cj4gICAJc3RydWN0IGdlbjZfcHBndHQgKnBwZ3R0ID0gdG9fZ2Vu Nl9wcGd0dChpOTE1X3ZtX3RvX3BwZ3R0KHZtKSk7Cj4gKwlzdHJ1Y3QgaTkxNV9wYWdlX3RhYmxl ICphbGxvYyA9IE5VTEw7Cj4gICAJc3RydWN0IGk5MTVfcGFnZV90YWJsZSAqcHQ7Cj4gICAJaW50 ZWxfd2FrZXJlZl90IHdha2VyZWY7Cj4gICAJdTY0IGZyb20gPSBzdGFydDsKPiAgIAl1bnNpZ25l ZCBpbnQgcGRlOwo+ICAgCWJvb2wgZmx1c2ggPSBmYWxzZTsKPiArCWludCByZXQ7CgpyZXQgPSAw OwoKPiAgIAo+ICAgCXdha2VyZWYgPSBpbnRlbF9ydW50aW1lX3BtX2dldCgmdm0tPmk5MTUtPnJ1 bnRpbWVfcG0pOwo+ICAgCj4gQEAgLTE4MzIsMTkgKzE4NDYsMTggQEAgc3RhdGljIGludCBnZW42 X2FsbG9jX3ZhX3JhbmdlKHN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtLAo+ICAgCQljb25z dCB1bnNpZ25lZCBpbnQgY291bnQgPSBnZW42X3B0ZV9jb3VudChzdGFydCwgbGVuZ3RoKTsKPiAg IAo+ICAgCQlpZiAocHQgPT0gdm0tPnNjcmF0Y2hfcHQpIHsKPiAtCQkJc3RydWN0IGk5MTVfcGFn ZV90YWJsZSAqb2xkOwo+IC0KPiAgIAkJCXNwaW5fdW5sb2NrKCZwcGd0dC0+YmFzZS5wZC5sb2Nr KTsKPiAgIAo+IC0JCQlwdCA9IGFsbG9jX3B0KHZtKTsKPiArCQkJcHQgPSBhbGxvYzsKCldlIGhh dmUgdG8gcmVzZXQgdGhpcywgbm8/Cgo+ICsJCQlpZiAoIXB0KQo+ICsJCQkJcHQgPSBhbGxvY19w dCh2bSk7Cj4gICAJCQlpZiAoSVNfRVJSKHB0KSkKPiAgIAkJCQlnb3RvIHVud2luZF9vdXQ7Cgpy ZXQgPSBQVFJfRVJSKCk7Cgo+ICAgCj4gICAJCQlnZW42X2luaXRpYWxpemVfcHQodm0sIHB0KTsK PiAgIAo+IC0JCQlvbGQgPSBjbXB4Y2hnKCZwcGd0dC0+YmFzZS5wZC5wYWdlX3RhYmxlW3BkZV0s Cj4gLQkJCQkgICAgICB2bS0+c2NyYXRjaF9wdCwgcHQpOwo+IC0JCQlpZiAob2xkID09IHZtLT5z Y3JhdGNoX3B0KSB7Cj4gKwkJCXNwaW5fbG9jaygmcHBndHQtPmJhc2UucGQubG9jayk7Cj4gKwkJ CWlmIChwcGd0dC0+YmFzZS5wZC5wYWdlX3RhYmxlW3BkZV0gPT0gdm0tPnNjcmF0Y2hfcHQpIHsK PiAgIAkJCQlwcGd0dC0+YmFzZS5wZC5wYWdlX3RhYmxlW3BkZV0gPSBwdDsKPiAgIAkJCQlpZiAo aTkxNV92bWFfaXNfYm91bmQocHBndHQtPnZtYSwKPiAgIAkJCQkJCSAgICAgIEk5MTVfVk1BX0dM T0JBTF9CSU5EKSkgewo+IEBAIC0xODUyLDExICsxODY1LDkgQEAgc3RhdGljIGludCBnZW42X2Fs bG9jX3ZhX3JhbmdlKHN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtLAo+ICAgCQkJCQlmbHVz aCA9IHRydWU7Cj4gICAJCQkJfQo+ICAgCQkJfSBlbHNlIHsKPiAtCQkJCWZyZWVfcHQodm0sIHB0 KTsKPiAtCQkJCXB0ID0gb2xkOwo+ICsJCQkJYWxsb2MgPSBwdDsKPiArCQkJCXB0ID0gcHBndHQt PmJhc2UucGQucGFnZV90YWJsZVtwZGVdOwo+ICAgCQkJfQo+IC0KPiAtCQkJc3Bpbl9sb2NrKCZw cGd0dC0+YmFzZS5wZC5sb2NrKTsKPiAgIAkJfQo+ICAgCj4gICAJCWF0b21pY19hZGQoY291bnQs ICZwdC0+dXNlZF9wdGVzKTsKPiBAQCAtMTg2OCwxNCArMTg3OSwxNSBAQCBzdGF0aWMgaW50IGdl bjZfYWxsb2NfdmFfcmFuZ2Uoc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4gICAJCWdl bjZfZ2d0dF9pbnZhbGlkYXRlKHZtLT5pOTE1KTsKPiAgIAl9Cj4gICAKPiAtCWludGVsX3J1bnRp bWVfcG1fcHV0KCZ2bS0+aTkxNS0+cnVudGltZV9wbSwgd2FrZXJlZik7Cj4gLQo+IC0JcmV0dXJu IDA7Cj4gKwlnb3RvIG91dDsKPiAgIAo+ICAgdW53aW5kX291dDoKPiAtCWludGVsX3J1bnRpbWVf cG1fcHV0KCZ2bS0+aTkxNS0+cnVudGltZV9wbSwgd2FrZXJlZik7Cj4gICAJZ2VuNl9wcGd0dF9j bGVhcl9yYW5nZSh2bSwgZnJvbSwgc3RhcnQgLSBmcm9tKTsKPiAtCXJldHVybiAtRU5PTUVNOwo+ ICtvdXQ6Cj4gKwlpZiAoYWxsb2MpCj4gKwkJZnJlZV9wdCh2bSwgYWxsb2MpOwo+ICsJaW50ZWxf cnVudGltZV9wbV9wdXQoJnZtLT5pOTE1LT5ydW50aW1lX3BtLCB3YWtlcmVmKTsKPiArCXJldHVy biByZXQ7Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyBpbnQgZ2VuNl9wcGd0dF9pbml0X3NjcmF0Y2go c3RydWN0IGdlbjZfcHBndHQgKnBwZ3R0KQo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZng=