From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B75BC4338F for ; Wed, 18 Aug 2021 21:37:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1771610A6 for ; Wed, 18 Aug 2021 21:37:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A1771610A6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E3A396E8CE; Wed, 18 Aug 2021 21:36:43 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id F2E296E8CD for ; Wed, 18 Aug 2021 21:35:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629322535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bAbD/eVam4u1SYhNVAX23sMHxA0bG00/tb6Wr76aYKM=; b=Ak3tClSjTlSNz2fPEJuV/uMMZ8eVv+TBh9XW6rrEm1nRfQqUoea0bzb0TAve6RRcn8xj1V 7AvfTBmEpbmV445a4tm//ycvKcEi19XoVLOUxHbSqRd9mTVCJVwXr+koAbNaejdrPRB/ea GddY7HNd58WhPHK2yQ3Aa2ZpKNO3M6c= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-66-U89Lm2tgPkmhLjCu0js5_A-1; Wed, 18 Aug 2021 17:35:33 -0400 X-MC-Unique: U89Lm2tgPkmhLjCu0js5_A-1 Received: by mail-qk1-f199.google.com with SMTP id p23-20020a05620a22f700b003d5ac11ac5cso2701209qki.15 for ; Wed, 18 Aug 2021 14:35:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:organization:user-agent:mime-version :content-transfer-encoding; bh=bAbD/eVam4u1SYhNVAX23sMHxA0bG00/tb6Wr76aYKM=; b=FEfMs3SShKrljrTtCRP0WMTbZQ+hSnin71M4tvM/JVWRXV4IQ1/fWi9zltDaL+AE3x /JfSBQZ10unThYi3Konn2OAl7gv8a/cc3VkUgstD5oopSeQ/37KITN0DE6y4V8yr4rPP ItSmH4Trb6WfwIsE7Cv1kN014jHpI358E+chKPXVjegBJWUrvAukIJAhBHSVNkbN+mJF W6N58JrqMRsop7FeXQP1bf4XSHyz66ljVkUNgKhzuDKbJZVRx3Eso8t1kqe8Hmlic+/Q 7AouuZrpe3kR5ILuX0pTuPocke6q1rltMZSWFfeEDXjhQAbZRYC47hw0KvO8D+XG58ve 5D2Q== X-Gm-Message-State: AOAM530S61VsmqtKTo8pvbpcVs/VM/GssqtapswQMhdDAmeBQQbUg63f lAZ9ug7im2V0tnszJTQnkOGwcOKSqPXn0zMdZjITmD4hNY83LNxmAVQdWxagygCr83+ams88EBR NlB4yEYE6t+fXrwKMH/FxjWvBmbq6 X-Received: by 2002:a37:a20f:: with SMTP id l15mr407102qke.24.1629322533474; Wed, 18 Aug 2021 14:35:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyab94WdMZQNzhRfZljOGpr8kFn3ZnlXdrrtrXo2AH/UwoRuFvOGPN7L8HPmN/brDTP7nCFjw== X-Received: by 2002:a37:a20f:: with SMTP id l15mr407091qke.24.1629322533300; Wed, 18 Aug 2021 14:35:33 -0700 (PDT) Received: from Ruby.lyude.net (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id f7sm543379qko.52.2021.08.18.14.35.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 14:35:32 -0700 (PDT) Message-ID: <5fe94acc12b0f845cd55436056368c3bf9e48544.camel@redhat.com> From: Lyude Paul To: Hans de Goede , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Imre Deak , Greg Kroah-Hartman , Guenter Roeck , Heikki Krogerus Cc: Daniel Vetter , David Airlie , intel-gfx , dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org Date: Wed, 18 Aug 2021 17:35:31 -0400 In-Reply-To: <20210817215201.795062-2-hdegoede@redhat.com> References: <20210817215201.795062-1-hdegoede@redhat.com> <20210817215201.795062-2-hdegoede@redhat.com> Organization: Red Hat User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lyude@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH 1/8] drm/connector: Give connector sysfs devices there own device_type X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 2021-08-17 at 23:51 +0200, Hans de Goede wrote: > Give connector sysfs devices there own device_type, this allows us to > check if a device passed to functions dealing with generic devices is > a drm_connector or not. > > A check like this is necessary in the drm_connector_acpi_bus_match() > function added in the next patch in this series. > > Tested-by: Heikki Krogerus > Signed-off-by: Hans de Goede > --- >  drivers/gpu/drm/drm_sysfs.c | 50 +++++++++++++++++++++++++++---------- >  1 file changed, 37 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c > index 968a9560b4aa..f9d92bbb1f98 100644 > --- a/drivers/gpu/drm/drm_sysfs.c > +++ b/drivers/gpu/drm/drm_sysfs.c > @@ -50,6 +50,10 @@ static struct device_type drm_sysfs_device_minor = { >         .name = "drm_minor" >  }; >   > +static struct device_type drm_sysfs_device_connector = { > +       .name = "drm_connector", > +}; > + >  struct class *drm_class; >   >  static char *drm_devnode(struct device *dev, umode_t *mode) > @@ -102,6 +106,11 @@ void drm_sysfs_destroy(void) >         drm_class = NULL; >  } >   > +static void drm_sysfs_release(struct device *dev) > +{ > +       kfree(dev); > +} > + >  /* >   * Connector properties >   */ > @@ -273,27 +282,47 @@ static const struct attribute_group > *connector_dev_groups[] = { >  int drm_sysfs_connector_add(struct drm_connector *connector) >  { >         struct drm_device *dev = connector->dev; > +       struct device *kdev; > +       int r; >   >         if (connector->kdev) >                 return 0; >   > -       connector->kdev = > -               device_create_with_groups(drm_class, dev->primary->kdev, 0, > -                                         connector, connector_dev_groups, > -                                         "card%d-%s", dev->primary->index, > -                                         connector->name); > +       kdev = kzalloc(sizeof(*kdev), GFP_KERNEL); > +       if (!kdev) > +               return -ENOMEM; > + > +       device_initialize(kdev); > +       kdev->class = drm_class; > +       kdev->type = &drm_sysfs_device_connector; > +       kdev->parent = dev->primary->kdev; > +       kdev->groups = connector_dev_groups; > +       kdev->release = drm_sysfs_release; > +       dev_set_drvdata(kdev, connector); > + > +       r = dev_set_name(kdev, "card%d-%s", dev->primary->index, connector- > >name); > +       if (r) > +               goto err_free; > + >         DRM_DEBUG("adding \"%s\" to sysfs\n", >                   connector->name); >   > -       if (IS_ERR(connector->kdev)) { > -               DRM_ERROR("failed to register connector device: %ld\n", > PTR_ERR(connector->kdev)); > -               return PTR_ERR(connector->kdev); > +       r = device_add(kdev); > +       if (r) { > +               DRM_ERROR("failed to register connector device: %d\n", r); > +               goto err_free; Should probably be using drm_err() here since we have access to struct drm_device * >         } >   > +       connector->kdev = kdev; > + >         if (connector->ddc) >                 return sysfs_create_link(&connector->kdev->kobj, >                                  &connector->ddc->dev.kobj, "ddc"); >         return 0; > + > +err_free: > +       put_device(kdev); > +       return r; >  } >   >  void drm_sysfs_connector_remove(struct drm_connector *connector) > @@ -374,11 +403,6 @@ void drm_sysfs_connector_status_event(struct > drm_connector *connector, >  } >  EXPORT_SYMBOL(drm_sysfs_connector_status_event); >   > -static void drm_sysfs_release(struct device *dev) > -{ > -       kfree(dev); > -} > - >  struct device *drm_sysfs_minor_alloc(struct drm_minor *minor) >  { >         const char *minor_str; -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat