From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 12/13] drm/i915: Bump signaler priority on adding a waiter Date: Tue, 7 May 2019 13:46:45 +0100 Message-ID: <602e3ddb-cd81-06f3-b6b0-2581b4199dcf@linux.intel.com> References: <20190503115225.30831-1-chris@chris-wilson.co.uk> <20190503115225.30831-12-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6FB576E7B8 for ; Tue, 7 May 2019 12:46:47 +0000 (UTC) In-Reply-To: <20190503115225.30831-12-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAzLzA1LzIwMTkgMTI6NTIsIENocmlzIFdpbHNvbiB3cm90ZToKPiBUaGUgaGFuZGxpbmcg b2YgdGhlIG5vLXByZWVtcHRpb24gcHJpb3JpdHkgbGV2ZWwgaW1wb3NlcyB0aGUgcmVzdHJpY3Rp b24KPiB0aGF0IHdlIG5lZWQgdG8gbWFpbnRhaW4gdGhlIGltcGxpZWQgb3JkZXJpbmcgZXZlbiB0 aG91Z2ggcHJlZW1wdGlvbiBpcwo+IGRpc2FibGVkLiBPdGhlcndpc2Ugd2UgbWF5IGVuZCB1cCB3 aXRoIGFuIEFCLUJBIGRlYWRsb2NrIGFjcm9zcyBtdWx0aXBsZQo+IGVuZ2luZSBkdWUgdG8gYSBy ZWFsIHByZWVtcHRpb24gZXZlbnQgcmVvcmRlcmluZyB0aGUgbm8tcHJlZW1wdGlvbgo+IFdBSVRz LiBUbyByZXNvbHZlIHRoaXMgaXNzdWUgd2UgY3VycmVudGx5IHByb21vdGUgYWxsIHJlcXVlc3Rz IHRvIFdBSVQKPiBvbiB1bnN1Ym1pc3Npb24sIGhvd2V2ZXIgdGhpcyBpbnRlcmZlcmVzIHdpdGgg dGhlIHRpbWVzbGljaW5nCj4gcmVxdWlyZW1lbnQgdGhhdCB3ZSBkbyBub3QgYXBwbHkgYW55IGlt cGxpY2l0IHByb21vdGlvbiB0aGF0IHdpbGwgZGVmZWF0Cj4gdGhlIHJvdW5kLXJvYmluIHRpbWVz bGljZSBsaXN0LiAoSWYgd2UgYXV0b21hdGljYWxseSBwcm9tb3RlIHRoZSBhY3RpdmUKPiByZXF1 ZXN0IGl0IHdpbGwgZ28gYmFjayB0byB0aGUgaGVhZCBvZiB0aGUgcXVldWUgYW5kIG5vdCB0aGUg dGFpbCEpCj4gCj4gU28gd2UgbmVlZCBpbXBsaWNpdCBwcm9tb3Rpb24gdG8gcHJldmVudCByZW9y ZGVyaW5nIGFyb3VuZCBzZW1hcGhvcmVzCj4gd2hlcmUgd2UgYXJlIG5vdCBhbGxvd2VkIHRvIHBy ZWVtcHQsIGFuZCB3ZSBtdXN0IGF2b2lkIGltcGxpY2l0Cj4gcHJvbW90aW9uIG9uIHVuc3VibWlz c2lvbi4gU28gaW5zdGVhZCBvZiBhdCB1bnN1Ym1pdCwgaWYgd2UgYXBwbHkgdGhhdAo+IGltcGxp Y2l0IHByb21vdGlvbiBvbiBhZGRpbmcgdGhlIGRlcGVuZGVuY3ksIHdlIGF2b2lkIHRoZSBzZW1h cGhvcmUKPiBkZWFkbG9jayBhbmQgd2UgYWxzbyByZWR1Y2UgdGhlIGdhaW5zIG1hZGUgYnkgdGhl IHByb21vdGlvbiBmb3IgdXNlcgo+IHNwYWNlIHdhaXRpbmcuIEZ1cnRoZXJtb3JlLCBieSBrZWVw aW5nIHRoZSBlYXJsaWVyIGRlcGVuZGVuY2llcyBhdCBhCj4gaGlnaGVyIGxldmVsLCB3ZSByZWR1 Y2UgdGhlIHNlYXJjaCBzcGFjZSBmb3IgdGltZXNsaWNpbmcgd2l0aG91dAo+IGFsdGVyaW5nIHJ1 bnRpbWUgc2NoZWR1bGluZyB0b28gYmFkbHkgKG5vIGRlcGVuZGVuY2llcyBhdCBhbGwgd2lsbCBi ZQo+IGFzc2lnbmVkIGEgaGlnaGVyIHByaW9yaXR5IGZvciBycnVsKS4KPiAKPiB2MjogTGltaXQg dGhlIGJ1bXAgdG8gZXh0ZXJuYWwgZWRnZXMgKGFzIG9yaWdpbmFsbHkgaW50ZW5kZWQpIGkuZS4K PiBiZXR3ZWVuIGNvbnRleHRzIGFuZCBvdXQgdG8gdGhlIHVzZXIuCj4gCj4gVGVzdGNhc2U6IGln dC9nZW1fY29uY3VycmVudF9ibGl0Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJp c0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9z ZWxmdGVzdF9scmMuYyAgICAgIHwgMTIgKysrKysrKystLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X3JlcXVlc3QuYyAgICAgICAgIHwgIDkgLS0tLS0tLS0tCj4gICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X3NjaGVkdWxlci5jICAgICAgIHwgMTEgKysrKysrKysrKysKPiAgIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc2NoZWR1bGVyX3R5cGVzLmggfCAgMyArKy0KPiAgIDQg ZmlsZXMgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L3NlbGZ0ZXN0X2xyYy5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvZ3Qvc2VsZnRlc3RfbHJjLmMKPiBpbmRleCA0YjA0Mjg5M2RjMGUuLjVi M2Q4ZTMzZjFjZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9zZWxmdGVz dF9scmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L3NlbGZ0ZXN0X2xyYy5jCj4g QEAgLTk4LDEyICs5OCwxNCBAQCBzdGF0aWMgaW50IGxpdmVfYnVzeXdhaXRfcHJlZW1wdCh2b2lk ICphcmcpCj4gICAJY3R4X2hpID0ga2VybmVsX2NvbnRleHQoaTkxNSk7Cj4gICAJaWYgKCFjdHhf aGkpCj4gICAJCWdvdG8gZXJyX3VubG9jazsKPiAtCWN0eF9oaS0+c2NoZWQucHJpb3JpdHkgPSBJ TlRfTUFYOwo+ICsJY3R4X2hpLT5zY2hlZC5wcmlvcml0eSA9Cj4gKwkJSTkxNV9VU0VSX1BSSU9S SVRZKEk5MTVfQ09OVEVYVF9NQVhfVVNFUl9QUklPUklUWSk7Cj4gICAKPiAgIAljdHhfbG8gPSBr ZXJuZWxfY29udGV4dChpOTE1KTsKPiAgIAlpZiAoIWN0eF9sbykKPiAgIAkJZ290byBlcnJfY3R4 X2hpOwo+IC0JY3R4X2xvLT5zY2hlZC5wcmlvcml0eSA9IElOVF9NSU47Cj4gKwljdHhfbG8tPnNj aGVkLnByaW9yaXR5ID0KPiArCQlJOTE1X1VTRVJfUFJJT1JJVFkoSTkxNV9DT05URVhUX01JTl9V U0VSX1BSSU9SSVRZKTsKPiAgIAo+ICAgCW9iaiA9IGk5MTVfZ2VtX29iamVjdF9jcmVhdGVfaW50 ZXJuYWwoaTkxNSwgUEFHRV9TSVpFKTsKPiAgIAlpZiAoSVNfRVJSKG9iaikpIHsKPiBAQCAtOTU4 LDEyICs5NjAsMTQgQEAgc3RhdGljIGludCBsaXZlX3ByZWVtcHRfaGFuZyh2b2lkICphcmcpCj4g ICAJY3R4X2hpID0ga2VybmVsX2NvbnRleHQoaTkxNSk7Cj4gICAJaWYgKCFjdHhfaGkpCj4gICAJ CWdvdG8gZXJyX3NwaW5fbG87Cj4gLQljdHhfaGktPnNjaGVkLnByaW9yaXR5ID0gSTkxNV9DT05U RVhUX01BWF9VU0VSX1BSSU9SSVRZOwo+ICsJY3R4X2hpLT5zY2hlZC5wcmlvcml0eSA9Cj4gKwkJ STkxNV9VU0VSX1BSSU9SSVRZKEk5MTVfQ09OVEVYVF9NQVhfVVNFUl9QUklPUklUWSk7Cj4gICAK PiAgIAljdHhfbG8gPSBrZXJuZWxfY29udGV4dChpOTE1KTsKPiAgIAlpZiAoIWN0eF9sbykKPiAg IAkJZ290byBlcnJfY3R4X2hpOwo+IC0JY3R4X2xvLT5zY2hlZC5wcmlvcml0eSA9IEk5MTVfQ09O VEVYVF9NSU5fVVNFUl9QUklPUklUWTsKPiArCWN0eF9sby0+c2NoZWQucHJpb3JpdHkgPQo+ICsJ CUk5MTVfVVNFUl9QUklPUklUWShJOTE1X0NPTlRFWFRfTUlOX1VTRVJfUFJJT1JJVFkpOwo+ICAg Cj4gICAJZm9yX2VhY2hfZW5naW5lKGVuZ2luZSwgaTkxNSwgaWQpIHsKPiAgIAkJc3RydWN0IGk5 MTVfcmVxdWVzdCAqcnE7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cmVxdWVzdC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXF1ZXN0LmMKPiBpbmRleCA4 Y2IzZWQ1NTMxZTMuLjA2NWRhMWJjYmI0YyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X3JlcXVlc3QuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVx dWVzdC5jCj4gQEAgLTQ2OCwxNSArNDY4LDYgQEAgdm9pZCBfX2k5MTVfcmVxdWVzdF91bnN1Ym1p dChzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpyZXF1ZXN0KQo+ICAgCS8qIFdlIG1heSBiZSByZWN1cnNp bmcgZnJvbSB0aGUgc2lnbmFsIGNhbGxiYWNrIG9mIGFub3RoZXIgaTkxNSBmZW5jZSAqLwo+ICAg CXNwaW5fbG9ja19uZXN0ZWQoJnJlcXVlc3QtPmxvY2ssIFNJTkdMRV9ERVBUSF9ORVNUSU5HKTsK PiAgIAo+IC0JLyoKPiAtCSAqIEFzIHdlIGRvIG5vdCBhbGxvdyBXQUlUIHRvIHByZWVtcHQgaW5m bGlnaHQgcmVxdWVzdHMsCj4gLQkgKiBvbmNlIHdlIGhhdmUgZXhlY3V0ZWQgYSByZXF1ZXN0LCBh bG9uZyB3aXRoIHRyaWdnZXJpbmcKPiAtCSAqIGFueSBleGVjdXRpb24gY2FsbGJhY2tzLCB3ZSBt dXN0IHByZXNlcnZlIGl0cyBvcmRlcmluZwo+IC0JICogd2l0aGluIHRoZSBub24tcHJlZW1wdGli bGUgRklGTy4KPiAtCSAqLwo+IC0JQlVJTERfQlVHX09OKF9fTk9fUFJFRU1QVElPTiAmIH5JOTE1 X1BSSU9SSVRZX01BU0spOyAvKiBvbmx5IGludGVybmFsICovCj4gLQlyZXF1ZXN0LT5zY2hlZC5h dHRyLnByaW9yaXR5IHw9IF9fTk9fUFJFRU1QVElPTjsKPiAtCj4gICAJaWYgKHRlc3RfYml0KERN QV9GRU5DRV9GTEFHX0VOQUJMRV9TSUdOQUxfQklULCAmcmVxdWVzdC0+ZmVuY2UuZmxhZ3MpKQo+ ICAgCQlpOTE1X3JlcXVlc3RfY2FuY2VsX2JyZWFkY3J1bWIocmVxdWVzdCk7Cj4gICAKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zY2hlZHVsZXIuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfc2NoZWR1bGVyLmMKPiBpbmRleCAzODBjYjczNDNhMTAuLmZmMGNh NTcxOGY5NyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3NjaGVkdWxl ci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zY2hlZHVsZXIuYwo+IEBAIC0z OTEsNiArMzkxLDE2IEBAIGJvb2wgX19pOTE1X3NjaGVkX25vZGVfYWRkX2RlcGVuZGVuY3koc3Ry dWN0IGk5MTVfc2NoZWRfbm9kZSAqbm9kZSwKPiAgIAkJICAgICFub2RlX3N0YXJ0ZWQoc2lnbmFs KSkKPiAgIAkJCW5vZGUtPmZsYWdzIHw9IEk5MTVfU0NIRURfSEFTX1NFTUFQSE9SRV9DSEFJTjsK PiAgIAo+ICsJCS8qCj4gKwkJICogQXMgd2UgZG8gbm90IGFsbG93IFdBSVQgdG8gcHJlZW1wdCBp bmZsaWdodCByZXF1ZXN0cywKPiArCQkgKiBvbmNlIHdlIGhhdmUgZXhlY3V0ZWQgYSByZXF1ZXN0 LCBhbG9uZyB3aXRoIHRyaWdnZXJpbmcKPiArCQkgKiBhbnkgZXhlY3V0aW9uIGNhbGxiYWNrcywg d2UgbXVzdCBwcmVzZXJ2ZSBpdHMgb3JkZXJpbmcKPiArCQkgKiB3aXRoaW4gdGhlIG5vbi1wcmVl bXB0aWJsZSBGSUZPLgo+ICsJCSAqLwo+ICsJCUJVSUxEX0JVR19PTihfX05PX1BSRUVNUFRJT04g JiB+STkxNV9QUklPUklUWV9NQVNLKTsKPiArCQlpZiAoZmxhZ3MgJiBJOTE1X0RFUEVOREVOQ1lf RVhURVJOQUwpCj4gKwkJCV9fYnVtcF9wcmlvcml0eShzaWduYWwsIF9fTk9fUFJFRU1QVElPTik7 Cj4gKwoKSSBkb24ndCByZWFsbHkgZm9sbG93IGhvdyBjYW4gdGhpcyBiZSBva2F5IGZyb20gaGVy ZS4gSXQgZ2l2ZXMgd2FpdCAKcHJpb3JpdHkgdG8gZXZlcnkgcmVxdWVzdCB3aGljaCBoYXMgYSBk ZXBlbmRlbmN5IG5vdy4gV2hpY2ggc291bmRzIG5vdCAKZmFyIG9mZiBmcm9tIHJlbW92aW5nIHRo ZSBwcmlvcml0eSBidW1wIGZvciB3YWl0ZXJzIGFsdG9nZXRoZXIuIE9yIApyZXZlcnNpbmcgdGhp bmdzIGFuZCBnaXZpbmcgcmVxdWVzdHMgd2l0aCBubyBwcmlvcml0eSBhIGJvb3N0LgoKUmVnYXJk cywKClR2cnRrbwoKPiAgIAkJcmV0ID0gdHJ1ZTsKPiAgIAl9Cj4gICAKPiBAQCAtNDA5LDYgKzQx OSw3IEBAIGludCBpOTE1X3NjaGVkX25vZGVfYWRkX2RlcGVuZGVuY3koc3RydWN0IGk5MTVfc2No ZWRfbm9kZSAqbm9kZSwKPiAgIAkJcmV0dXJuIC1FTk9NRU07Cj4gICAKPiAgIAlpZiAoIV9faTkx NV9zY2hlZF9ub2RlX2FkZF9kZXBlbmRlbmN5KG5vZGUsIHNpZ25hbCwgZGVwLAo+ICsJCQkJCSAg ICAgIEk5MTVfREVQRU5ERU5DWV9FWFRFUk5BTCB8Cj4gICAJCQkJCSAgICAgIEk5MTVfREVQRU5E RU5DWV9BTExPQykpCj4gICAJCWk5MTVfZGVwZW5kZW5jeV9mcmVlKGRlcCk7Cj4gICAKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zY2hlZHVsZXJfdHlwZXMuaCBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc2NoZWR1bGVyX3R5cGVzLmgKPiBpbmRleCAxNjZhNDU3 ODg0YjIuLjNlMzA5NjMxYmQwYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3NjaGVkdWxlcl90eXBlcy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9z Y2hlZHVsZXJfdHlwZXMuaAo+IEBAIC02Niw3ICs2Niw4IEBAIHN0cnVjdCBpOTE1X2RlcGVuZGVu Y3kgewo+ICAgCXN0cnVjdCBsaXN0X2hlYWQgd2FpdF9saW5rOwo+ICAgCXN0cnVjdCBsaXN0X2hl YWQgZGZzX2xpbms7Cj4gICAJdW5zaWduZWQgbG9uZyBmbGFnczsKPiAtI2RlZmluZSBJOTE1X0RF UEVOREVOQ1lfQUxMT0MgQklUKDApCj4gKyNkZWZpbmUgSTkxNV9ERVBFTkRFTkNZX0FMTE9DCQlC SVQoMCkKPiArI2RlZmluZSBJOTE1X0RFUEVOREVOQ1lfRVhURVJOQUwJQklUKDEpCj4gICB9Owo+ ICAgCj4gICAjZW5kaWYgLyogX0k5MTVfU0NIRURVTEVSX1RZUEVTX0hfICovCj4gCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==