* [PATCH] drm/i915/hdcp: Remove the encoder check in hdcp enable
@ 2025-08-19 15:07 Suraj Kandpal
2025-08-19 16:12 ` ✗ i915.CI.BAT: failure for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Suraj Kandpal @ 2025-08-19 15:07 UTC (permalink / raw)
To: intel-xe, intel-gfx; +Cc: jani.nikula, ankit.k.nautiyal, Suraj Kandpal
Remove the intel_encoder NULL check from _intel_hdcp_enable with
all the changes it has gone through this check has become unnecessary
since at this point the connector is supposed to have the encoder
in it.
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
index 42202c8bb066..e11cf26ed0bf 100644
--- a/drivers/gpu/drm/i915/display/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
@@ -2446,12 +2446,6 @@ static int _intel_hdcp_enable(struct intel_atomic_state *state,
if (!hdcp->shim)
return -ENOENT;
- if (!connector->encoder) {
- drm_err(display->drm, "[CONNECTOR:%d:%s] encoder is not initialized\n",
- connector->base.base.id, connector->base.name);
- return -ENODEV;
- }
-
mutex_lock(&hdcp->mutex);
mutex_lock(&dig_port->hdcp.mutex);
drm_WARN_ON(display->drm,
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✗ i915.CI.BAT: failure for drm/i915/hdcp: Remove the encoder check in hdcp enable
2025-08-19 15:07 [PATCH] drm/i915/hdcp: Remove the encoder check in hdcp enable Suraj Kandpal
@ 2025-08-19 16:12 ` Patchwork
2025-08-20 8:41 ` [PATCH] " Nautiyal, Ankit K
2025-08-21 4:40 ` ✓ i915.CI.BAT: success for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2025-08-19 16:12 UTC (permalink / raw)
To: Suraj Kandpal; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6621 bytes --]
== Series Details ==
Series: drm/i915/hdcp: Remove the encoder check in hdcp enable
URL : https://patchwork.freedesktop.org/series/153149/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_17030 -> Patchwork_153149v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_153149v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_153149v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/index.html
Participating hosts (43 -> 42)
------------------------------
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_153149v1:
### IGT changes ###
#### Possible regressions ####
* igt@gem_softpin@safe-alignment:
- fi-hsw-4770: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/fi-hsw-4770/igt@gem_softpin@safe-alignment.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/fi-hsw-4770/igt@gem_softpin@safe-alignment.html
Known issues
------------
Here are the changes found in Patchwork_153149v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@info:
- fi-hsw-4770: [PASS][3] -> [SKIP][4] ([i915#1849] / [i915#2582])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/fi-hsw-4770/igt@fbdev@info.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/fi-hsw-4770/igt@fbdev@info.html
* igt@fbdev@nullptr:
- fi-hsw-4770: [PASS][5] -> [SKIP][6] ([i915#2582]) +3 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/fi-hsw-4770/igt@fbdev@nullptr.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/fi-hsw-4770/igt@fbdev@nullptr.html
* igt@i915_selftest@live@workarounds:
- bat-mtlp-6: [PASS][7] -> [DMESG-FAIL][8] ([i915#12061]) +1 other test dmesg-fail
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
- bat-dg2-14: [PASS][9] -> [DMESG-FAIL][10] ([i915#12061]) +1 other test dmesg-fail
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/bat-dg2-14/igt@i915_selftest@live@workarounds.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/bat-dg2-14/igt@i915_selftest@live@workarounds.html
#### Possible fixes ####
* igt@i915_selftest@live:
- bat-arlh-3: [INCOMPLETE][11] ([i915#14764]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/bat-arlh-3/igt@i915_selftest@live.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/bat-arlh-3/igt@i915_selftest@live.html
* igt@i915_selftest@live@gt_tlb:
- bat-arlh-3: [INCOMPLETE][13] ([i915#14837]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/bat-arlh-3/igt@i915_selftest@live@gt_tlb.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/bat-arlh-3/igt@i915_selftest@live@gt_tlb.html
* igt@i915_selftest@live@sanitycheck:
- fi-kbl-7567u: [DMESG-WARN][15] ([i915#13735]) -> [PASS][16] +79 other tests pass
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/fi-kbl-7567u/igt@i915_selftest@live@sanitycheck.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/fi-kbl-7567u/igt@i915_selftest@live@sanitycheck.html
* igt@kms_busy@basic@flip:
- fi-kbl-7567u: [DMESG-WARN][17] ([i915#13735] / [i915#180]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/fi-kbl-7567u/igt@kms_busy@basic@flip.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/fi-kbl-7567u/igt@kms_busy@basic@flip.html
* igt@kms_pm_rpm@basic-pci-d3-state:
- fi-kbl-7567u: [DMESG-WARN][19] ([i915#13735] / [i915#13890] / [i915#180]) -> [PASS][20] +52 other tests pass
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/fi-kbl-7567u/igt@kms_pm_rpm@basic-pci-d3-state.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/fi-kbl-7567u/igt@kms_pm_rpm@basic-pci-d3-state.html
#### Warnings ####
* igt@i915_selftest@live:
- bat-atsm-1: [DMESG-FAIL][21] ([i915#12061] / [i915#14204]) -> [DMESG-FAIL][22] ([i915#12061] / [i915#13929])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/bat-atsm-1/igt@i915_selftest@live.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/bat-atsm-1/igt@i915_selftest@live.html
* igt@i915_selftest@live@mman:
- bat-atsm-1: [DMESG-FAIL][23] ([i915#14204]) -> [DMESG-FAIL][24] ([i915#13929])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/bat-atsm-1/igt@i915_selftest@live@mman.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/bat-atsm-1/igt@i915_selftest@live@mman.html
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#13735]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13735
[i915#13890]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13890
[i915#13929]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13929
[i915#14204]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14204
[i915#14764]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14764
[i915#14837]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14837
[i915#180]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/180
[i915#1849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1849
[i915#2582]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2582
Build changes
-------------
* Linux: CI_DRM_17030 -> Patchwork_153149v1
CI-20190529: 20190529
CI_DRM_17030: deb6c5d08f8b84ea7e019b7682631c6375cc17aa @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8496: acea60af09e5f4b3cb0cd6838c23ef1e92c17323 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_153149v1: deb6c5d08f8b84ea7e019b7682631c6375cc17aa @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/index.html
[-- Attachment #2: Type: text/html, Size: 8165 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915/hdcp: Remove the encoder check in hdcp enable
2025-08-19 15:07 [PATCH] drm/i915/hdcp: Remove the encoder check in hdcp enable Suraj Kandpal
2025-08-19 16:12 ` ✗ i915.CI.BAT: failure for " Patchwork
@ 2025-08-20 8:41 ` Nautiyal, Ankit K
2025-08-21 4:40 ` ✓ i915.CI.BAT: success for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Nautiyal, Ankit K @ 2025-08-20 8:41 UTC (permalink / raw)
To: Suraj Kandpal, intel-xe, intel-gfx; +Cc: jani.nikula
On 8/19/2025 8:37 PM, Suraj Kandpal wrote:
> Remove the intel_encoder NULL check from _intel_hdcp_enable
Missing period '.' here.
> with
> all the changes it has gone through this check has become unnecessary
> since at this point the connector is supposed to have the encoder
> in it.
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
With above typo fixed:
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_hdcp.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
> index 42202c8bb066..e11cf26ed0bf 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
> @@ -2446,12 +2446,6 @@ static int _intel_hdcp_enable(struct intel_atomic_state *state,
> if (!hdcp->shim)
> return -ENOENT;
>
> - if (!connector->encoder) {
> - drm_err(display->drm, "[CONNECTOR:%d:%s] encoder is not initialized\n",
> - connector->base.base.id, connector->base.name);
> - return -ENODEV;
> - }
> -
> mutex_lock(&hdcp->mutex);
> mutex_lock(&dig_port->hdcp.mutex);
> drm_WARN_ON(display->drm,
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✓ i915.CI.BAT: success for drm/i915/hdcp: Remove the encoder check in hdcp enable
2025-08-19 15:07 [PATCH] drm/i915/hdcp: Remove the encoder check in hdcp enable Suraj Kandpal
2025-08-19 16:12 ` ✗ i915.CI.BAT: failure for " Patchwork
2025-08-20 8:41 ` [PATCH] " Nautiyal, Ankit K
@ 2025-08-21 4:40 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2025-08-21 4:40 UTC (permalink / raw)
To: Suraj Kandpal; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6187 bytes --]
== Series Details ==
Series: drm/i915/hdcp: Remove the encoder check in hdcp enable
URL : https://patchwork.freedesktop.org/series/153149/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_17030 -> Patchwork_153149v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/index.html
Participating hosts (43 -> 42)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_153149v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@info:
- fi-hsw-4770: [PASS][1] -> [SKIP][2] ([i915#1849] / [i915#2582])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/fi-hsw-4770/igt@fbdev@info.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/fi-hsw-4770/igt@fbdev@info.html
* igt@fbdev@nullptr:
- fi-hsw-4770: [PASS][3] -> [SKIP][4] ([i915#2582]) +3 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/fi-hsw-4770/igt@fbdev@nullptr.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/fi-hsw-4770/igt@fbdev@nullptr.html
* igt@gem_softpin@safe-alignment:
- fi-hsw-4770: [PASS][5] -> [FAIL][6] ([i915#14853])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/fi-hsw-4770/igt@gem_softpin@safe-alignment.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/fi-hsw-4770/igt@gem_softpin@safe-alignment.html
* igt@i915_selftest@live@workarounds:
- bat-mtlp-6: [PASS][7] -> [DMESG-FAIL][8] ([i915#12061]) +1 other test dmesg-fail
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
- bat-dg2-14: [PASS][9] -> [DMESG-FAIL][10] ([i915#12061]) +1 other test dmesg-fail
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/bat-dg2-14/igt@i915_selftest@live@workarounds.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/bat-dg2-14/igt@i915_selftest@live@workarounds.html
#### Possible fixes ####
* igt@i915_selftest@live:
- bat-arlh-3: [INCOMPLETE][11] ([i915#14764]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/bat-arlh-3/igt@i915_selftest@live.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/bat-arlh-3/igt@i915_selftest@live.html
* igt@i915_selftest@live@gt_tlb:
- bat-arlh-3: [INCOMPLETE][13] ([i915#14837]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/bat-arlh-3/igt@i915_selftest@live@gt_tlb.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/bat-arlh-3/igt@i915_selftest@live@gt_tlb.html
* igt@i915_selftest@live@sanitycheck:
- fi-kbl-7567u: [DMESG-WARN][15] ([i915#13735]) -> [PASS][16] +79 other tests pass
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/fi-kbl-7567u/igt@i915_selftest@live@sanitycheck.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/fi-kbl-7567u/igt@i915_selftest@live@sanitycheck.html
* igt@kms_busy@basic@flip:
- fi-kbl-7567u: [DMESG-WARN][17] ([i915#13735] / [i915#180]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/fi-kbl-7567u/igt@kms_busy@basic@flip.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/fi-kbl-7567u/igt@kms_busy@basic@flip.html
* igt@kms_pm_rpm@basic-pci-d3-state:
- fi-kbl-7567u: [DMESG-WARN][19] ([i915#13735] / [i915#13890] / [i915#180]) -> [PASS][20] +52 other tests pass
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/fi-kbl-7567u/igt@kms_pm_rpm@basic-pci-d3-state.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/fi-kbl-7567u/igt@kms_pm_rpm@basic-pci-d3-state.html
#### Warnings ####
* igt@i915_selftest@live:
- bat-atsm-1: [DMESG-FAIL][21] ([i915#12061] / [i915#14204]) -> [DMESG-FAIL][22] ([i915#12061] / [i915#13929])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/bat-atsm-1/igt@i915_selftest@live.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/bat-atsm-1/igt@i915_selftest@live.html
* igt@i915_selftest@live@mman:
- bat-atsm-1: [DMESG-FAIL][23] ([i915#14204]) -> [DMESG-FAIL][24] ([i915#13929])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17030/bat-atsm-1/igt@i915_selftest@live@mman.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/bat-atsm-1/igt@i915_selftest@live@mman.html
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#13735]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13735
[i915#13890]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13890
[i915#13929]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13929
[i915#14204]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14204
[i915#14764]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14764
[i915#14837]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14837
[i915#14853]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14853
[i915#180]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/180
[i915#1849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1849
[i915#2582]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2582
Build changes
-------------
* Linux: CI_DRM_17030 -> Patchwork_153149v1
CI-20190529: 20190529
CI_DRM_17030: deb6c5d08f8b84ea7e019b7682631c6375cc17aa @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8496: acea60af09e5f4b3cb0cd6838c23ef1e92c17323 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_153149v1: deb6c5d08f8b84ea7e019b7682631c6375cc17aa @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153149v1/index.html
[-- Attachment #2: Type: text/html, Size: 7718 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-21 4:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-19 15:07 [PATCH] drm/i915/hdcp: Remove the encoder check in hdcp enable Suraj Kandpal
2025-08-19 16:12 ` ✗ i915.CI.BAT: failure for " Patchwork
2025-08-20 8:41 ` [PATCH] " Nautiyal, Ankit K
2025-08-21 4:40 ` ✓ i915.CI.BAT: success for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).