From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v4 2/5] drm/i915: Watchdog timeout: IRQ handler for gen8+ Date: Tue, 19 Mar 2019 12:46:06 +0000 Message-ID: <617e8e5f-ca57-ef8f-e085-79dbf70dcb2d@linux.intel.com> References: <20190221025820.28447-1-carlos.santa@intel.com> <20190221025820.28447-3-carlos.santa@intel.com> <155143298308.5847.17161978101892410437@skylake-alporthouse-com> <62d65486-a45a-7cf9-1574-1c961be2ee9a@linux.intel.com> <1271220339df25098eb6305051972c80c125bc52.camel@intel.com> <25e7c81e-18fc-0676-dd27-d0a7823aaa41@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id B628A892FD for ; Tue, 19 Mar 2019 12:46:24 +0000 (UTC) In-Reply-To: <25e7c81e-18fc-0676-dd27-d0a7823aaa41@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Carlos Santa , Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Michel Thierry List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE5LzAzLzIwMTkgMTI6MzksIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+IAo+IE9uIDE4LzAz LzIwMTkgMDA6MTUsIENhcmxvcyBTYW50YSB3cm90ZToKPj4gT24gTW9uLCAyMDE5LTAzLTExIGF0 IDEwOjM5ICswMDAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4+IE9uIDA4LzAzLzIwMTkgMDM6 MTYsIENhcmxvcyBTYW50YSB3cm90ZToKPj4+PiBPbiBGcmksIDIwMTktMDMtMDEgYXQgMDk6MzYg KzAwMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPj4+Pj4+Cj4+Pj4+Cj4+Pj4+IFF1b3RpbmcgQ2Fy bG9zIFNhbnRhICgyMDE5LTAyLTIxIDAyOjU4OjE2KQo+Pj4+Pj4gKyNkZWZpbmUgR0VOOF9XQVRD SERPR18xMDAwVVMoZGV2X3ByaXYpCj4+Pj4+PiB3YXRjaGRvZ190b19jbG9ja19jb3VudHMoZGV2 X3ByaXYsIDEwMDApCj4+Pj4+PiArc3RhdGljIHZvaWQgZ2VuOF93YXRjaGRvZ19pcnFfaGFuZGxl cih1bnNpZ25lZCBsb25nIGRhdGEpCj4+Pj4+PiArewo+Pj4+Pj4gK8KgwqDCoMKgwqDCoCBzdHJ1 Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUgPSAoc3RydWN0Cj4+Pj4+PiBpbnRlbF9lbmdpbmVf Y3MKPj4+Pj4+ICopZGF0YTsKPj4+Pj4+ICvCoMKgwqDCoMKgwqAgc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2ID0gZW5naW5lLT5pOTE1Owo+Pj4+Pj4gK8KgwqDCoMKgwqDCoCB1bnNp Z25lZCBpbnQgaHVuZyA9IDA7Cj4+Pj4+PiArwqDCoMKgwqDCoMKgIHUzMiBjdXJyZW50X3NlcW5v PTA7Cj4+Pj4+PiArwqDCoMKgwqDCoMKgIGNoYXIgbXNnWzgwXTsKPj4+Pj4+ICvCoMKgwqDCoMKg wqAgdW5zaWduZWQgaW50IHRtcDsKPj4+Pj4+ICvCoMKgwqDCoMKgwqAgaW50IGxlbjsKPj4+Pj4+ ICsKPj4+Pj4+ICvCoMKgwqDCoMKgwqAgLyogU3RvcCB0aGUgY291bnRlciB0byBwcmV2ZW50IGZ1 cnRoZXIgdGltZW91dAo+Pj4+Pj4gaW50ZXJydXB0cwo+Pj4+Pj4gKi8KPj4+Pj4+ICvCoMKgwqDC oMKgwqAgSTkxNV9XUklURV9GVyhSSU5HX0NOVFIoZW5naW5lLT5tbWlvX2Jhc2UpLAo+Pj4+Pj4g Z2V0X3dhdGNoZG9nX2Rpc2FibGUoZW5naW5lKSk7Cj4+Pj4+PiArCj4+Pj4+PiArwqDCoMKgwqDC oMKgIC8qIFJlYWQgdGhlIGhlYXJ0YmVhdCBzZXFubyBvbmNlIGFnYWluIHRvIGNoZWNrIGlmIHdl Cj4+Pj4+PiBhcmUKPj4+Pj4+IHN0dWNrPyAqLwo+Pj4+Pj4gK8KgwqDCoMKgwqDCoCBjdXJyZW50 X3NlcW5vID0KPj4+Pj4+IGludGVsX2VuZ2luZV9nZXRfaGFuZ2NoZWNrX3NlcW5vKGVuZ2luZSk7 Cj4+Pj4+Cj4+Pj4+IEkgaGF2ZSBzYWlkIHRoaXMgYmVmb3JlLCBidXQgdGhpcyBkb2Vzbid0IGV4 aXN0IGVpdGhlciwgaXQncyBqdXN0Cj4+Pj4+IGEKPj4+Pj4gdGVtcG9yYXJ5IGdsaXRjaCBpbiB0 aGUgbWF0cml4Lgo+Pj4+Pgo+Pj4+Cj4+Pj4gQ2hyaXMsIFR2cnRrbywgSSBuZWVkIHNvbWUgZ3Vp ZGFuY2Ugb24gaG93IHRvIGZpbmQgdGhlIHF1aWx0eSBzZXFubwo+Pj4+IGR1cmluZyBhIGhhbmcs IGNhbiB5b3UgcGxlYXNlIGFkdmljZSBoZXJlIHdoYXQgdG8gZG8/Cj4+Pgo+Pj4gV2hlbiBhbiBp bnRlcnJ1cHQgZmlyZXMgeW91IG5lZWQgdG8gYXNjZXJ0YWluIHdoZXRoZXIgdGhlIHNhbWUKPj4+ IHJlcXVlc3QKPj4+IHdoaWNoIGVuYWJsZWQgdGhlIHdhdGNoZG9nIGlzIHJ1bm5pbmcsIGNvcnJl Y3Q/Cj4+Pgo+Pj4gU28gSSB0aGluayB5b3Ugd291bGQgbmVlZCB0aGlzLCB3aXRoIGEgZGlzY2xh aW1lciB0aGF0IEkgaGF2ZW4ndAo+Pj4gdGhvdWdodAo+Pj4gYWJvdXQgdGhlIGRldGFpbHMgcmVh bGx5Ogo+Pj4KPj4+IDEuIFRha2UgYSByZWZlcmVuY2UgdG8gdGltZWxpbmUgaHdzcCB3aGVuIHNl dHRpbmcgdXAgdGhlIHdhdGNoZG9nIGZvcgo+Pj4gYQo+Pj4gcmVxdWVzdC4KPj4+Cj4+PiAyLiBT dG9yZSB0aGUgaW5pdGlhbCBzZXFubyBhc3NvY2lhdGVkIHdpdGggdGhpcyByZXF1ZXN0Lgo+Pj4K Pj4+IDMuIEZvcmNlIGVuYWJsZSB1c2VyIGludGVycnVwdHMuCj4+Pgo+Pj4gNC4gV2hlbiB0aW1l b3V0IGZpcmVzLCBpbnNwZWN0IHRoZSBIV1NQIHNlcW5vIHRvIHNlZSBpZiB0aGUgcmVxdWVzdAo+ Pj4gY29tcGxldGVkIG9yIG5vdC4KPj4+Cj4+PiA1LiBSZXNldCB0aGUgZW5naW5lIGlmIG5vdCBj b21wbGV0ZWQuCj4+Pgo+Pj4gNi4gUHV0IHRoZSB0aW1lbGluZS9od3NwIHJlZmVyZW5jZS4KPj4K Pj4KPj4gc3RhdGljIGludCBnZW44X2VtaXRfYmJfc3RhcnQoc3RydWN0IGk5MTVfcmVxdWVzdCAq cnEsCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCB1NjQgb2Zmc2V0LCB1MzIKPj4gbGVuLAo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY29uc3QgdW5zaWduZWQKPj4gaW50IGZsYWdz KQo+PiB7Cj4+IMKgwqDCoMKgc3RydWN0IGk5MTVfdGltZWxpbmUgKnRsOwo+PiDCoMKgwqDCoHUz MiBzZXFubzsKPj4KPj4gwqDCoMKgwqBpZiAoZW5hYmxlX3dhdGNoZG9nKSB7Cj4+IMKgwqDCoMKg wqDCoMKgIC8qIFN0YXJ0IHdhdGNoZG9nIHRpbWVyICovCj4+IMKgwqDCoMKgwqDCoMKgIGNzID0g Z2VuOF9lbWl0X3N0YXJ0X3dhdGNoZG9nKHJxLCBjcyk7Cj4+IMKgwqDCoMKgwqDCoMKgIHRsID0g Y2UtPnJpbmctPnRpbWVsaW5lOwo+PiDCoMKgwqDCoMKgwqDCoCBpOTE1X3RpbWVsaW5lX2dldF9z ZXFubyh0bCwgcnEsICZzZXFubyk7Cj4+IMKgwqDCoMKgwqDCoMKgIC8qU3RvcmUgaW5pdGlhbCBo d3NwIHNlcW5vIGFzc29jaWF0ZWQgd2l0aCB0aGlzIHJlcXVlc3QKPj4gwqDCoMKgwqDCoMKgwqAg ZW5naW5lLT53YXRjaGRvZ19od3NwX3NlcW5vID0gdGwtPmh3c3Bfc2Vxbm87Cj4gCj4gWW91IHNo b3VsZCBub3QgbmVlZCB0byBhbGxvY2F0ZSBhIG5ldyBzZXFubyBhbmQgYWxzbyBoYXZpbmcgc29t ZXRoaW5nIAo+IHN0b3JlZCBwZXIgZW5naW5lIGRvZXMgbm90IG1ha2UgY2xlYXIgaG93IHdpbGwg eW91IHNvbHZlIG91dCBvZiBvcmRlci4KPiAKPiBNYXliZSB5b3UganVzdCBzZXQgdXAgdGhlIHRp bWVyLCB0aGVuIGxldHMgc2VlIGJlbG93Li4KPiAKPiBBbHNvLCBhcmUgeW91IG5vdCB0cnlpbmcg dG8gZG8gdGhlIHNvZnR3YXJlIGltcGxlbWVudGF0aW9uIHRvIHN0YXJ0IHdpdGg/Cj4gCj4+IMKg wqDCoMKgfQo+Pgo+PiB9Cj4+Cj4+IHN0YXRpYyB2b2lkIGdlbjhfd2F0Y2hkb2dfdGFza2xldCh1 bnNpZ25lZCBsb25nIGRhdGEpCj4+IHsKPj4gwqDCoMKgwqDCoMKgwqAgc3RydWN0IGk5MTVfcmVx dWVzdCAqcnE7Cj4+Cj4+IMKgwqDCoMKgwqDCoMKgIHJxID0gaW50ZWxfZW5naW5lX2ZpbmRfYWN0 aXZlX3JlcXVlc3QoZW5naW5lKTsKPj4KPj4gwqDCoMKgwqDCoMKgwqAgLyogSW5zcGVjdCB0aGUg d2F0Y2hkb2cgc2Vxbm8gb25jZSBhZ2FpbiBmb3IKPj4gY29tcGxldGlvbj8gKi8KPj4gwqDCoMKg wqDCoMKgwqAgaWYgKCFpOTE1X3NlcW5vX3Bhc3NlZChlbmdpbmUtPndhdGNoZG9nX2h3c3Bfc2Vx bm8sIHJxLQo+Pj4gZmVuY2Uuc2Vxbm8pKSB7Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLy9S ZXNldCBFbmdpbmUKPj4gwqDCoMKgwqDCoMKgwqAgfQo+PiB9Cj4gCj4gV2hhdCBoYXBwZW5zIGlm IHlvdSBzaW1wbHkgcmVzZXQgd2l0aG91dCBjaGVja2luZyBhbnl0aGluZz8gWW91IGtub3cgaHcg Cj4gdGltZXIgd291bGRuJ3QgaGF2ZSBmaXJlZCBpZiB0aGUgY29udGV4dCB3YXNuJ3QgcnVubmlu ZywgY29ycmVjdD8KPiAKPiAoSWdub3JpbmcgdGhlIHJhY2UgY29uZGl0aW9uIGJldHdlZW4gaW50 ZXJydXB0IHJhaXNlZCAtPiBodyBpbnRlcnJ1cHQgCj4gZGVsaXZlcmVkIC0+IHNlcnZpY2VkIC0+ IHRhc2tsZXQgc2NoZWR1bGVkIC0+IHRhc2tsZXQgcnVubmluZy4gV2hpY2ggbWF5IAo+IG1lYW4g cmVxdWVzdCBoYXMgY29tcGxldGVkIGluIHRoZSBtZWFudGltZSBhbmQgeW91IHJlc2V0IHRoZSBl bmdpbmUgZm9yIAo+IG5vdGhpbmcuIEJ1dCB0aGlzIGlzIHByb2JhYmx5IG5vdCAxMDAlIHNvbHZh YmxlLikKCkdvb2QgaWRlYSB3b3VsZCBiZSB0byB3cml0ZSBzb21lIHRlc3RzIHRvIGV4ZXJjaXNl IHNvbWUgbm9ybWFsIGFuZCBtb3JlIAplZGdlIGNhc2Ugc2NlbmFyaW9zIGxpa2UgY29hbGVzY2Vk IHJlcXVlc3RzLCBwcmVlbXB0aW9uIGV0Yy4gQ2hlY2tpbmcgCndoaWNoIHJlcXVlc3QgZ290IHJl c2V0IGV0Yy4KClJlZ2FyZHMsCgpUdnJ0a28KCj4gUmVnYXJkcywKPiAKPiBUdnJ0a28KPiAKPj4g VHZydGtvLCBpcyB0aGUgYWJvdmUgYWNjZXB0YWJsZSB0byBpbnNwZWN0IHdoZXRoZXIgdGhlIHNl cW5vIGhhcwo+PiBjb21wbGV0ZWQ/Cj4+Cj4+IEkgbm90aWNlZCB0aGVyZSdzIGEgaGVscGVyIGZ1 bmN0aW9uIGk5MTVfcmVxdWVzdF9jb21wbGV0ZWQoc3RydWN0Cj4+IGk5MTVfcmVxdWVzdCAqcnEp IGJ1dCBpdCB3aWxsIHJlcXVpcmUgbWUgdG8gbW9kaWZ5IGl0IGluIG9yZGVyIHRvIHBhc3MKPj4g MiBkaWZmZXJlbnQgc2Vxbm9zLgo+Pgo+PiBSZWdhcmRzLAo+PiBDYXJsb3MKPj4KPj4+Cj4+PiBJ ZiB0aGUgdXNlciBpbnRlcnJ1cHQgZmlyZXMgd2l0aCB0aGUgcmVxdWVzdCBjb21wbGV0ZWQgY2Fu Y2VsIHRoZQo+Pj4gYWJvdmUKPj4+IG9wZXJhdGlvbnMuCj4+Pgo+Pj4gVGhlcmUgY291bGQgYmUg YW4gaW5oZXJlbnQgcmFjZSBiZXR3ZWVuIGluc3BlY3RpbmcgdGhlIHNlcW5vIGFuZAo+Pj4gZGVj aWRpbmcgdG8gcmVzZXQuIE5vdCBzdXJlIGF0IHRoZSBtb21lbnQgd2hhdCB0byBkby4gTWF5YmUg anVzdCBjYWxsCj4+PiBpdAo+Pj4gYmFkIGx1Y2s/Cj4+Pgo+Pj4gSSBhbHNvIHRoaW5rIGZvciB0 aGUgc29mdHdhcmUgaW1wbGVtZW50YXRpb24geW91IG5lZWQgdG8gZm9yY2Ugbm8KPj4+IHJlcXVl c3QgY29hbGVzY2luZyBmb3IgY29udGV4dHMgd2l0aCB0aW1lb3V0IHNldC4gQmVjYXVzZSB5b3Ug d2FudAo+Pj4gdG8KPj4+IGhhdmUgMTAwJSBkZWZpbmVkIGJvcmRlcnMgZm9yIHJlcXVlc3QgaW4g YW5kIG91dCAtIHNpbmNlIHRoZSB0aW1lb3V0Cj4+PiBpcwo+Pj4gZGVmaW5lZCBwZXIgcmVxdWVz dC4KPj4+Cj4+PiBJbiB0aGlzIGNhc2UgeW91IGRvbid0IG5lZWQgdGhlIHVzZXIgaW50ZXJydXB0 IGZvciB0aGUgdHJhaWxpbmcgZWRnZQo+Pj4gc2lnbmFsIGJ1dCBjYW4gdXNlIGNvbnRleHQgY29t cGxldGUuIE1heWJlIHB1dHRpbmcgaG9va3MgaW50bwo+Pj4gY29udGV4dF9pbi9vdXQgaW4gaW50 ZWxfbHJjLmMgd291bGQgd29yayB1bmRlciB0aGVzZSBjaXJjdW1zdGFuY2VzLgo+Pj4KPj4+IEFs c28gaWYgcHJlZW1wdGVkIHlvdSBuZWVkIHRvIGNhbmNlbCB0aGUgdGltZXIgc2V0dXAgYW5kIHN0 b3JlCj4+PiBlbGFwc2VkCj4+PiBleGVjdXRpb24gdGltZS4KPj4+Cj4+PiBPciBpdCBtYXkgbWFr ZSBzZW5zZSB0byBqdXN0IGRpc2FibGUgcHJlZW1wdGlvbiBmb3IgdGhlc2UgY29udGV4dHMuCj4+ PiBPdGhlcndpc2UgdGhlcmUgaXMgbm8gcG9pbnQgaW4gdHJ5aW5nIHRvIG1hbmRhdGUgdGhlIHRp bWVvdXQ/Cj4+Pgo+Pj4gQnV0IGl0IGlzIGFsc28ga2luZCBvZiBiYWQgc2luY2Ugbm9uLXByaXZp bGVnZWQgY29udGV4dHMgY2FuIG1ha2UKPj4+IHRoZW1zZWx2ZXMgbm9uLXByZWVtcHRhYmxlIGJ5 IHNldHRpbmcgdGhlIHdhdGNoZG9nIHRpbWVvdXQuCj4+Pgo+Pj4gTWF5YmUgYXMgYSBjb21wcm9t aXNlIHdlIG5lZWQgdG8gYXV0b21hdGljYWxseSBhcHBseSBhbiBlbGV2YXRlZAo+Pj4gcHJpb3Jp dHkgbGV2ZWwsIGJ1dCBub3QgYXMgaGlnaCB0byBiZSBjb21wbGV0ZWx5IG5vbi1wcmVlbXB0YWJs ZS4KPj4+IFNvdW5kcwo+Pj4gbGlrZSBhIGhhcmQgcXVlc3Rpb24uCj4+Pgo+Pj4gUmVnYXJkcywK Pj4+Cj4+PiBUdnJ0a28KPj4KPj4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4