Re: [RFC 20/28] drm/i915: Compartmentalize i915_gem_suspend/restore_gtt_mappings

Tvrtko Ursulin
2019-06-14T09:52:01Z

On 13/06/2019 15:08, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-06-13 14:35:31)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Having made start to better code compartmentalization by introducing
>> struct intel_gt, continue the theme elsewhere in code by making functions
>> take parameters take what logically makes most sense for them instead of
>> the global struct drm_i915_private.
>
> So I am debating whether this is better off as part of i915_ggtt and not
> i915_address_space.

In terms of what object is passed in?

They mostly operate on but, but end with ggtt->invalidate(ggtt). And
while we could move that vfunc to vm (and have it NULL for !ggtt) would
it make sense?

Regards,

Tvrtko