Re: [PATCH 7/7] drm/i915/skl: Warn if the cached cdclk freq is not the requested one

Ville Syrjälä
2015-06-05T12:24:55Z

On Thu, Jun 04, 2015 at 06:21:35PM +0100, Damien Lespiau wrote:
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index a232dc9..a018465 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -5627,6 +5627,10 @@ static void skl_set_cdclk(struct drm_i915_private *dev_priv, unsigned int freq)
> mutex_unlock(&dev_priv->rps.hw_lock);
>
> intel_update_cdclk(dev);
> +
> + WARN(freq != dev_priv->cdclk_freq,
> + "cdclk requested %d kHz but got %d kHz\n",
> + freq, dev_priv->cdclk_freq);
> }

Could you add this to all the set_cdclk() functions? Maybe
intel_check_cdclk() or something.

>
> void skl_uninit_cdclk(struct drm_i915_private *dev_priv)
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Ville Syrjälä
Intel OTC