intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: <intel-gfx@lists.freedesktop.org>
Cc: <intel-xe@lists.freedesktop.org>, <gustavo.sousa@intel.com>,
	<lucas.demarchi@intel.com>, <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 0/2] Introduce helper for display workarounds and add Wa_16025573575
Date: Thu, 17 Jul 2025 21:26:06 +0530	[thread overview]
Message-ID: <62f66373-78d2-48e8-a0c4-2bb6ecae21c5@intel.com> (raw)
In-Reply-To: <20250711041901.1607823-1-ankit.k.nautiyal@intel.com>


On 7/11/2025 9:48 AM, Ankit Nautiyal wrote:
> This series introduces a generic infrastructure for querying display
> workarounds. The goal is to simplify WA checks, avoid open-coded conditions,
> and make it easier to extend support for future workarounds.
>
> Patch 1 introduces the base infrastructure using an enum and a central
> helper function. It also migrates Wa_16023588340 to use this new interface.
>
> Patch 2 adds support for Wa_16025573575, which applies to PTL platforms
> and requires preserving additional GPIO bits in GMBUS.
>
> The series is in response to the suggestions to unify workaround handling
> and allowing future automation or generation of WA logic in [1].
>
> [1] https://lore.kernel.org/intel-gfx/7f079861f91861e9e895240cd3272f6e29deab7e@intel.com/


Thanks for the feedback, and suggestions. Thanks Jani and Gustavo for 
the reviews.

Patches were pushed to drm-intel-next.

Regards,

Ankit

>
> Rev2:
> -Remove MISSING_CASE, use drm_WARN.
> -Simplify macro for display_wa.
>
> Rev3:
> -Print missing wa_number.
> -Add more documentation for the WA.
> -Extend the WA for WCL.
>
> Ankit Nautiyal (2):
>    drm/i915/display_wa: Add helpers to check wa
>    drm/i915/gmbus: Add Wa_16025573575 for PTL/WCL for bit-bashing
>
>   .../gpu/drm/i915/display/intel_display_wa.c   | 27 +++++++++++++++
>   .../gpu/drm/i915/display/intel_display_wa.h   | 10 ++++++
>   drivers/gpu/drm/i915/display/intel_fbc.c      |  2 +-
>   drivers/gpu/drm/i915/display/intel_gmbus.c    | 34 +++++++++++++++++--
>   4 files changed, 70 insertions(+), 3 deletions(-)
>

  parent reply	other threads:[~2025-07-17 15:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-11  4:18 [PATCH 0/2] Introduce helper for display workarounds and add Wa_16025573575 Ankit Nautiyal
2025-07-11  4:18 ` [PATCH 1/2] drm/i915/display_wa: Add helpers to check wa Ankit Nautiyal
2025-07-16 14:18   ` Gustavo Sousa
2025-07-11  4:19 ` [PATCH 2/2] drm/i915/gmbus: Add Wa_16025573575 for PTL/WCL for bit-bashing Ankit Nautiyal
2025-07-11 11:37   ` Gustavo Sousa
2025-07-15  3:22     ` Nautiyal, Ankit K
2025-07-15 14:22   ` Ankit Nautiyal
2025-07-15 15:56     ` Gustavo Sousa
2025-07-11  7:03 ` ✓ i915.CI.BAT: success for Introduce helper for display workarounds and add Wa_16025573575 (rev3) Patchwork
2025-07-11 11:35 ` ✓ i915.CI.Full: " Patchwork
2025-07-15 21:00 ` ✓ i915.CI.BAT: success for Introduce helper for display workarounds and add Wa_16025573575 (rev4) Patchwork
2025-07-16  6:53 ` ✗ i915.CI.Full: failure " Patchwork
2025-07-17  4:43 ` ✓ i915.CI.Full: success " Patchwork
2025-07-17 15:56 ` Nautiyal, Ankit K [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-07-02  8:46 [PATCH 0/2] Introduce helper for display workarounds and add Wa_16025573575 Ankit Nautiyal
2025-06-30  5:49 Ankit Nautiyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62f66373-78d2-48e8-a0c4-2bb6ecae21c5@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=gustavo.sousa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).