From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 07/10] drm/i915: Reduce spinlock hold time during notify_ring() interrupt Date: Wed, 17 Jan 2018 10:45:16 +0000 Message-ID: <6333fa3e-6e56-797d-cfb4-43ef57c70ea8@linux.intel.com> References: <20180115212455.24046-1-chris@chris-wilson.co.uk> <20180115212455.24046-8-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id C1CA66E3E9 for ; Wed, 17 Jan 2018 10:45:18 +0000 (UTC) In-Reply-To: <20180115212455.24046-8-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE1LzAxLzIwMTggMjE6MjQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBCeSB0YWtpbmcgYWR2 YW50YWdlIG9mIHRoZSBSQ1UgcHJvdGVjdGlvbiBvZiB0aGUgdGFzayBzdHJ1Y3QsIHdlIGNhbiBm aW5kCj4gdGhlIGFwcHJvcHJpYXRlIHNpZ25hbGVyIHVuZGVyIHRoZSBzcGlubG9jayBhbmQgdGhl biByZWxlYXNlIHRoZSBzcGlubG9jawo+IGJlZm9yZSB3YWtpbmcgdGhlIHRhc2sgYW5kIHNpZ25h bGluZyB0aGUgZmVuY2UuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0Bj aHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2ly cS5jIHwgMjkgKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2Vk LCAxOSBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf aXJxLmMKPiBpbmRleCAzNTE3YzY1NDhlMmMuLjBiMjcyNTAxYjczOCAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9pcnEuYwo+IEBAIC0xMDY1LDIxICsxMDY1LDI0IEBAIHN0YXRpYyB2b2lkIGlyb25s YWtlX3Jwc19jaGFuZ2VfaXJxX2hhbmRsZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KQo+ICAgCj4gICBzdGF0aWMgdm9pZCBub3RpZnlfcmluZyhzdHJ1Y3QgaW50ZWxfZW5naW5l X2NzICplbmdpbmUpCj4gICB7Cj4gKwljb25zdCB1MzIgc2Vxbm8gPSBpbnRlbF9lbmdpbmVfZ2V0 X3NlcW5vKGVuZ2luZSk7Cj4gICAJc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpycSA9IE5V TEw7Cj4gKwlzdHJ1Y3QgdGFza19zdHJ1Y3QgKnRzayA9IE5VTEw7Cj4gICAJc3RydWN0IGludGVs X3dhaXQgKndhaXQ7Cj4gICAKPiAtCWlmICghZW5naW5lLT5icmVhZGNydW1icy5pcnFfYXJtZWQp Cj4gKwlpZiAodW5saWtlbHkoIWVuZ2luZS0+YnJlYWRjcnVtYnMuaXJxX2FybWVkKSkKPiAgIAkJ cmV0dXJuOwoKSXQgaXNuJ3QgdW5saWtlbHkgaW4gR3VDIG1vZGUsIGp1c3Qgc2F5aW4nLi4uCgo+ ICAgCj4gICAJYXRvbWljX2luYygmZW5naW5lLT5pcnFfY291bnQpOwo+ICAgCXNldF9iaXQoRU5H SU5FX0lSUV9CUkVBRENSVU1CLCAmZW5naW5lLT5pcnFfcG9zdGVkKTsKPiAgIAo+ICsJcmN1X3Jl YWRfbG9jaygpOwo+ICsKPiAgIAlzcGluX2xvY2soJmVuZ2luZS0+YnJlYWRjcnVtYnMuaXJxX2xv Y2spOwo+ICAgCXdhaXQgPSBlbmdpbmUtPmJyZWFkY3J1bWJzLmlycV93YWl0Owo+ICAgCWlmICh3 YWl0KSB7Cj4gLQkJYm9vbCB3YWtldXAgPSBlbmdpbmUtPmlycV9zZXFub19iYXJyaWVyOwo+IC0K PiAtCQkvKiBXZSB1c2UgYSBjYWxsYmFjayBmcm9tIHRoZSBkbWEtZmVuY2UgdG8gc3VibWl0Cj4g KwkJLyoKPiArCQkgKiBXZSB1c2UgYSBjYWxsYmFjayBmcm9tIHRoZSBkbWEtZmVuY2UgdG8gc3Vi bWl0Cj4gICAJCSAqIHJlcXVlc3RzIGFmdGVyIHdhaXRpbmcgb24gb3VyIG93biByZXF1ZXN0cy4g VG8KPiAgIAkJICogZW5zdXJlIG1pbmltdW0gZGVsYXkgaW4gcXVldWluZyB0aGUgbmV4dCByZXF1 ZXN0IHRvCj4gICAJCSAqIGhhcmR3YXJlLCBzaWduYWwgdGhlIGZlbmNlIG5vdyByYXRoZXIgdGhh biB3YWl0IGZvcgo+IEBAIC0xMDkwLDE5ICsxMDkzLDIwIEBAIHN0YXRpYyB2b2lkIG5vdGlmeV9y aW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIAkJICogYW5kIHRvIGhhbmRs ZSBjb2FsZXNjaW5nIG9mIG11bHRpcGxlIHNlcW5vIHVwZGF0ZXMKPiAgIAkJICogYW5kIG1hbnkg d2FpdGVycy4KPiAgIAkJICovCj4gLQkJaWYgKGk5MTVfc2Vxbm9fcGFzc2VkKGludGVsX2VuZ2lu ZV9nZXRfc2Vxbm8oZW5naW5lKSwKPiAtCQkJCSAgICAgIHdhaXQtPnNlcW5vKSkgewo+ICsJCWlm IChpOTE1X3NlcW5vX3Bhc3NlZChzZXFubywgd2FpdC0+c2Vxbm8pKSB7Cj4gICAJCQlzdHJ1Y3Qg ZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKndhaXRlciA9IHdhaXQtPnJlcXVlc3Q7Cj4gICAKPiAtCQkJ d2FrZXVwID0gdHJ1ZTsKPiAgIAkJCWlmICghdGVzdF9iaXQoRE1BX0ZFTkNFX0ZMQUdfU0lHTkFM RURfQklULAo+ICAgCQkJCSAgICAgICZ3YWl0ZXItPmZlbmNlLmZsYWdzKSAmJgo+ICAgCQkJICAg IGludGVsX3dhaXRfY2hlY2tfcmVxdWVzdCh3YWl0LCB3YWl0ZXIpKQo+ICAgCQkJCXJxID0gaTkx NV9nZW1fcmVxdWVzdF9nZXQod2FpdGVyKTsKPiAtCQl9Cj4gICAKPiAtCQlpZiAod2FrZXVwKQo+ IC0JCQl3YWtlX3VwX3Byb2Nlc3Mod2FpdC0+dHNrKTsKPiArCQkJdHNrID0gd2FpdC0+dHNrOwo+ ICsJCX0gZWxzZSB7Cj4gKwkJCWlmIChlbmdpbmUtPmlycV9zZXFub19iYXJyaWVyICYmCj4gKwkJ CSAgICBpOTE1X3NlcW5vX3Bhc3NlZChzZXFubywgd2FpdC0+c2Vxbm8gLSAxKSkKCkhtIHdoYXQg aXMgdGhpcyBhYm91dD8gV2h5IC0xIG9uIHBsYXRmb3JtcyB3aXRoIGNvaGVyZW5jeSBpc3N1ZXMg YW5kIG5vdCAKc29tZSBvdGhlciBudW1iZXI/IE5lZWRzIGEgY29tbWVudCBhcyBtaW5pbXVtIGJ1 dCBzdGlsbCBpcyBhIGJlaGF2aW91ciAKY2hhbmdlIHdoaWNoIEkgZGlkIG5vdCBpbW1lZGlhdGVs eSBmaWd1cmUgb3V0IGhvdyBpdCBnb2VzIHdpdGggdGhlIApjb21taXQgbWVzc2FnZS4gSWYgaXQg aXMgc29tZSBhZGRpdGlvbmFsIG9wdGltaXphdGlvbiBpdCBuZWVkcyB0byBiZSAKc3BsaXQgb3V0 IGludG8gYSBzZXBhcmF0ZSBwYXRjaC4KCj4gKwkJCQl0c2sgPSB3YWl0LT50c2s7Cj4gKwkJfQo+ ICAgCX0gZWxzZSB7Cj4gICAJCWlmIChlbmdpbmUtPmJyZWFkY3J1bWJzLmlycV9hcm1lZCkKPiAg IAkJCV9faW50ZWxfZW5naW5lX2Rpc2FybV9icmVhZGNydW1icyhlbmdpbmUpOwo+IEBAIC0xMTE0 LDYgKzExMTgsMTEgQEAgc3RhdGljIHZvaWQgbm90aWZ5X3Jpbmcoc3RydWN0IGludGVsX2VuZ2lu ZV9jcyAqZW5naW5lKQo+ICAgCQlpOTE1X2dlbV9yZXF1ZXN0X3B1dChycSk7Cj4gICAJfQo+ICAg Cj4gKwlpZiAodHNrICYmIHRzay0+c3RhdGUgIT0gVEFTS19SVU5OSU5HKQo+ICsJCXdha2VfdXBf cHJvY2Vzcyh0c2spOwo+ICsKPiArCXJjdV9yZWFkX3VubG9jaygpOwo+ICsKPiAgIAl0cmFjZV9p bnRlbF9lbmdpbmVfbm90aWZ5KGVuZ2luZSwgd2FpdCk7Cj4gICB9Cj4gICAKPiAKClJlZ2FyZHMs CgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==