From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 653B2C433F5 for ; Tue, 22 Feb 2022 09:53:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C788410E765; Tue, 22 Feb 2022 09:53:49 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E25610E765; Tue, 22 Feb 2022 09:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645523628; x=1677059628; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=/0gc7MYOrMtVM1VaCVl3VgLuKMkXDTdGeiY1W+xGG1g=; b=S76V1B2IaG9/7I34u+HGCnwg/ymXFhXqoYfly6kKDW6g8iqZri6Tb3CH SWABlbviLxeKf4xCTNYnkGvq3JYGF0HenIflDHcQACubHe9UTPghoPsUd AwvC/8FFGSobwLHxkK0JljxiFArGqXqrjv8Qjfv61ErOXwjsw94AQnhA4 rEh+F6DLU3Fqt69s0JT4Lkj2gq59etBaoIovP8+rvdN8yzAP5GOQIW5j4 a2nZlbJfVPadf7JHusmjAuAtKJfMm+ds5vtO9zhjPqNKNjWmctRMkQZ4Y zlidSKIILGQn45YUP5+mhg7slK1exotCzP9OB5LMxn/QDhw8idkFIuYDS w==; X-IronPort-AV: E=McAfee;i="6200,9189,10265"; a="231625544" X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="231625544" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2022 01:53:48 -0800 X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="507924100" Received: from sjgillin-mobl.ger.corp.intel.com (HELO [10.213.218.63]) ([10.213.218.63]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2022 01:53:46 -0800 Message-ID: <647b611a-d159-3a6f-2e3a-c8039a9503ec@linux.intel.com> Date: Tue, 22 Feb 2022 09:53:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: John.C.Harrison@Intel.com, Intel-GFX@Lists.FreeDesktop.Org References: <20220218213307.1338478-1-John.C.Harrison@Intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: <20220218213307.1338478-1-John.C.Harrison@Intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH 0/3] Improve anti-pre-emption w/a for compute workloads X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DRI-Devel@Lists.FreeDesktop.Org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 18/02/2022 21:33, John.C.Harrison@Intel.com wrote: > From: John Harrison > > Compute workloads are inherently not pre-emptible on current hardware. > Thus the pre-emption timeout was disabled as a workaround to prevent > unwanted resets. Instead, the hang detection was left to the heartbeat > and its (longer) timeout. This is undesirable with GuC submission as > the heartbeat is a full GT reset rather than a per engine reset and so > is much more destructive. Instead, just bump the pre-emption timeout Can we have a feature request to allow asking GuC for an engine reset? Regards, Tvrtko > to a big value. Also, update the heartbeat to allow such a long > pre-emption delay in the final heartbeat period. > > Signed-off-by: John Harrison > > > John Harrison (3): > drm/i915/guc: Limit scheduling properties to avoid overflow > drm/i915/gt: Make the heartbeat play nice with long pre-emption > timeouts > drm/i915: Improve long running OCL w/a for GuC submission > > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 37 +++++++++++++++++-- > .../gpu/drm/i915/gt/intel_engine_heartbeat.c | 16 ++++++++ > drivers/gpu/drm/i915/gt/sysfs_engines.c | 14 +++++++ > drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 9 +++++ > 4 files changed, 73 insertions(+), 3 deletions(-) >