From: Oscar Mateo <oscar.mateo@intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Move MMCD_MISC_CTRL from context w/a to standard
Date: Wed, 4 Oct 2017 08:33:26 -0700 [thread overview]
Message-ID: <647dd6e9-7ffd-615c-362b-a9486e2275df@intel.com> (raw)
In-Reply-To: <87fuaz2hts.fsf@gaia.fi.intel.com>
On 10/04/2017 05:55 AM, Mika Kuoppala wrote:
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
>> Looking at gem_workarounds shows us that MMCD_MISC_CTRL is not restored
>> following a suspend-resume cycle. This implies that MMCD_MISC_CTRL is
>> not stored in the context, but is an ordinary register w/a that we need to
>> restore during init_hw.
>>
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>> Cc: Oscar Mateo <oscar.mateo@intel.com>
> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Oscar Mateo <oscar.mateo@intel.com>
I missed this one!
>> ---
>> drivers/gpu/drm/i915/intel_engine_cs.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
>> index a28e2a864cf1..06044f1f48c8 100644
>> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
>> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
>> @@ -980,7 +980,11 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine)
>> GEN9_PBE_COMPRESSED_HASH_SELECTION);
>> WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
>> GEN9_SAMPLER_HASH_COMPRESSED_READ_ADDR);
>> - WA_SET_BIT(MMCD_MISC_CTRL, MMCD_PCLA | MMCD_HOTSPOT_EN);
>> +
>> + I915_WRITE(MMCD_MISC_CTRL,
>> + I915_READ(MMCD_MISC_CTRL) |
>> + MMCD_PCLA |
>> + MMCD_HOTSPOT_EN);
>> }
>>
>> /* WaClearFlowControlGpgpuContextSave:skl,bxt,kbl,glk,cfl */
>> --
>> 2.14.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-04 15:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 12:41 [PATCH 1/2] drm/i915: Move MMCD_MISC_CTRL from context w/a to standard Chris Wilson
2017-10-04 12:41 ` [PATCH 2/2] drm/i915: Remove WA_(SET|CLR)_BIT Chris Wilson
2017-10-04 12:57 ` Mika Kuoppala
2017-10-04 12:55 ` [PATCH 1/2] drm/i915: Move MMCD_MISC_CTRL from context w/a to standard Mika Kuoppala
2017-10-04 15:33 ` Oscar Mateo [this message]
2017-10-04 13:06 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2017-10-04 14:16 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=647dd6e9-7ffd-615c-362b-a9486e2275df@intel.com \
--to=oscar.mateo@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox