From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH for compressed error states Date: Tue, 2 Oct 2018 14:46:10 +0100 Message-ID: <650e482e-74c0-c996-6065-a56a5ec6855d@linux.intel.com> References: <20181001194447.29910-1-chris@chris-wilson.co.uk> <20181001194447.29910-2-chris@chris-wilson.co.uk> <673d9c33-df35-d403-3e61-fbbc98047ba6@linux.intel.com> <153848307796.23109.12963662055734893298@skylake-alporthouse-com> <5b408c9d-a3da-ffa3-55b8-e2a8da856e43@linux.intel.com> <153848656029.23109.17013640697174613167@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9D97C892B7 for ; Tue, 2 Oct 2018 13:46:12 +0000 (UTC) In-Reply-To: <153848656029.23109.17013640697174613167@skylake-alporthouse-com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAyLzEwLzIwMTggMTQ6MjIsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTEwLTAyIDE0OjEzOjE0KQo+Pgo+PiBPbiAwMi8xMC8yMDE4IDEzOjI0 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBRdW90aW5nIFR2cnRrbyBVcnN1bGluICgyMDE4LTEw LTAyIDEzOjIwOjA1KQo+Pj4+Cj4+Pj4gT24gMDEvMTAvMjAxOCAyMDo0NCwgQ2hyaXMgV2lsc29u IHdyb3RlOgo+Pj4+PiBUaGUgZmluYWwgY2FsbCB0byB6bGliX2RlZmxhdGUoWl9GSU5JU0gpIG1h eSByZXF1aXJlIG1vcmUgb3V0cHV0Cj4+Pj4+IHNwYWNlIHRvIGJlIGFsbG9jYXRlZCBhbmQgc28g bmVlZHMgdG8gcmUtaW52b2tlZC4gRmFpbHVyZSB0byBkbyBzbyBpbgo+Pj4+PiB0aGUgY3VycmVu dCBjb2RlIGxlYWRzIHRvIGluY29tcGxldGUgemxpYiBzdHJlYW1zIChhbGJlaXQgaW50YWN0IGR1 ZSB0bwo+Pj4+PiB0aGUgdXNlIG9mIFpfU1lOQ19GTFVTSCkgcmVzdWx0aW5nIGluIHRoZSBvY2Nh c2lvbmFsIHNob3J0IG9iamVjdAo+Pj4+PiBjYXB0dXJlLgo+Pj4+Pgo+Pj4+PiBUZXN0Y2FzZTog aWd0L2k5MTUtZXJyb3ItY2FwdHVyZS5qcwo+Pj4+PiBGaXhlczogMGE5NzAxNWQ0NWVlICgiZHJt L2k5MTU6IENvbXByZXNzIEdQVSBvYmplY3RzIGluIGVycm9yIHN0YXRlIikKPj4+Pj4gU2lnbmVk LW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+Pj4+IENj OiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4+Pj4+ IENjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4gIyB2NC4xMCsKPj4+Pj4gLS0tCj4+Pj4+ICAg ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jIHwgNjAgKysrKysrKysrKysr KysrKysrKysrLS0tLS0tCj4+Pj4+ICAgICAxIGZpbGUgY2hhbmdlZCwgNDcgaW5zZXJ0aW9ucygr KSwgMTMgZGVsZXRpb25zKC0pCj4+Pj4+Cj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVf ZXJyb3IuYwo+Pj4+PiBpbmRleCAzZDU1NTRmMTRkZmQuLmVkOGMxNmNiZmFhNCAxMDA2NDQKPj4+ Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3IuYwo+Pj4+PiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jCj4+Pj4+IEBAIC0yMzcsNiAr MjM3LDcgQEAgc3RhdGljIGludCBjb21wcmVzc19wYWdlKHN0cnVjdCBjb21wcmVzcyAqYywKPj4+ Pj4gICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBkcm1faTkxNV9lcnJvcl9vYmplY3Qg KmRzdCkKPj4+Pj4gICAgIHsKPj4+Pj4gICAgICAgICBzdHJ1Y3Qgel9zdHJlYW1fcyAqenN0cmVh bSA9ICZjLT56c3RyZWFtOwo+Pj4+PiArICAgICBpbnQgZmx1c2ggPSBaX05PX0ZMVVNIOwo+Pj4+ PiAgICAgCj4+Pj4+ICAgICAgICAgenN0cmVhbS0+bmV4dF9pbiA9IHNyYzsKPj4+Pj4gICAgICAg ICBpZiAoYy0+dG1wICYmIGk5MTVfbWVtY3B5X2Zyb21fd2MoYy0+dG1wLCBzcmMsIFBBR0VfU0la RSkpCj4+Pj4+IEBAIC0yNTcsOCArMjU4LDExIEBAIHN0YXRpYyBpbnQgY29tcHJlc3NfcGFnZShz dHJ1Y3QgY29tcHJlc3MgKmMsCj4+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgIHpzdHJlYW0t PmF2YWlsX291dCA9IFBBR0VfU0laRTsKPj4+Pj4gICAgICAgICAgICAgICAgIH0KPj4+Pgo+Pj4+ IExvb2tzIGxpa2UgdGhlIGJsb2NrIGFib3ZlLCBub3Qgc2hvd24gaW4gdGhpcyBkaWZmLCBjb3Vs ZCB1c2UgYSBjaGVjawo+Pj4+IGFuZCBhYm9ydCBpZiB0aGUgZHN0LT5wYWdlX2NvdW50IG92ZXJn cm93cyB0aGUgcGVzc2ltaXN0aWMgYWxsb2NhdGlvbiBvZgo+Pj4+IHRoZSBhcnJheS4KPj4+Pgo+ Pj4+PiAgICAgCj4+Pj4+IC0gICAgICAgICAgICAgaWYgKHpsaWJfZGVmbGF0ZSh6c3RyZWFtLCBa X1NZTkNfRkxVU0gpICE9IFpfT0spCj4+Pj4+ICsgICAgICAgICAgICAgaWYgKHpsaWJfZGVmbGF0 ZSh6c3RyZWFtLCBmbHVzaCkgIT0gWl9PSykKPj4+Pgo+Pj4+IFNvIHRoaXMgKG5vdCBhbHdheXMg YXNraW5nIGZvciBhIGZsdXNoKSBhY3R1YWxseSBub3Qgb25seSBmaXhlcyB0aGUKPj4+PiBmbHVz aCBhdCB0aGUgZW5kIGJ1dCBpbXByb3ZlcyB0aGUgQVBJIHVzYWdlIGFuZCBwb3RlbnRpYWxseSBj b21wcmVzc2lvbgo+Pj4+IHJhdGlvLCBjb3JyZWN0Pwo+Pj4KPj4+IFllcy4KPj4+ICAgIAo+Pj4+ PiAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gLUVJTzsKPj4+Pj4gKwo+Pj4+PiArICAg ICAgICAgICAgIGlmICh6c3RyZWFtLT5hdmFpbF9vdXQpCj4+Pj4+ICsgICAgICAgICAgICAgICAg ICAgICBmbHVzaCA9IFpfU1lOQ19GTFVTSDsKPj4+Pgo+Pj4+IEhtLi4gYnV0IHdoeSB0aGlzPyBJ dCB3aWxsIGZsdXNoIG9ubHkgb2NjYXNpb25hbGx5LCB3aGVuIG9uZSBpbnB1dCBwYWdlCj4+Pj4g ZGlkIG5vdCBmaXQgaW4gdGhlIGF2YWlsYWJsZSBvdXRwdXQgLSBidXQgdGhhdCB3aWxsIGRlcGVu ZCBvbgo+Pj4+IGNvbXByZXNzaWJpbGl0eSBzbyBJIGRvbid0IHRoaW5rIGl0IGhhcyBhIGZpeGVk IHBlcmlvZC4gSXQgaXMgbm90IGZvcgo+Pj4+IGluc3RhbmNlIGZvciBldmVyeSA0ayBvZiBjb21w cmVzc2VkIG91dHB1dCwgaWYgdGhhdCB3YXMgbWF5YmUgdGhlIGdvYWwuCj4+Pgo+Pj4gTXkgdGhp bmtpbmcgaXMgdGhhdCBpZiB0aGUgemxpYl9kZWZsYXRlKCkgd2FudHMgdG8gZGVmZXIgdG8gZmls bCBpdHMKPj4+IHdpbmRvdyAob3Igd2hhdGV2ZXIpIGJ1dCB3ZSBuZWVkIHRvIGNyb3NzIGEgcGFn ZSBib3VuZGFyeSwgd2UgaGF2ZSB0bwo+Pj4gcHVzaCBldmVyeXRoaW5nIGZyb20gdGhlIGN1cnJl bnQgcGFnZSBiZWZvcmUgd2UgY2hhbmdlIHRoZSBQVEUuCj4+Cj4+IEhtIGJ1dCBJIGFtIG5vdCBz dXJlIHRoaXMgaXMgYWNoaWV2aW5nIHRoYXQsIG9yIHRoYXQgaXQgaXMgbmVlZGVkLiBJCj4+IHJl YWQgdGhlIGRvY3MgbWFueSB0aW1lcyBhbmQgSSBhbSBub3Qgc3VyZSBob3cgaXQgaXMgc3VwcG9z ZWQgdG8gd29yay4KPj4KPj4gRmlyc3QgdGhpbmcgSSBhbSBub3Qgc3VyZSBvZiBpcyB3aGV0aGVy IHdlIG5lZWQgdG8gYXNrIGZvciBhbnkgZmx1c2hlcywKPj4gb3IgaXQgd291bGQgYmUgZW5vdWdo IHRvIGxvb3AgdW50aWwgYXZhaWxfaW4gPiAwIHx8IGF2YWlsX291dCA9PSAwLgo+PiBTaW5jZSBk b2NzIHNheSB0aGF0IGlmIGF2YWlsX291dCA9PSAwLCB6bGliX2RlZmxhdGUgbmVlZHMgdG8gYmUg Y2FsbGVkCj4+IGFnYWluIGluIHRoZSBzYW1lIGZsdXNoIG1vZGUuCj4gCj4gSWlyYywgWl9TWU5D X0ZMVVNIIHRhbGtzIGFib3V0IHRlcm1pbmF0aW5nIHRoZSBjb21wcmVzc2lvbiBibG9jayBlYXJs aWVyCj4gaW4gb3JkZXIgdG8gY29uc3VtZSBuZXh0X2F2YWlsLCB3aXRob3V0IHRoZSBTWU5DIHJl cGVhdGluZyBhIGNhbGwgaXMKPiBhbGxvd2VkIHRvIG5vdCBwcm9ncmVzcy4KPiAKPj4gQ3VycmVu dCBjb2RlIGZhaWxzIHRvIGVuc3VyZSB0aGlzLiBJdCB3b3VsZCBoYXBwZW4gb24gdGhlIG5leHQg Y2FsbCB0bwo+PiBjb21wcmVzc19wYWdlLCBidXQgYSkgSSB0aGluayB0aGF0IGlzIHVuY2xlYW4g YW5kIGIpIGZsdXNoIG1vZGUgd2lsbCBub3QKPj4gbWF0Y2guCj4gCj4gRmFpbHMgdG8gZW5zdXJl IHdoYXQgZXhhY3RseT8gSSB0aGluayBpdCBpcyBvYmV5aW5nIHRoZSBydWxlcyBvbiBmbHVzaDoK PiAKPiAgICBJZiB0aGUgcGFyYW1ldGVyIGZsdXNoIGlzIHNldCB0byBaX1NZTkNfRkxVU0gsIGFs bCBwZW5kaW5nIG91dHB1dCBpcwo+ICAgIGZsdXNoZWQgdG8gdGhlIG91dHB1dCBidWZmZXIgYW5k IHRoZSBvdXRwdXQgaXMgYWxpZ25lZCBvbiBhIGJ5dGUgYm91bmRhcnksIHNvCj4gICAgdGhhdCB0 aGUgZGVjb21wcmVzc29yIGNhbiBnZXQgYWxsIGlucHV0IGRhdGEgYXZhaWxhYmxlIHNvIGZhci4g KEluIHBhcnRpY3VsYXIKPiAgICBhdmFpbF9pbiBpcyB6ZXJvIGFmdGVyIHRoZSBjYWxsIGlmIGVu b3VnaCBvdXRwdXQgc3BhY2UgaGFzIGJlZW4gcHJvdmlkZWQKPiAgICBiZWZvcmUgdGhlIGNhbGwu KSAgRmx1c2hpbmcgbWF5IGRlZ3JhZGUgY29tcHJlc3Npb24gZm9yIHNvbWUgY29tcHJlc3Npb24K PiAgICBhbGdvcml0aG1zIGFuZCBzbyBpdCBzaG91bGQgYmUgdXNlZCBvbmx5IHdoZW4gbmVjZXNz YXJ5LgoKSSBhbSBub3Qgc3VyZSB3ZSBuZWVkIHRvIGZsdXNoIC0gSSBkb24ndCBzZWUgdGhhdCBp dCBzYXlzIGluIHRoZSBkb2NzIAp0aGF0IHdlIGhhdmUgdG8uIEFGQUlVIHdoZW4gYXZhaWxfaW4g ZHJvcHMgdG8gemVybyB3ZSBhcmUgYWxsb3dlZCB0byAKbW92ZSBvbi4gQW55dGhpbmcgb3V0c3Rh bmRpbmcgaW4gdGhlIGNvbXByZXNzb3Igd291bGQgYmUgdGhlbiBmbHVzaGVkIAplaXRoZXIgb24g cHJvY2Vzc2luZyB0aGUgbmV4dCBwYWdlLCBvciBvbiBzdHJlYW0gY2xvc2UuCgo+ICAgIC4uLgo+ IAo+ICAgIElmIGRlZmxhdGUgcmV0dXJucyB3aXRoIGF2YWlsX291dCA9PSAwLCB0aGlzIGZ1bmN0 aW9uIG11c3QgYmUgY2FsbGVkIGFnYWluCj4gICAgd2l0aCB0aGUgc2FtZSB2YWx1ZSBvZiB0aGUg Zmx1c2ggcGFyYW1ldGVyIGFuZCBtb3JlIG91dHB1dCBzcGFjZSAodXBkYXRlZAo+ICAgIGF2YWls X291dCksIHVudGlsIHRoZSBmbHVzaCBpcyBjb21wbGV0ZSAoZGVmbGF0ZSByZXR1cm5zIHdpdGgg bm9uLXplcm8KPiAgICBhdmFpbF9vdXQpLgoKWWVzLCBidXQgdGhlIHBhdGNoIGRvZXMgbm90IGRv IHRoYXQuIFlvdSBlbmFibGUgdGhlIGZsdXNoIG1vZGUgd2hlbiAKYXZhaWxfb3V0IGlzIG5vbiB6 ZXJvLCBidXQgdGhlbiB0d28gb3B0aW9ucyBhcmUgcG9zc2libGUuIEVpdGhlciAKYXZhaWxfaW4g aXMgemVybywgaW4gd2hpY2ggY2FzZSBub3RoaW5nIGhhcHBlbnMsIG9yIGl0IGlzIG5vdC4gSW4g dGhlIApsYXR0ZXIgY2FzZSB0aGVyZSBpcyBhbm90aGVyIGZsdXNoaW5nIGNhbGwgdG8gemxpYl9k ZWZsYXRlLiBJZiBhdmFpbF9vdXQgCmlzIHplcm8gYWZ0ZXIgdGhhdCBjYWxsLCBhbmQgYXZhaWxf aW4gaXMgYWxzbyB6ZXJvLCB0aGUgZG9jdW1lbnRhdGlvbiAKcGFyYWdyYXBoIGFib3ZlIHNheXMg eW91IGhhdmUgdG8gY2FsbCB6bGliX2RlZmxhdGUgaW4gdGhlIHNhbWUgZmx1c2ggCm1vZGUgYWdh aW4uCgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=