From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 3/7] drm/rcar-du: Use new iterator macros, v2. Date: Sat, 29 Jul 2017 23:57:40 +0300 Message-ID: <6593849.SxFAOB4sYE@avalon> References: <20170719143920.25685-1-maarten.lankhorst@linux.intel.com> <20170719143920.25685-4-maarten.lankhorst@linux.intel.com> <1518645.4VQmJDGaiE@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1518645.4VQmJDGaiE@avalon> Sender: linux-renesas-soc-owner@vger.kernel.org To: dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst , linux-renesas-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Hi Maarten, On Wednesday 26 Jul 2017 14:53:33 Laurent Pinchart wrote: > On Wednesday 19 Jul 2017 16:39:16 Maarten Lankhorst wrote: > > for_each_obj_in_state is about to be removed, so use the correct new > > iterator macros. > > > > Also look at new_plane_state instead of plane->state when looking up > > the hw planes in use. They should be the same except when reallocating, > > (in which case this code is skipped) and we should really stop looking > > at obj->state whenever possible. > > > > Changes since v1: > > - Actually compile correctly. > > > > Signed-off-by: Maarten Lankhorst > > Cc: Laurent Pinchart > > Cc: linux-renesas-soc@vger.kernel.org I plan to send a pull request to Dave in the middle of next week with a bunch of rcar-du-drm patches that will generate a few conflicts with this one. They're all simple to solve as they're located in comments, but that will be annoying nonetheless. I can include a rebased version of this patch in my pull request if it can help, depending on when you plan to get this series merged in drm-misc-next. -- Regards, Laurent Pinchart