Re: [PATCH v2 09/13] drm/i915/uc: Improve debug messages in firmware fetch

Chris Wilson
2017-10-12T19:51:48Z

Quoting Michal Wajdeczko (2017-10-12 20:16:23)
> Time to remove less important info and make messages clear
> and consistent.
>
> v2: change some message levels (Chris)
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>

I'm much happier with the WARN followed by a NOTE, The battle for
dev_warn, I'll fight another day.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Could we have another FIRMWARE_URL message here to direct the user to
replace their fw?
-Chris