Re: [Intel-gfx] [PATCH] drm/i915/selftest: Extend ctx_timestamp ICL workaround to GEN11

Tvrtko Ursulin
2021-06-24T09:49:02Z

On 23/06/2021 08:21, Tejas Upadhyay wrote:
> EHL and JSL are also observing requirement for 80ns interval for
> CTX_TIMESTAMP thus extending it to GEN11.

If testing confirms this:

Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

You only may need to change that INTEL_GEN to GRAPHICS_VER since I think
that's the new thing now.

Regards,

Tvrtko

> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> ---
> drivers/gpu/drm/i915/gt/selftest_engine_pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_engine_pm.c b/drivers/gpu/drm/i915/gt/selftest_engine_pm.c
> index 72cca3f0da21..d0afadf34649 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_engine_pm.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_engine_pm.c
> @@ -173,8 +173,8 @@ static int __live_engine_timestamps(struct intel_engine_cs *engine)
> d_ctx = trifilter(s_ctx);
>
> d_ctx *= engine->gt->clock_frequency;
> - if (IS_ICELAKE(engine->i915))
> - d_ring *= 12500000; /* Fixed 80ns for icl ctx timestamp? */
> + if (IS_GEN(engine->i915, 11))
> + d_ring *= 12500000; /* Fixed 80ns for GEN11 ctx timestamp? */
> else
> d_ring *= engine->gt->clock_frequency;
>
>