From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 1/2] drm/i915: Move uncore selfchecks to late selftest infrastructure Date: Thu, 8 Dec 2016 11:58:41 +0000 Message-ID: <67301ccb-6b15-1bd6-900b-fa3dd131f96b@linux.intel.com> References: <20161207135833.32740-1-chris@chris-wilson.co.uk> <20161207185201.10386-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6FA616E745 for ; Thu, 8 Dec 2016 11:58:44 +0000 (UTC) In-Reply-To: <20161207185201.10386-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA3LzEyLzIwMTYgMTg6NTIsIENocmlzIFdpbHNvbiB3cm90ZToKPiBOb3cgdGhhdCB0aGUg a3NlbGZ0ZXN0IGluZnJhc3RydWN0dXJlIGV4aXN0cywgcHV0IGl0IHRvIHVzZSBhbmQgYWRkIHRv Cj4gaXQgdGhlIGV4aXN0aW5nIGNvbnNpc3RlbmN5IGNoZWNrcyBvbiB0aGUgZncgcmVnaXN0ZXIg bG9va3VwIHRhYmxlcy4KPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hy aXMtd2lsc29uLmNvLnVrPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50 ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2xhdGVfc2VsZnRlc3Rz LmggfCAgIDEgKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYyAgICAgICAg fCAxMTYgKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCA2 OSBpbnNlcnRpb25zKCspLCA0OCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2xhdGVfc2VsZnRlc3RzLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2xhdGVfc2VsZnRlc3RzLmgKPiBpbmRleCBlNjY0NWQwOGQ5NjQuLjI4OWE2NTFkYjJm ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2xhdGVfc2VsZnRlc3Rz LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2xhdGVfc2VsZnRlc3RzLmgKPiBA QCAtOCw0ICs4LDUgQEAKPiAgICoKPiAgICogVGVzdHMgYXJlIGV4ZWN1dGVkIGluIHJldmVyc2Ug b3JkZXIgYnkgaWd0L2Rydl9zZWxmdGVzdAo+ICAgKi8KPiArc2VsZnRlc3QodW5jb3JlLCBpbnRl bF91bmNvcmVfbGF0ZV9zZWxmdGVzdHMpCj4gIHNlbGZ0ZXN0KHNhbml0eWNoZWNrLCBpOTE1X2xh dGVfc2FuaXR5Y2hlY2spIC8qIGtlZXAgbGFzdCAqLwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Vu Y29yZS5jCj4gaW5kZXggYzFjYTRkZjM4ZGVhLi5iZDg0MzZiOGYzYTQgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF91bmNvcmUuYwo+IEBAIC02MjgsMzMgKzYyOCw2IEBAIGZpbmRfZndfZG9t YWluKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdTMyIG9mZnNldCkKPiAgCXJl dHVybiBlbnRyeSA/IGVudHJ5LT5kb21haW5zIDogMDsKPiAgfQo+Cj4gLXN0YXRpYyB2b2lkCj4g LWludGVsX2Z3X3RhYmxlX2NoZWNrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikK PiAtewo+IC0JY29uc3Qgc3RydWN0IGludGVsX2ZvcmNld2FrZV9yYW5nZSAqcmFuZ2VzOwo+IC0J dW5zaWduZWQgaW50IG51bV9yYW5nZXM7Cj4gLQlzMzIgcHJldjsKPiAtCXVuc2lnbmVkIGludCBp Owo+IC0KPiAtCWlmICghSVNfRU5BQkxFRChDT05GSUdfRFJNX0k5MTVfREVCVUcpKQo+IC0JCXJl dHVybjsKPiAtCj4gLQlyYW5nZXMgPSBkZXZfcHJpdi0+dW5jb3JlLmZ3X2RvbWFpbnNfdGFibGU7 Cj4gLQlpZiAoIXJhbmdlcykKPiAtCQlyZXR1cm47Cj4gLQo+IC0JbnVtX3JhbmdlcyA9IGRldl9w cml2LT51bmNvcmUuZndfZG9tYWluc190YWJsZV9lbnRyaWVzOwo+IC0KPiAtCWZvciAoaSA9IDAs IHByZXYgPSAtMTsgaSA8IG51bV9yYW5nZXM7IGkrKywgcmFuZ2VzKyspIHsKPiAtCQlXQVJOX09O X09OQ0UoSVNfR0VOOShkZXZfcHJpdikgJiYKPiAtCQkJICAgICAocHJldiArIDEpICE9IChzMzIp cmFuZ2VzLT5zdGFydCk7Cj4gLQkJV0FSTl9PTl9PTkNFKHByZXYgPj0gKHMzMilyYW5nZXMtPnN0 YXJ0KTsKPiAtCQlwcmV2ID0gcmFuZ2VzLT5zdGFydDsKPiAtCQlXQVJOX09OX09OQ0UocHJldiA+ PSAoczMyKXJhbmdlcy0+ZW5kKTsKPiAtCQlwcmV2ID0gcmFuZ2VzLT5lbmQ7Cj4gLQl9Cj4gLX0K PiAtCj4gICNkZWZpbmUgR0VOX0ZXX1JBTkdFKHMsIGUsIGQpIFwKPiAgCXsgLnN0YXJ0ID0gKHMp LCAuZW5kID0gKGUpLCAuZG9tYWlucyA9IChkKSB9Cj4KPiBAQCAtNjkzLDIzICs2NjYsNiBAQCBz dGF0aWMgY29uc3QgaTkxNV9yZWdfdCBnZW44X3NoYWRvd2VkX3JlZ3NbXSA9IHsKPiAgCS8qIFRP RE86IE90aGVyIHJlZ2lzdGVycyBhcmUgbm90IHlldCB1c2VkICovCj4gIH07Cj4KPiAtc3RhdGlj IHZvaWQgaW50ZWxfc2hhZG93X3RhYmxlX2NoZWNrKHZvaWQpCj4gLXsKPiAtCWNvbnN0IGk5MTVf cmVnX3QgKnJlZyA9IGdlbjhfc2hhZG93ZWRfcmVnczsKPiAtCXMzMiBwcmV2Owo+IC0JdTMyIG9m ZnNldDsKPiAtCXVuc2lnbmVkIGludCBpOwo+IC0KPiAtCWlmICghSVNfRU5BQkxFRChDT05GSUdf RFJNX0k5MTVfREVCVUcpKQo+IC0JCXJldHVybjsKPiAtCj4gLQlmb3IgKGkgPSAwLCBwcmV2ID0g LTE7IGkgPCBBUlJBWV9TSVpFKGdlbjhfc2hhZG93ZWRfcmVncyk7IGkrKywgcmVnKyspIHsKPiAt CQlvZmZzZXQgPSBpOTE1X21taW9fcmVnX29mZnNldCgqcmVnKTsKPiAtCQlXQVJOX09OX09OQ0Uo cHJldiA+PSAoczMyKW9mZnNldCk7Cj4gLQkJcHJldiA9IG9mZnNldDsKPiAtCX0KPiAtfQo+IC0K PiAgc3RhdGljIGludCBtbWlvX3JlZ19jbXAodTMyIGtleSwgY29uc3QgaTkxNV9yZWdfdCAqcmVn KQo+ICB7Cj4gIAl1MzIgb2Zmc2V0ID0gaTkxNV9tbWlvX3JlZ19vZmZzZXQoKnJlZyk7Cj4gQEAg LTE0MzYsMTAgKzEzOTIsNiBAQCB2b2lkIGludGVsX3VuY29yZV9pbml0KHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiAgCQlicmVhazsKPiAgCX0KPgo+IC0JaW50ZWxfZndfdGFi bGVfY2hlY2soZGV2X3ByaXYpOwo+IC0JaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gOCkKPiAt CQlpbnRlbF9zaGFkb3dfdGFibGVfY2hlY2soKTsKPiAtCj4gIAlpZiAoaW50ZWxfdmdwdV9hY3Rp dmUoZGV2X3ByaXYpKSB7Cj4gIAkJQVNTSUdOX1dSSVRFX01NSU9fVkZVTkNTKHZncHUpOwo+ICAJ CUFTU0lHTl9SRUFEX01NSU9fVkZVTkNTKHZncHUpOwo+IEBAIC0xOTYyLDMgKzE5MTQsNzEgQEAg aW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9mb3JfcmVnKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiwKPgo+ICAJcmV0dXJuIGZ3X2RvbWFpbnM7Cj4gIH0KPiArCj4gKyNpZiBJU19FTkFC TEVEKENPTkZJR19EUk1fSTkxNV9TRUxGVEVTVCkKPiArI2luY2x1ZGUgImk5MTVfc2VsZnRlc3Qu aCIKPiArCj4gK3N0YXRpYyBpbnQgaW50ZWxfZndfdGFibGVfY2hlY2soc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmk5MTUpCj4gK3sKPiArCWNvbnN0IHN0cnVjdCBpbnRlbF9mb3JjZXdha2VfcmFu Z2UgKnJhbmdlczsKPiArCXVuc2lnbmVkIGludCBudW1fcmFuZ2VzLCBpOwo+ICsJczMyIHByZXY7 Cj4gKwo+ICsJcmFuZ2VzID0gaTkxNS0+dW5jb3JlLmZ3X2RvbWFpbnNfdGFibGU7Cj4gKwlpZiAo IXJhbmdlcykKPiArCQlyZXR1cm4gMDsKPiArCj4gKwludW1fcmFuZ2VzID0gaTkxNS0+dW5jb3Jl LmZ3X2RvbWFpbnNfdGFibGVfZW50cmllczsKPiArCWZvciAoaSA9IDAsIHByZXYgPSAtMTsgaSA8 IG51bV9yYW5nZXM7IGkrKywgcmFuZ2VzKyspIHsKPiArCQkvKiBDaGVjayB0aGF0IHRoZSB0YWJr ZSBpcyB3YXRlcnRpZ2h0ICovCgp0YWJsZQoKPiArCQlpZiAoV0FSTl9PTihJU19HRU45KGk5MTUp ICYmIChwcmV2ICsgMSkgIT0gKHMzMilyYW5nZXMtPnN0YXJ0KSkKPiArCQkJcmV0dXJuIC1FSU5W QUw7Cj4gKwo+ICsJCS8qIENoZWNrIHRoYXQgdGhlIHRhYmxlIG5ldmVyIGdvZXMgYmFja3dhcmRz ICovCj4gKwkJaWYgKFdBUk5fT04ocHJldiA+PSAoczMyKXJhbmdlcy0+c3RhcnQpKQo+ICsJCQly ZXR1cm4gLUVJTlZBTDsKPiArCj4gKwkJLyogQ2hlY2sgdGhhdCB0aGUgZW50cnkgaXMgdmFsaWQg Ki8KPiArCQlpZiAoV0FSTl9PTihyYW5nZXMtPnN0YXJ0ID49IChzMzIpcmFuZ2VzLT5lbmQpKQoK Q29tcGFyaXNvbiBiZXR3ZWVuIHNpZ25lZCBhbmQgdW5zaWduZWQ/Cgo+ICsJCQlyZXR1cm4gLUVJ TlZBTDsKPiArCj4gKwkJcHJldiA9IHJhbmdlcy0+ZW5kOwo+ICsJfQo+ICsKPiArCXJldHVybiAw Owo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IGludGVsX3NoYWRvd190YWJsZV9jaGVjayh2b2lkKQo+ ICt7Cj4gKwljb25zdCBpOTE1X3JlZ190ICpyZWcgPSBnZW44X3NoYWRvd2VkX3JlZ3M7Cj4gKwl1 bnNpZ25lZCBpbnQgaTsKPiArCXMzMiBwcmV2Owo+ICsKPiArCWZvciAoaSA9IDAsIHByZXYgPSAt MTsgaSA8IEFSUkFZX1NJWkUoZ2VuOF9zaGFkb3dlZF9yZWdzKTsgaSsrLCByZWcrKykgewo+ICsJ CXUzMiBvZmZzZXQgPSBpOTE1X21taW9fcmVnX29mZnNldCgqcmVnKTsKPiArCQlpZiAoV0FSTl9P TihwcmV2ID49IChzMzIpb2Zmc2V0KSkKPiArCQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwo+ICsJCXBy ZXYgPSBvZmZzZXQ7Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK2ludCBpbnRl bF91bmNvcmVfbGF0ZV9zZWxmdGVzdHMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4g K3sKPiArCWludCBlcnI7Cj4gKwo+ICsJZXJyID0gaW50ZWxfZndfdGFibGVfY2hlY2soaTkxNSk7 Cj4gKwlpZiAoZXJyKQo+ICsJCXJldHVybiBlcnI7Cj4gKwo+ICsJaWYgKElOVEVMX0dFTihpOTE1 KSA+PSA4KSB7CgpDb3VsZCBqdXN0IGFsd2F5cyBjaGVjayBpdCwgdGhlIGZ3IHRhYmxlIGlzIGlk ZW50aWNhbGx5IHVudXNlZCBvbiBzb21lIApwbGF0Zm9ybXMuCgo+ICsJCWVyciA9IGludGVsX3No YWRvd190YWJsZV9jaGVjaygpOwo+ICsJCWlmIChlcnIpCj4gKwkJCXJldHVybiBlcnI7Cj4gKwl9 Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArI2VuZGlmCj4KClJlZ2FyZHMsCgpUdnJ0a28KX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==