From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH
 for compressed error states
Date: Tue, 2 Oct 2018 13:20:05 +0100
Message-ID: <673d9c33-df35-d403-3e61-fbbc98047ba6@linux.intel.com>
References: <20181001194447.29910-1-chris@chris-wilson.co.uk>
 <20181001194447.29910-2-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 415D289D00
 for <intel-gfx@lists.freedesktop.org>; Tue,  2 Oct 2018 12:20:08 +0000 (UTC)
In-Reply-To: <20181001194447.29910-2-chris@chris-wilson.co.uk>
Content-Language: en-GB
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDAxLzEwLzIwMTggMjA6NDQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBUaGUgZmluYWwgY2Fs
bCB0byB6bGliX2RlZmxhdGUoWl9GSU5JU0gpIG1heSByZXF1aXJlIG1vcmUgb3V0cHV0Cj4gc3Bh
Y2UgdG8gYmUgYWxsb2NhdGVkIGFuZCBzbyBuZWVkcyB0byByZS1pbnZva2VkLiBGYWlsdXJlIHRv
IGRvIHNvIGluCj4gdGhlIGN1cnJlbnQgY29kZSBsZWFkcyB0byBpbmNvbXBsZXRlIHpsaWIgc3Ry
ZWFtcyAoYWxiZWl0IGludGFjdCBkdWUgdG8KPiB0aGUgdXNlIG9mIFpfU1lOQ19GTFVTSCkgcmVz
dWx0aW5nIGluIHRoZSBvY2Nhc2lvbmFsIHNob3J0IG9iamVjdAo+IGNhcHR1cmUuCj4gCj4gVGVz
dGNhc2U6IGlndC9pOTE1LWVycm9yLWNhcHR1cmUuanMKPiBGaXhlczogMGE5NzAxNWQ0NWVlICgi
ZHJtL2k5MTU6IENvbXByZXNzIEdQVSBvYmplY3RzIGluIGVycm9yIHN0YXRlIikKPiBTaWduZWQt
b2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogSm9v
bmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+IENjOiA8c3Rh
YmxlQHZnZXIua2VybmVsLm9yZz4gIyB2NC4xMCsKPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9p
OTE1L2k5MTVfZ3B1X2Vycm9yLmMgfCA2MCArKysrKysrKysrKysrKysrKysrKystLS0tLS0KPiAg
IDEgZmlsZSBjaGFuZ2VkLCA0NyBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkKPiAKPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3IuYyBiL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vycm9yLmMKPiBpbmRleCAzZDU1NTRmMTRkZmQuLmVk
OGMxNmNiZmFhNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9l
cnJvci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3IuYwo+IEBA
IC0yMzcsNiArMjM3LDcgQEAgc3RhdGljIGludCBjb21wcmVzc19wYWdlKHN0cnVjdCBjb21wcmVz
cyAqYywKPiAgIAkJCSBzdHJ1Y3QgZHJtX2k5MTVfZXJyb3Jfb2JqZWN0ICpkc3QpCj4gICB7Cj4g
ICAJc3RydWN0IHpfc3RyZWFtX3MgKnpzdHJlYW0gPSAmYy0+enN0cmVhbTsKPiArCWludCBmbHVz
aCA9IFpfTk9fRkxVU0g7Cj4gICAKPiAgIAl6c3RyZWFtLT5uZXh0X2luID0gc3JjOwo+ICAgCWlm
IChjLT50bXAgJiYgaTkxNV9tZW1jcHlfZnJvbV93YyhjLT50bXAsIHNyYywgUEFHRV9TSVpFKSkK
PiBAQCAtMjU3LDggKzI1OCwxMSBAQCBzdGF0aWMgaW50IGNvbXByZXNzX3BhZ2Uoc3RydWN0IGNv
bXByZXNzICpjLAo+ICAgCQkJenN0cmVhbS0+YXZhaWxfb3V0ID0gUEFHRV9TSVpFOwo+ICAgCQl9
CgpMb29rcyBsaWtlIHRoZSBibG9jayBhYm92ZSwgbm90IHNob3duIGluIHRoaXMgZGlmZiwgY291
bGQgdXNlIGEgY2hlY2sgCmFuZCBhYm9ydCBpZiB0aGUgZHN0LT5wYWdlX2NvdW50IG92ZXJncm93
cyB0aGUgcGVzc2ltaXN0aWMgYWxsb2NhdGlvbiBvZiAKdGhlIGFycmF5LgoKPiAgIAo+IC0JCWlm
ICh6bGliX2RlZmxhdGUoenN0cmVhbSwgWl9TWU5DX0ZMVVNIKSAhPSBaX09LKQo+ICsJCWlmICh6
bGliX2RlZmxhdGUoenN0cmVhbSwgZmx1c2gpICE9IFpfT0spCgpTbyB0aGlzIChub3QgYWx3YXlz
IGFza2luZyBmb3IgYSBmbHVzaCkgYWN0dWFsbHkgbm90IG9ubHkgZml4ZXMgdGhlIApmbHVzaCBh
dCB0aGUgZW5kIGJ1dCBpbXByb3ZlcyB0aGUgQVBJIHVzYWdlIGFuZCBwb3RlbnRpYWxseSBjb21w
cmVzc2lvbiAKcmF0aW8sIGNvcnJlY3Q/Cgo+ICAgCQkJcmV0dXJuIC1FSU87Cj4gKwo+ICsJCWlm
ICh6c3RyZWFtLT5hdmFpbF9vdXQpCj4gKwkJCWZsdXNoID0gWl9TWU5DX0ZMVVNIOwoKSG0uLiBi
dXQgd2h5IHRoaXM/IEl0IHdpbGwgZmx1c2ggb25seSBvY2Nhc2lvbmFsbHksIHdoZW4gb25lIGlu
cHV0IHBhZ2UgCmRpZCBub3QgZml0IGluIHRoZSBhdmFpbGFibGUgb3V0cHV0IC0gYnV0IHRoYXQg
d2lsbCBkZXBlbmQgb24gCmNvbXByZXNzaWJpbGl0eSBzbyBJIGRvbid0IHRoaW5rIGl0IGhhcyBh
IGZpeGVkIHBlcmlvZC4gSXQgaXMgbm90IGZvciAKaW5zdGFuY2UgZm9yIGV2ZXJ5IDRrIG9mIGNv
bXByZXNzZWQgb3V0cHV0LCBpZiB0aGF0IHdhcyBtYXliZSB0aGUgZ29hbC4KCj4gICAJfSB3aGls
ZSAoenN0cmVhbS0+YXZhaWxfaW4pOwo+ICAgCj4gICAJLyogRmFsbGJhY2sgdG8gdW5jb21wcmVz
c2VkIGlmIHdlIGluY3JlYXNlIHNpemU/ICovCj4gQEAgLTI2OCwxOSArMjcyLDQzIEBAIHN0YXRp
YyBpbnQgY29tcHJlc3NfcGFnZShzdHJ1Y3QgY29tcHJlc3MgKmMsCj4gICAJcmV0dXJuIDA7Cj4g
ICB9Cj4gICAKPiAtc3RhdGljIHZvaWQgY29tcHJlc3NfZmluaShzdHJ1Y3QgY29tcHJlc3MgKmMs
Cj4gK3N0YXRpYyBpbnQgY29tcHJlc3NfZmx1c2goc3RydWN0IGNvbXByZXNzICpjLAo+ICAgCQkJ
ICBzdHJ1Y3QgZHJtX2k5MTVfZXJyb3Jfb2JqZWN0ICpkc3QpCj4gICB7Cj4gICAJc3RydWN0IHpf
c3RyZWFtX3MgKnpzdHJlYW0gPSAmYy0+enN0cmVhbTsKPiArCXVuc2lnbmVkIGxvbmcgcGFnZTsK
PiAgIAo+IC0JaWYgKGRzdCkgewo+IC0JCXpsaWJfZGVmbGF0ZSh6c3RyZWFtLCBaX0ZJTklTSCk7
Cj4gLQkJZHN0LT51bnVzZWQgPSB6c3RyZWFtLT5hdmFpbF9vdXQ7Cj4gLQl9Cj4gKwlkbyB7Cj4g
KwkJc3dpdGNoICh6bGliX2RlZmxhdGUoenN0cmVhbSwgWl9GSU5JU0gpKSB7Cj4gKwkJY2FzZSBa
X09LOiAvKiBtb3JlIHNwYWNlIHJlcXVlc3RlZCAqLwo+ICsJCQlwYWdlID0gX19nZXRfZnJlZV9w
YWdlKEdGUF9BVE9NSUMgfCBfX0dGUF9OT1dBUk4pOwo+ICsJCQlpZiAoIXBhZ2UpCj4gKwkJCQly
ZXR1cm4gLUVOT01FTTsKPiArCj4gKwkJCWRzdC0+cGFnZXNbZHN0LT5wYWdlX2NvdW50KytdID0g
KHZvaWQgKilwYWdlOwoKSSdkIHB1dCBpbiBhIGNoZWNrIGZvciBwYWdlcyBhcnJheSBleGhhdXN0
aW9uIGhlcmUgYXMgd2VsbC4gT3IgZXZlbiAKYmV0dGVyLCBjb21wcmVzc19wYWdlIGFuZCBjb21w
cmVzc19mbHVzaCBjb3VsZCBzaGFyZSB0aGlzIHdob2xlIGJsb2NrLgoKPiArCQkJenN0cmVhbS0+
bmV4dF9vdXQgPSAodm9pZCAqKXBhZ2U7Cj4gKwkJCXpzdHJlYW0tPmF2YWlsX291dCA9IFBBR0Vf
U0laRTsKPiArCQkJYnJlYWs7Cj4gKwkJY2FzZSBaX1NUUkVBTV9FTkQ6Cj4gKwkJCWdvdG8gZW5k
Owo+ICsJCWRlZmF1bHQ6IC8qIGFueSBlcnJvciAqLwo+ICsJCQlyZXR1cm4gLUVJTzsKPiArCQl9
Cj4gKwl9IHdoaWxlICgxKTsKPiArCj4gK2VuZDoKPiArCW1lbXNldCh6c3RyZWFtLT5uZXh0X291
dCwgMCwgenN0cmVhbS0+YXZhaWxfb3V0KTsKPiArCWRzdC0+dW51c2VkID0genN0cmVhbS0+YXZh
aWxfb3V0Owo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIGNvbXByZXNzX2Zp
bmkoc3RydWN0IGNvbXByZXNzICpjLAo+ICsJCQkgIHN0cnVjdCBkcm1faTkxNV9lcnJvcl9vYmpl
Y3QgKmRzdCkKPiArewo+ICsJc3RydWN0IHpfc3RyZWFtX3MgKnpzdHJlYW0gPSAmYy0+enN0cmVh
bTsKPiAgIAo+ICAgCXpsaWJfZGVmbGF0ZUVuZCh6c3RyZWFtKTsKPiAgIAlrZnJlZSh6c3RyZWFt
LT53b3Jrc3BhY2UpOwo+IC0KPiAgIAlpZiAoYy0+dG1wKQo+ICAgCQlmcmVlX3BhZ2UoKHVuc2ln
bmVkIGxvbmcpYy0+dG1wKTsKPiAgIH0KPiBAQCAtMzE5LDYgKzM0NywxMiBAQCBzdGF0aWMgaW50
IGNvbXByZXNzX3BhZ2Uoc3RydWN0IGNvbXByZXNzICpjLAo+ICAgCXJldHVybiAwOwo+ICAgfQo+
ICAgCj4gK3N0YXRpYyBpbnQgY29tcHJlc3NfZmx1c2goc3RydWN0IGNvbXByZXNzICpjLAo+ICsJ
CQkgIHN0cnVjdCBkcm1faTkxNV9lcnJvcl9vYmplY3QgKmRzdCkKPiArewo+ICsJcmV0dXJuIDA7
Cj4gK30KPiArCj4gICBzdGF0aWMgdm9pZCBjb21wcmVzc19maW5pKHN0cnVjdCBjb21wcmVzcyAq
YywKPiAgIAkJCSAgc3RydWN0IGRybV9pOTE1X2Vycm9yX29iamVjdCAqZHN0KQo+ICAgewo+IEBA
IC05NTEsMTUgKzk4NSwxNSBAQCBpOTE1X2Vycm9yX29iamVjdF9jcmVhdGUoc3RydWN0IGRybV9p
OTE1X3ByaXZhdGUgKmk5MTUsCj4gICAJCWlmIChyZXQpCj4gICAJCQlnb3RvIHVud2luZDsKPiAg
IAl9Cj4gLQlnb3RvIG91dDsKPiAgIAo+ICsJaWYgKGNvbXByZXNzX2ZsdXNoKCZjb21wcmVzcywg
ZHN0KSkgewo+ICAgdW53aW5kOgoKQSBiaXQgbmFzdHksIGp1bXAgaW4gY29uZGl0aW9uYWwgYmxv
Y2suIENvdWxkIHNldCBhIGJvb2xlYW4gYW5kIGJyZWFrIApmcm9tIHRoZSBhYm92ZSBsb29wLiBM
aWtlICJpZiAoZmFpbGVkIHx8IGNvbXByZXNzX2ZsdXNoKC4uLikpIi4KCj4gLQl3aGlsZSAoZHN0
LT5wYWdlX2NvdW50LS0pCj4gLQkJZnJlZV9wYWdlKCh1bnNpZ25lZCBsb25nKWRzdC0+cGFnZXNb
ZHN0LT5wYWdlX2NvdW50XSk7Cj4gLQlrZnJlZShkc3QpOwo+IC0JZHN0ID0gTlVMTDsKPiArCQl3
aGlsZSAoZHN0LT5wYWdlX2NvdW50LS0pCj4gKwkJCWZyZWVfcGFnZSgodW5zaWduZWQgbG9uZylk
c3QtPnBhZ2VzW2RzdC0+cGFnZV9jb3VudF0pOwo+ICsJCWtmcmVlKGRzdCk7Cj4gKwkJZHN0ID0g
TlVMTDsKPiArCX0KPiAgIAo+IC1vdXQ6Cj4gICAJY29tcHJlc3NfZmluaSgmY29tcHJlc3MsIGRz
dCk7Cj4gICAJZ2d0dC0+dm0uY2xlYXJfcmFuZ2UoJmdndHQtPnZtLCBzbG90LCBQQUdFX1NJWkUp
Owo+ICAgCXJldHVybiBkc3Q7Cj4gCgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50
ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y
Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=