From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Use
 i915_gem_object_get_dma_address() to populate rotated vmas
Date: Thu, 18 Oct 2018 15:52:27 +0100
Message-ID: <68e4830a-42fa-b6a3-901f-7f23467de43f@linux.intel.com>
References: <20181016150413.11577-1-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 2FF866E00D
 for <intel-gfx@lists.freedesktop.org>; Thu, 18 Oct 2018 14:52:30 +0000 (UTC)
In-Reply-To: <20181016150413.11577-1-ville.syrjala@linux.intel.com>
Content-Language: en-GB
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDE2LzEwLzIwMTggMTY6MDQsIFZpbGxlIFN5cmphbGEgd3JvdGU6Cj4gRnJvbTogVmlsbGUg
U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBSZXBsYWNlIHRo
ZSBrdm1hbGxvY19hcnJheSgpIHdpdGggaTkxNV9nZW1fb2JqZWN0X2dldF9kbWFfYWRkcmVzcygp
IHdoZW4KPiBwb3B1bGF0aW5nIHJvdGF0ZWQgdm1hcy4gT25lIHJhbmRvbSBhY2Nlc3MgbWVjaGFu
aXNtIG91Z2h0IHRvIGJlIGVub3VnaAo+IGZvciBldmVyeW9uZT8KPiAKPiBUbyBjYWxjdWxhdGUg
dGhlIHNpemUgb2YgdGhlIHJhZGl4IHRyZWUgSSB0aGluayB3ZSBjYW4gZG8KPiBzb21ldGhpbmcg
bGlrZSB0aGlzIChhc3N1bWluZyA2NGJpdCBwb2ludGVycyk6Cj4gICBudW1fcGFnZXMgPSBvYmpf
c2l6ZSAvIDQwOTYKPiAgIHRyZWVfaGVpZ2h0ID0gY2VpbChsb2c2NChudW1fcGFnZXMpKQo+ICAg
bnVtX25vZGVzID0gc3VtKDY0Xm4sIG4sIDAsIHRyZWVfaGVpZ2h0LTEpCj4gICB0cmVlX3NpemUg
PSBudW1fbm9kZXMgKiA1NzYKPiAKPiBJZiB3ZSBjb21wYXJlIHRoYXQgd2l0aCB0aGUgb2JqZWN0
IHNpemUgd2Ugc2hvdWxkIGdldCBhIHJlbGF0aXZlCj4gb3ZlcmhlYWQgb2YgYXJvdW5kIC4yJSB0
byAxJSBmb3IgcmVhc29uYWJsZSBzaXplZCBvYmplY3RzLAo+IHdoaWNoIGZyYW1lYnVmZmVycyB0
ZW5kIHRvIGJlLgo+IAo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51
az4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGxpbnV4LmludGVsLmNvbT4K
PiBTdWdnZXN0ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+
IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl
bC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYyB8IDMx
ICsrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNl
cnRpb25zKCspLCAyNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9n
dHQuYwo+IGluZGV4IDI5Y2E5MDA3YTcwNC4uOThkOWExZWIxZWQyIDEwMDY0NAo+IC0tLSBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiBAQCAtMzYzNyw3ICszNjM3LDcgQEAgdm9pZCBpOTE1X2dl
bV9yZXN0b3JlX2d0dF9tYXBwaW5ncyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp
Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyBzdHJ1Y3Qgc2NhdHRlcmxpc3QgKgo+IC1yb3RhdGVfcGFn
ZXMoY29uc3QgZG1hX2FkZHJfdCAqaW4sIHVuc2lnbmVkIGludCBvZmZzZXQsCj4gK3JvdGF0ZV9w
YWdlcyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLCB1bnNpZ25lZCBpbnQgb2Zmc2V0
LAo+ICAgCSAgICAgdW5zaWduZWQgaW50IHdpZHRoLCB1bnNpZ25lZCBpbnQgaGVpZ2h0LAo+ICAg
CSAgICAgdW5zaWduZWQgaW50IHN0cmlkZSwKPiAgIAkgICAgIHN0cnVjdCBzZ190YWJsZSAqc3Qs
IHN0cnVjdCBzY2F0dGVybGlzdCAqc2cpCj4gQEAgLTM2NDYsNyArMzY0Niw3IEBAIHJvdGF0ZV9w
YWdlcyhjb25zdCBkbWFfYWRkcl90ICppbiwgdW5zaWduZWQgaW50IG9mZnNldCwKPiAgIAl1bnNp
Z25lZCBpbnQgc3JjX2lkeDsKPiAgIAo+ICAgCWZvciAoY29sdW1uID0gMDsgY29sdW1uIDwgd2lk
dGg7IGNvbHVtbisrKSB7Cj4gLQkJc3JjX2lkeCA9IHN0cmlkZSAqIChoZWlnaHQgLSAxKSArIGNv
bHVtbjsKPiArCQlzcmNfaWR4ID0gc3RyaWRlICogKGhlaWdodCAtIDEpICsgY29sdW1uICsgb2Zm
c2V0Owo+ICAgCQlmb3IgKHJvdyA9IDA7IHJvdyA8IGhlaWdodDsgcm93KyspIHsKPiAgIAkJCXN0
LT5uZW50cysrOwo+ICAgCQkJLyogV2UgZG9uJ3QgbmVlZCB0aGUgcGFnZXMsIGJ1dCBuZWVkIHRv
IGluaXRpYWxpemUKPiBAQCAtMzY1NCw3ICszNjU0LDggQEAgcm90YXRlX3BhZ2VzKGNvbnN0IGRt
YV9hZGRyX3QgKmluLCB1bnNpZ25lZCBpbnQgb2Zmc2V0LAo+ICAgCQkJICogVGhlIG9ubHkgdGhp
bmcgd2UgbmVlZCBhcmUgRE1BIGFkZHJlc3Nlcy4KPiAgIAkJCSAqLwo+ICAgCQkJc2dfc2V0X3Bh
Z2Uoc2csIE5VTEwsIEk5MTVfR1RUX1BBR0VfU0laRSwgMCk7Cj4gLQkJCXNnX2RtYV9hZGRyZXNz
KHNnKSA9IGluW29mZnNldCArIHNyY19pZHhdOwo+ICsJCQlzZ19kbWFfYWRkcmVzcyhzZykgPQo+
ICsJCQkJaTkxNV9nZW1fb2JqZWN0X2dldF9kbWFfYWRkcmVzcyhvYmosIHNyY19pZHgpOwo+ICAg
CQkJc2dfZG1hX2xlbihzZykgPSBJOTE1X0dUVF9QQUdFX1NJWkU7Cj4gICAJCQlzZyA9IHNnX25l
eHQoc2cpOwo+ICAgCQkJc3JjX2lkeCAtPSBzdHJpZGU7Cj4gQEAgLTM2NjgsMjIgKzM2NjksMTEg
QEAgc3RhdGljIG5vaW5saW5lIHN0cnVjdCBzZ190YWJsZSAqCj4gICBpbnRlbF9yb3RhdGVfcGFn
ZXMoc3RydWN0IGludGVsX3JvdGF0aW9uX2luZm8gKnJvdF9pbmZvLAo+ICAgCQkgICBzdHJ1Y3Qg
ZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKQo+ICAgewo+IC0JY29uc3QgdW5zaWduZWQgbG9uZyBu
X3BhZ2VzID0gb2JqLT5iYXNlLnNpemUgLyBJOTE1X0dUVF9QQUdFX1NJWkU7Cj4gICAJdW5zaWdu
ZWQgaW50IHNpemUgPSBpbnRlbF9yb3RhdGlvbl9pbmZvX3NpemUocm90X2luZm8pOwo+IC0Jc3Ry
dWN0IHNndF9pdGVyIHNndF9pdGVyOwo+IC0JZG1hX2FkZHJfdCBkbWFfYWRkcjsKPiAtCXVuc2ln
bmVkIGxvbmcgaTsKPiAtCWRtYV9hZGRyX3QgKnBhZ2VfYWRkcl9saXN0Owo+ICAgCXN0cnVjdCBz
Z190YWJsZSAqc3Q7Cj4gICAJc3RydWN0IHNjYXR0ZXJsaXN0ICpzZzsKPiAgIAlpbnQgcmV0ID0g
LUVOT01FTTsKPiAtCj4gLQkvKiBBbGxvY2F0ZSBhIHRlbXBvcmFyeSBsaXN0IG9mIHNvdXJjZSBw
YWdlcyBmb3IgcmFuZG9tIGFjY2Vzcy4gKi8KPiAtCXBhZ2VfYWRkcl9saXN0ID0ga3ZtYWxsb2Nf
YXJyYXkobl9wYWdlcywKPiAtCQkJCQlzaXplb2YoZG1hX2FkZHJfdCksCj4gLQkJCQkJR0ZQX0tF
Uk5FTCk7Cj4gLQlpZiAoIXBhZ2VfYWRkcl9saXN0KQo+IC0JCXJldHVybiBFUlJfUFRSKHJldCk7
Cj4gKwlpbnQgaTsKPiAgIAo+ICAgCS8qIEFsbG9jYXRlIHRhcmdldCBTRyBsaXN0LiAqLwo+ICAg
CXN0ID0ga21hbGxvYyhzaXplb2YoKnN0KSwgR0ZQX0tFUk5FTCk7Cj4gQEAgLTM2OTQsMjkgKzM2
ODQsMjAgQEAgaW50ZWxfcm90YXRlX3BhZ2VzKHN0cnVjdCBpbnRlbF9yb3RhdGlvbl9pbmZvICpy
b3RfaW5mbywKPiAgIAlpZiAocmV0KQo+ICAgCQlnb3RvIGVycl9zZ19hbGxvYzsKPiAgIAo+IC0J
LyogUG9wdWxhdGUgc291cmNlIHBhZ2UgbGlzdCBmcm9tIHRoZSBvYmplY3QuICovCj4gLQlpID0g
MDsKPiAtCWZvcl9lYWNoX3NndF9kbWEoZG1hX2FkZHIsIHNndF9pdGVyLCBvYmotPm1tLnBhZ2Vz
KQo+IC0JCXBhZ2VfYWRkcl9saXN0W2krK10gPSBkbWFfYWRkcjsKPiAtCj4gLQlHRU1fQlVHX09O
KGkgIT0gbl9wYWdlcyk7Cj4gICAJc3QtPm5lbnRzID0gMDsKPiAgIAlzZyA9IHN0LT5zZ2w7Cj4g
ICAKPiAgIAlmb3IgKGkgPSAwIDsgaSA8IEFSUkFZX1NJWkUocm90X2luZm8tPnBsYW5lKTsgaSsr
KSB7Cj4gLQkJc2cgPSByb3RhdGVfcGFnZXMocGFnZV9hZGRyX2xpc3QsIHJvdF9pbmZvLT5wbGFu
ZVtpXS5vZmZzZXQsCj4gKwkJc2cgPSByb3RhdGVfcGFnZXMob2JqLCByb3RfaW5mby0+cGxhbmVb
aV0ub2Zmc2V0LAo+ICAgCQkJCSAgcm90X2luZm8tPnBsYW5lW2ldLndpZHRoLCByb3RfaW5mby0+
cGxhbmVbaV0uaGVpZ2h0LAo+ICAgCQkJCSAgcm90X2luZm8tPnBsYW5lW2ldLnN0cmlkZSwgc3Qs
IHNnKTsKPiAgIAl9Cj4gICAKPiAtCWt2ZnJlZShwYWdlX2FkZHJfbGlzdCk7Cj4gLQo+ICAgCXJl
dHVybiBzdDsKPiAgIAo+ICAgZXJyX3NnX2FsbG9jOgo+ICAgCWtmcmVlKHN0KTsKPiAgIGVycl9z
dF9hbGxvYzoKPiAtCWt2ZnJlZShwYWdlX2FkZHJfbGlzdCk7Cj4gICAKPiAgIAlEUk1fREVCVUdf
RFJJVkVSKCJGYWlsZWQgdG8gY3JlYXRlIHJvdGF0ZWQgbWFwcGluZyBmb3Igb2JqZWN0IHNpemUg
JXp1ISAoJXV4JXUgdGlsZXMsICV1IHBhZ2VzKVxuIiwKPiAgIAkJCSBvYmotPmJhc2Uuc2l6ZSwg
cm90X2luZm8tPnBsYW5lWzBdLndpZHRoLCByb3RfaW5mby0+cGxhbmVbMF0uaGVpZ2h0LCBzaXpl
KTsKPiAKClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwu
Y29tPgoKQW5kIGFwb2xvZ2llcyBmb3IgdGhlIGRlbGF5LiBQcmV2aW91c2x5IEkgd2FzIGNlcnRh
aW4gdGhlIGNhY2hlIHNpemUgCndvdWxkIHR5cGljYWxseSBiZSBtdWNoIGJpZ2dlci4gUGVyaGFw
cyBJIG1lYXN1cmVkIGluY29ycmVjdGx5IGJhY2sgCnRoZW4sIG9yIHNvbWV0aGluZy4uLgoKUmVn
YXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v
cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n
ZngK