From: Mahesh Kumar <mahesh1.kumar@intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/8] drm/i915: Change get_existing_crtc_state to old state
Date: Tue, 1 Aug 2017 13:34:27 +0530 [thread overview]
Message-ID: <6ab9c03a-14f2-5c8b-5895-ca6cbb74555d@intel.com> (raw)
In-Reply-To: <1489dc5a-6421-db04-4194-9005f39401e0@linux.intel.com>
On Tuesday 01 August 2017 01:23 PM, Maarten Lankhorst wrote:
> Hey,
>
> Op 01-08-17 om 08:46 schreef Mahesh Kumar:
>> Hi,
>>
>> As per my understanding "get_existing_*_state == get_new_*_state"
>>
>> It looks like you are trying to use currently available unused wrapper for completely different purpose. But IMHO you should create a new wrapper for get_old_state
>>
>> & this should be renamed to get_new_state. :)
> This really depends, and is the reason why we have to rename this.
>
> Before commit:
> get_existing_state == get_new_state
>
> After commit:
> get_existing_state == get_old_state.
yeah, right :)
>
> Perhaps I can add both in this patch, I'll clean the series up slightly.
sounds good
-Mahesh
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-08-01 8:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 13:15 [PATCH 0/8] drm/i915: Stop using get_existing_state Maarten Lankhorst
2017-07-20 13:15 ` [PATCH 1/8] drm/i915: Change use get_new_plane_state instead of existing plane state Maarten Lankhorst
2017-08-01 6:36 ` Mahesh Kumar
2017-08-01 7:55 ` Maarten Lankhorst
2017-07-20 13:15 ` [PATCH 2/8] drm/i915: Change get_existing_crtc_state to old state Maarten Lankhorst
2017-08-01 6:46 ` Mahesh Kumar
2017-08-01 7:53 ` Maarten Lankhorst
2017-08-01 8:04 ` Mahesh Kumar [this message]
2017-07-20 13:15 ` [PATCH 3/8] drm/i915: Use new atomic helpers in intel_plane_atomic_check Maarten Lankhorst
2017-08-01 7:57 ` Mahesh Kumar
2017-07-20 13:15 ` [PATCH 4/8] drm/i915: Use intel_atomic_get_new_crtc_state in intel_fbc.c Maarten Lankhorst
2017-08-01 8:00 ` Mahesh Kumar
2017-07-20 13:15 ` [PATCH 5/8] drm/i915: Remove last references to drm_atomic_get_existing* macros Maarten Lankhorst
2017-07-20 13:15 ` [PATCH 6/8] drm/i915: Do not update legacy state any more Maarten Lankhorst
2017-07-20 13:15 ` [RFC PATCH 7/8] drm/i915: Calculate ironlake intermediate watermarks correctly, v2 Maarten Lankhorst
2017-07-20 13:15 ` [RFC PATCH 8/8] drm/i915: Calculate vlv/chv intermediate watermarks correctly, v3 Maarten Lankhorst
2017-07-20 16:26 ` Maarten Lankhorst
2017-07-20 15:40 ` ✓ Fi.CI.BAT: success for drm/i915: Stop using get_existing_state Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ab9c03a-14f2-5c8b-5895-ca6cbb74555d@intel.com \
--to=mahesh1.kumar@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox