Re: [PATCH 00/12] drm/i915: Move DP link retraining to hotplug work etc.

Ville Syrjälä
2016-08-04T13:08:39Z

On Thu, Jul 28, 2016 at 05:50:36PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Ok, so while looking at the upfront link training stuff, it became obvious
> that we needs to do something about the link training stuff that we have
> in hpd_pulse currently. The thing is, you can't grab any modeset locks from
> that work since it could lead to a deadlock with MST sideband stuff.
> So here's a quick attempt at moving the stuff over to the hotplug work.
>
> I've included a few other things at the start just to make the
> surroundings a little less broken (some of that I've posted before).
> And there are a few potentially helpful snippets at the end too.
> The main meat is in the middle.
>
> Entire series avaialable here:
> git://github.com/vsyrjala/linux.git dp_retrain_fixes
>
> Ville Syrjälä (12):
> drm/i915: Read PSR caps/intermediate freqs/etc. only once on eDP
> drm/i915: Avoid mixing up SST and MST in DDI setup
> drm/i915: Reject mixing MST and SST/HDMI on the same digital port
> drm/i915: Track active streams also for DP SST
> drm/i915: Allow MST sinks to work even if drm_probe_ddc() fails
> drm/i915: Remove useless rate_to_index() usage
> drm/i915: Don't try to ack sink irqs when there are none

I've pushed these to dinq. Thanks for the reviews.

> drm/i915: Ignore initial lid state for eDP
> drm/i915: Move DP link retraining into intel_dp_detect()
> drm/i915: Skip dpcd/edid read unless there was a long hpd
> drm/i915: Allow rate_to_index() to return non-exact matches
> drm/i915: Add encoder .sync_state() hook

These are left over. Probably most of them need some
rework/rethinking anyway.

>
> drivers/gpu/drm/i915/intel_ddi.c | 35 ++--
> drivers/gpu/drm/i915/intel_display.c | 14 ++
> drivers/gpu/drm/i915/intel_dp.c | 390 ++++++++++++++++++-----------------
> drivers/gpu/drm/i915/intel_dp_mst.c | 16 +-
> drivers/gpu/drm/i915/intel_drv.h | 12 +-
> 5 files changed, 255 insertions(+), 212 deletions(-)
>
> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Cc: Jim Bride <jim.bride@linux.intel.com>
> Cc: Manasi D Navare <manasi.d.navare@intel.com>
> Cc: Durgadoss R <durgadoss.r@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> --
> 2.7.4

--
Ville Syrjälä
Intel OTC