From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [Intel-gfx] [PATCH 1/8] drm/omap: Simplify the rotation-on-crtc hack Date: Mon, 31 Jul 2017 14:56:16 +0300 Message-ID: <6b34707b-fed4-1c1d-e050-9eebee2a923d@ti.com> References: <20170725080122.20548-1-daniel.vetter@ffwll.ch> <9a42cbd2-70e1-0654-2146-6cc4c8e058aa@linux.intel.com> <5875908.nkarGct6Ju@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0595116613==" Return-path: In-Reply-To: <5875908.nkarGct6Ju@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: intel-gfx@lists.freedesktop.org --===============0595116613== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="e2TSJm0xBvXdxk0oirhdT9KPl7fsqlcC2" --e2TSJm0xBvXdxk0oirhdT9KPl7fsqlcC2 Content-Type: multipart/mixed; boundary="4OxuO1JgNd083AaGdMQrQwMAUhL09XoDs"; protected-headers="v1" From: Tomi Valkeinen To: Laurent Pinchart , Daniel Vetter Cc: Maarten Lankhorst , Intel Graphics Development , DRI Development , Daniel Vetter Message-ID: <6b34707b-fed4-1c1d-e050-9eebee2a923d@ti.com> Subject: Re: [Intel-gfx] [PATCH 1/8] drm/omap: Simplify the rotation-on-crtc hack References: <20170725080122.20548-1-daniel.vetter@ffwll.ch> <9a42cbd2-70e1-0654-2146-6cc4c8e058aa@linux.intel.com> <5875908.nkarGct6Ju@avalon> In-Reply-To: <5875908.nkarGct6Ju@avalon> --4OxuO1JgNd083AaGdMQrQwMAUhL09XoDs Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 31/07/17 14:48, Laurent Pinchart wrote: >>> The comment about read lock is only valid when the plane is bound to = the >>> crtc. In general this is not always the case. You can only peak at >>> plane->state when crtc->state->plane_mask & BIT(drm_plane_index(plane= )) >>> is true. >>> >>> I think we might need -EDEADLK handling for getprop then, even though= it's >>> not optimal. :( >> >> Well both the old an new way only worked because we grab all the locks= >> unconditionally. And I'd really want to avoid get_prop being anything >> but a simple lookup. Unfortuantely that breaks omapdrm, so no idea >> what exactly to do here. >> >> In a way adding properties without standardizing them across drivers >> first was a really bad idea, because then we have disjoint sets of >> uapi expectations, and there's just no way to make that work. >> >> I guess one radical approach might be to make this the "standard", and= >> just redirect rotation from the CRTC to the primary plane. >> >> Or omapdrm needs to duplicate the property properly, and update one if= >> the other is set. I think that's probably the most workable approach. >=20 > Maybe the first question we should answer is whether this hack is still= needed=20 > in the omapdrm driver. Tomi, do you know whether userspace still needs = this ? The omap X driver uses legacy modesetting and the rotation property for the crtc. Tomi --4OxuO1JgNd083AaGdMQrQwMAUhL09XoDs-- --e2TSJm0xBvXdxk0oirhdT9KPl7fsqlcC2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZfxrgAAoJEPo9qoy8lh716BgP/RV2quP1p4qWY0JJ6xpt4Nu8 SNCcSmFN3XJ+L9HrF7I4X8p6sYXXIEsn1UPWeUtUpWKmzbH4PrL1Q8s0fAO64Afu 0AUizgwPprR3mcB8siodFdk/H3K62px94k8jtSxQkRZe71FGAn7T78fPo+lH1KvB CUuJXUiUSr/9FZ0v/vvFQqGJbEWV3wNmhriVRs/s43EscRIg0jZId7uiO6lvXuUs D0vbP2+f0mEIaYY8E3jjscktAZaThuNdNDj2LhHFJsAaM0fvN1UDluy+29m8jNZX YU3qYd1OjQ3vQ5wJeG1uiTT9g1qv0U7AiN3ZayLFmT8Jd8FMz/hCXlWxJoa7yb/b 0SwEFOqJMwmd8L/TLGv6wissNLrFTZ+GU9F33qVq0XtSF1+e9wThBsnP4G4Qe0g8 eHfLT+5IoFWYbxv1kk7MN4VATOin/BUioi64bbimoI+doNN6P6Y+mxnFdlbQTMga +C4PPFuwoC2QZDSDqDSxUIfyyyL9Sdp/Bf3yGyAqwYCfsBkMY2SUki2H4oMvPNiy 8kh6Zsx5TgoN6cOe5l4rW/ke14ay9N0Ho3v+rstz1OXjMr1udDFLD2cNK4B0CsHL Jlnm131tKvr3iDHSsG4JfDzEYGTlJstJ7wZlAlDdvN7yCA/4jl7n9O4x2Im9dmBG pCU5wSX8i7/XWV2wh6/I =bYjF -----END PGP SIGNATURE----- --e2TSJm0xBvXdxk0oirhdT9KPl7fsqlcC2-- --===============0595116613== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0595116613==--