From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [Intel-gfx] [PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2. Date: Wed, 1 Nov 2017 18:23:36 +0100 Message-ID: <6c1904c8-9c67-439c-1a24-bde91142b48a@linux.intel.com> References: <20171101150433.10777-1-maarten.lankhorst@linux.intel.com> <20171101152903.GF10981@intel.com> <20171101170019.GG10981@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171101170019.GG10981@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMDEtMTEtMTcgb20gMTg6MDAgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gV2VkLCBO b3YgMDEsIDIwMTcgYXQgMDQ6NTU6MDZQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IE9wIDAxLTExLTE3IG9tIDE2OjI5IHNjaHJlZWYgVmlsbGUgU3lyasOkbMOkOgo+Pj4gT24g V2VkLCBOb3YgMDEsIDIwMTcgYXQgMDQ6MDQ6MzNQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qg d3JvdGU6Cj4+Pj4gVGhpcyBpbnRyb2R1Y2VzIGEgc2xpZ2h0IGJlaGF2aW9yYWwgY2hhbmdlIHRv IHJtZmIuIEluc3RlYWQgb2YKPj4+PiBkaXNhYmxpbmcgYSBjcnRjIHdoZW4gdGhlIHByaW1hcnkg cGxhbmUgaXMgZGlzYWJsZWQsIHdlIHRyeSB0bwo+Pj4+IHByZXNlcnZlIGl0Lgo+Pj4+Cj4+Pj4g QXBhcnQgZnJvbSBvbGQgdmVyc2lvbnMgb2YgdGhlIHZtd2dmeCB4b3JnIGRyaXZlciwgdGhlcmUg aXMKPj4+PiBub3RoaW5nIGRlcGVuZGluZyBvbiBybWZiIGRpc2FibGluZyBhIGNydGMuCj4+Pj4K Pj4+PiBWbXdnZngnIGFuZCBzaW1wbGUga21zIGhlbHBlciBhdG9taWMgaW1wbGVtZW50YXRpb24g cmVqZWN0cyBDUlRDCj4+Pj4gZW5hYmxlZCB3aXRob3V0IHBsYW5lLCBzbyB3ZSBjYW4gZG8gdGhp cyBzYWZlbHkuCj4gVGhlIGNvZGUgZm9yIHRob3NlIHNlZW1zIGEgYml0IGluY29uc2lzdGVudC4g VGhlIGNydGMgY2hlY2sgcmVxdWlyZXMKPiB0aGF0IHRoZSBjcnRjIHN0YXRlIGFuZCBwbGFuZSBz dGF0ZSBtYXRjaC4gQnV0IHRoZSBwbGFuZSBjaGVjayBhbGxvd3MKPiB0aGUgcGxhbmUgdG8gYmUg ZW5hYmxlZCB3L28gdGhlIGNydGMgYmVpbmcgZW5hYmxlZC4gSSBndWVzcyBpdCBkb2Vzbid0Cj4g bWF0dGVyIHJlYWxseSBzaW5jZSB5b3UgY2FuJ3QgZW5hYmxlIHRoZSBwbGFuZSB3aXRob3V0IGEg Y3J0YywgYW5kIHRoZQo+IGNydGMgY2hlY2sgd291bGQgdGhlbiBjYXRjaCB0aGUgY2FzZSB3aGVy ZSB0aGUgY3J0YyB3b3VsZCBiZSBkaXNhYmxlZC4KPgo+IE9oIGFuZCBsb29rcyBsaWtlIGRybV9w bGFuZV9oZWxwZXJfY2hlY2tfc3RhdGUoKSBpcyBhIGJpdCBidWdneS4gSXQKPiBzdGlsbCB1c2Vz IGNydGMtPmVuYWJsZWQgaW5zdGVhZCBvZiBjcnRjX3N0YXRlLT5lbmFibGUgdG8gY2hlY2sgdGhl Cj4gc3RhdGUgb2YgdGhlIGNydGMuIEkgZ3Vlc3MgdG8ga2VlcCBkcm1fcGxhbmVfaGVscGVyX2No ZWNrX3VwZGF0ZSgpCj4gd29ya2luZyB3ZSBtYXkgaGF2ZSB0byBwYXNzIGluIHRoZSBjcnRjIHN0 YXRlIG1hbnVhbGx5LgpUaGlzIGlzIHRoZSB0cmFuc2l0aW9uYWwgaGVscGVyLiBpOTE1IGdldHMg YXdheSB3aXRoIGl0IGJlY2F1c2UgaXQgcGFzc2VzIHRoZSBmbGFnIHRoYXQgaWdub3JlcyBjcnRj LT5lbmFibGVkLgo+IFRoZSB2bXdnZnggcGxhbmUgY2hlY2sgbG9va3MgYSBiaXQgYm9ndXMgaW4g b3RoZXIgd2F5cyB0b28uIEkgZ3Vlc3MKPiBJJ2xsIGhhdmUgdG8gZmlyZSBvZmYgYSBjb3VwbGUg b2YgcGF0Y2hlcy4KPgo+Pj4+IElmIHRoZSBhdG9taWMgY29tbWl0IGlzIHJlamVjdGVkIGJ5IHRo ZSBkcml2ZXIgdGhlbiB3ZSB3aWxsIHN0aWxsCj4+Pj4gZmFsbCBiYWNrIHRvIHRoZSBvbGQgYmVo YXZpb3IgYW5kIHR1cm4gb2ZmIHRoZSBjcnRjLgo+Pj4+Cj4+Pj4gQ2hhbmdlcyBzaW5jZSB2MToK Pj4+PiAtIFJlc3RhcnQgY29tcGxldGVseSB3aGVuIHJtZmIgd2l0aCBjcnRjIG9uIGZhaWxzIChT ZWFuIFBhdWwpLgo+Pj4+Cj4+Pj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1h YXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPj4+PiBDYzogU2VhbiBQYXVsIDxzZWFu cGF1bEBjaHJvbWl1bS5vcmc+Cj4+Pj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJA ZmZ3bGwuY2g+Cj4+Pj4gLS0tCj4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIu YyB8IDIzICsrKysrKysrKysrKysrKysrLS0tLS0tCj4+Pj4gIDEgZmlsZSBjaGFuZ2VkLCAxNyBp bnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+Pj4+Cj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVi dWZmZXIuYwo+Pj4+IGluZGV4IDJhZmZlNTNmM2ZkYS4uZjA2Nzk0NjhmNDIxIDEwMDY0NAo+Pj4+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYwo+Pj4+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYwo+Pj4+IEBAIC03NjUsMTQgKzc2NSwxOCBAQCBz dGF0aWMgaW50IGF0b21pY19yZW1vdmVfZmIoc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4+ Pj4gIAlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZTsKPj4+PiAgCXN0cnVjdCBkcm1fY29ubmVjdG9y ICpjb25uOwo+Pj4+ICAJc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGU7Cj4+ Pj4gLQlpbnQgaSwgcmV0ID0gMDsKPj4+PiArCWludCBpLCByZXQ7Cj4+Pj4gIAl1bnNpZ25lZCBw bGFuZV9tYXNrOwo+Pj4+ICsJYm9vbCBkaXNhYmxlX2NydGNzID0gZmFsc2U7Cj4+Pj4gIAo+Pj4+ IC0Jc3RhdGUgPSBkcm1fYXRvbWljX3N0YXRlX2FsbG9jKGRldik7Cj4+Pj4gLQlpZiAoIXN0YXRl KQo+Pj4+IC0JCXJldHVybiAtRU5PTUVNOwo+Pj4+IC0KPj4+PiArcmV0cnlfZGlzYWJsZToKPj4+ PiAgCWRybV9tb2Rlc2V0X2FjcXVpcmVfaW5pdCgmY3R4LCAwKTsKPj4+PiArCj4+Pj4gKwlzdGF0 ZSA9IGRybV9hdG9taWNfc3RhdGVfYWxsb2MoZGV2KTsKPj4+PiArCWlmICghc3RhdGUpIHsKPj4+ PiArCQlyZXQgPSAtRU5PTUVNOwo+Pj4+ICsJCWdvdG8gb3V0Owo+Pj4+ICsJfQo+Pj4+ICAJc3Rh dGUtPmFjcXVpcmVfY3R4ID0gJmN0eDsKPj4+PiAgCj4+Pj4gIHJldHJ5Ogo+Pj4+IEBAIC03OTMs NyArNzk3LDcgQEAgc3RhdGljIGludCBhdG9taWNfcmVtb3ZlX2ZiKHN0cnVjdCBkcm1fZnJhbWVi dWZmZXIgKmZiKQo+Pj4+ICAJCQlnb3RvIHVubG9jazsKPj4+PiAgCQl9Cj4+Pj4gIAo+Pj4+IC0J CWlmIChwbGFuZV9zdGF0ZS0+Y3J0Yy0+cHJpbWFyeSA9PSBwbGFuZSkgewo+Pj4+ICsJCWlmIChk aXNhYmxlX2NydGNzICYmIHBsYW5lX3N0YXRlLT5jcnRjLT5wcmltYXJ5ID09IHBsYW5lKSB7Cj4+ Pj4gIAkJCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPj4+PiAgCj4+Pj4gIAkJ CWNydGNfc3RhdGUgPSBkcm1fYXRvbWljX2dldF9leGlzdGluZ19jcnRjX3N0YXRlKHN0YXRlLCBw bGFuZV9zdGF0ZS0+Y3J0Yyk7Cj4+Pj4gQEAgLTgxOCw2ICs4MjIsNyBAQCBzdGF0aWMgaW50IGF0 b21pY19yZW1vdmVfZmIoc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4+Pj4gIAkJcGxhbmUt Pm9sZF9mYiA9IHBsYW5lLT5mYjsKPj4+PiAgCX0KPj4+PiAgCj4+Pj4gKwkvKiBUaGlzIGxpc3Qg aXMgb25seSBmaWxsZWQgd2hlbiBkaXNhYmxlX2NydGNzIGlzIHNldC4gKi8KPj4+PiAgCWZvcl9l YWNoX25ld19jb25uZWN0b3JfaW5fc3RhdGUoc3RhdGUsIGNvbm4sIGNvbm5fc3RhdGUsIGkpIHsK Pj4+IFdBUk5fT04oIWRpc2FibGVfY3J0Y3MpIG1heWJlPwo+PiBXb3VsZCBiZSBvdmVya2lsbCwg bm90aGluZyBiZWZvcmUgaXQgYWRkcyBjb25uZWN0b3Igc3RhdGUsIGFuZCBpZiBhdG9taWMgY2hl Y2sgZG9lcyB0aGVuIHRoYXQncyBmaW5lLCBidXQgaXQgd29uJ3QgYmUgcnVuIGhlcmUuIDopCj4g SXQgd291bGQgc2VydmUgYXMgYSB3YXkgdG8gZG9jdW1lbnQgdGhhdCBmYWN0LCBldmVuIHdpdGhv dXQgdGhlIGNvbW1lbnQuCj4gQnV0IEkgd29uJ3QgaW5zaXN0IG9uIGl0Lgo+Cj4+Pj4gIAkJcmV0 ID0gZHJtX2F0b21pY19zZXRfY3J0Y19mb3JfY29ubmVjdG9yKGNvbm5fc3RhdGUsIE5VTEwpOwo+ Pj4+ICAKPj4+PiBAQCAtODQwLDkgKzg0NSwxNSBAQCBzdGF0aWMgaW50IGF0b21pY19yZW1vdmVf ZmIoc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4+Pj4gIAo+Pj4+ICAJZHJtX2F0b21pY19z dGF0ZV9wdXQoc3RhdGUpOwo+Pj4+ICAKPj4+PiArb3V0Ogo+Pj4+ICAJZHJtX21vZGVzZXRfZHJv cF9sb2NrcygmY3R4KTsKPj4+PiAgCWRybV9tb2Rlc2V0X2FjcXVpcmVfZmluaSgmY3R4KTsKPj4+ PiAgCj4+Pj4gKwlpZiAocmV0ID09IC1FSU5WQUwgJiYgIWRpc2FibGVfY3J0Y3MpIHsKPj4+IEht bS4gLUVJTlZBTCBzZWVtcyByYXRoZXIgc3BlY2lmaWMuIE5vdCBzdXJlIGlmIHdlIGNvdWxkIGp1 c3QgY2hlY2sgZm9yCj4+PiBhbnkgZXJyb3I/Cj4+Pgo+Pj4gT3IuLi4gSSdtIG5vdCBzdXJlIGlm IHdlIGhhdmUgYW55IGNlbnRyYWwgcGxhY2Ugd2hlcmUgd2UgZG8gdGhlCj4+PiAiY2FuIEkgZGlz YWJsZSB0aGUgcHJpbWFyeSBwbGFuZSB3L28gZGlzYWJsaW5nIHRoZSBjcnRjPyIgY2hlY2suIElm IHdlCj4+PiBkbyB0aGVuIHdlIGNvdWxkIGFsc28gYWRkIGEgY29tbWVudCB0aGVyZSBpbmZvcm1p bmcgcGVvcGxlIHRoYXQgdGhlCj4+PiAtRUlOVkFMIGlzIGltcG9ydGFudC4KPj4gV2UgZG9uJ3Qg aGF2ZSBhIGNlbnRyYWwgcGxhY2UsIEkgY2hlY2sgZm9yIEVJTlZBTCBzaW5jZSB0aGF0IGlzIHRo ZSBnZW5lcmljIGF0b21pY19jaGVjaygpIGZhaWxlZCBlcnJvci4gSWYgaXQgZmFpbHMgZm9yIGFu eSBvdGhlciByZWFzb24gdGhlbiB3ZSBkb24ndCBoYXZlIHRvIHJldHJ5LCBidXQgcGFzcyBpdCBh bG9uZy4gOikKPiBPaCB3ZWxsLiBJIGd1ZXNzIHBlb3BsZSBqdXN0IGhhdmUgdG8gYmUgY2FyZWZ1 bCB3aXRoIHRoZWlyIGVycm9yCj4gdmFsdWVzLiBJIHN1cHBvZSBhbnlvbmUgZGVwZW5kaW5nIG9u IHRoZSByZXRyeSB3aWxsIG5vdGljZSB0aGlzCj4gaXNzdWUgcmF0aGVyIHF1aWNrbHkuClllcy4g OikKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK