From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 5/7 v2] drm/i915: Add setters for min/max frequency Date: Fri, 07 Sep 2012 10:47:45 +0100 Message-ID: <6c3329$5teb2u@orsmga002.jf.intel.com> References: <1346964850-2228-6-git-send-email-ben@bwidawsk.net> <1346983586-11921-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 129009E8F2 for ; Fri, 7 Sep 2012 02:47:53 -0700 (PDT) In-Reply-To: <1346983586-11921-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , Ben Widawsky , Jacob Pan , Arjan van de Ven List-Id: intel-gfx@lists.freedesktop.org The only bit of the series I don't like is the conversion to uJ which looks like it can overflow. Otherwise, Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre