From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: fixup i915_gem_object_get_page inline helper Date: Tue, 09 Oct 2012 23:16:02 +0100 Message-ID: <6c3329$6m595h@orsmga002.jf.intel.com> References: <84c8a8$624sk4@orsmga001.jf.intel.com> <1349815848-1824-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 4F2839EF94 for ; Tue, 9 Oct 2012 15:16:11 -0700 (PDT) In-Reply-To: <1349815848-1824-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Tue, 9 Oct 2012 22:50:48 +0200, Daniel Vetter wrote: > The obj->pages to obj->pages->sgl rework introduced this helper, but > it doesn't actually work for n >= SG_MAX_SINGLE_ALLOC. > > For simplicity (and since right now I seem to be too stupid to see > the bug), let's just grab the right page with a for_each_sg loop. > > This is exercised by the improved hangman tests and the gem_exec_big > test in i-g-t. > > v2: Compared to v1, don't try to be clever since I seemingly only > manage to prove that I'm not clever. Only I expect that loop to show up on profiles even higher than the sg_next() from pwrite. :| I expect it to have a measureable impact upon relocation throughput, so I should measure it... -Chris -- Chris Wilson, Intel Open Source Technology Centre