From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] intel: fix fullscreen damage posting on pageflip Date: Thu, 11 Oct 2012 08:53:14 +0100 Message-ID: <6c3329$6n0p70@orsmga002.jf.intel.com> References: <1349929829-25856-1-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id B9B449E83E for ; Thu, 11 Oct 2012 00:53:25 -0700 (PDT) In-Reply-To: <1349929829-25856-1-git-send-email-airlied@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Dave Airlie , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 11 Oct 2012 14:30:29 +1000, Dave Airlie wrote: > From: Dave Airlie > > While playing with MPX and sw cursor I noticed page flips won't > end up misrendering some bits, so the sw cursor was replacing the > bits on the wrong pixmap. > > Fix the damage handling to be correct and append damage before swapping > the pointers and process damage after. > > This fixes misrendering with MPX cursors under a fullscreen compositor, > that pageflips. Wow, what magic is this? The created region is the same and front->drawable left unmodified by the exchange. The exchange only manipulates the devPrivates and has not other side effects. The only uncertain quantity there is the intel_glamor_exchange_buffers()... So the change is that we append the same damage to the same drawable earlier, yet still process that damage at the same time, with no apparent side-effects between the two operations. I'm just not understanding why this has any effect. -Chris -- Chris Wilson, Intel Open Source Technology Centre