From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 4/5] drm/i915: implement WaDisableSpriteDestColorKey Date: Thu, 18 Oct 2012 12:32:08 +0100 Message-ID: <6c3329$6qi6q0@orsmga002.jf.intel.com> References: <1350553794-5534-1-git-send-email-daniel.vetter@ffwll.ch> <1350553794-5534-5-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id EF41E9E943 for ; Thu, 18 Oct 2012 04:32:29 -0700 (PDT) In-Reply-To: <1350553794-5534-5-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Thu, 18 Oct 2012 11:49:53 +0200, Daniel Vetter wrote: > Unfortunately this requires a bit of book-keeping to return the > right values for get_colorkey and to set things up correctly > when re-enabling the plane. Needs to worry about per-pipe values and ilk_get_colorkey(). Maybe the code would be simpler if we unconditionally shadowed DVSCNTR[I915_NUM_PIPES]. -Chris -- Chris Wilson, Intel Open Source Technology Centre