From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Handle sync_seqno correctly when seqno has wrapped. Date: Tue, 13 Nov 2012 14:15:05 +0000 Message-ID: <6c3329$767ssr@orsmga002.jf.intel.com> References: <1352814696-2154-1-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 2CF879F39B for ; Tue, 13 Nov 2012 06:15:10 -0800 (PST) In-Reply-To: <1352814696-2154-1-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Mika Kuoppala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 13 Nov 2012 15:51:36 +0200, Mika Kuoppala wrote: > If seqno has wrapped, normal compare operation will give wrong results. > i915_seqno_passed can handle the wrap so use it instead. I'm still a little wary of this patch, as it means that we are emitting requests that are not associated with an execbuffer and so the wraparound detection is lost. Perhaps if you were to make the seqno wraparound handling explicit we could all sleep more soundly... And then I'd accept this patch for making seqno handling consistent at least. -Chris -- Chris Wilson, Intel Open Source Technology Centre