Re: [PATCH v2] drm/i915/fbdev: Hold runtime PM ref during fbdev BO creation

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Tue, 2025-11-11 at 19:24 +0530, Dibin Moolakadan Subrahmanian wrote:
> During fbdev probe, the xe driver allocates and pins a framebuffer
> BO (via xe_bo_create_pin_map_novm() → xe_ggtt_insert_bo()).
> 
> Without a runtime PM reference, xe_pm_runtime_get_noresume() warns
> about
> missing outer PM protection as below:
> 
> 	xe 0000:03:00.0: [drm] Missing outer runtime PM protection
> 
> Acquire a runtime PM reference before framebuffer allocation to
> ensure
> xe_ggtt_insert_bo()  executes  under active runtime PM context.

Reviewed-by: Jouni Högander <jouni.hogander@intel.com>

> 
> Changes in v2:
>  - Update commit message to add Fixes tag (Jani Nikula)
> 
> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/6350
> Fixes: 44e694958b95 ("drm/xe/display: Implement display support")
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: Dibin Moolakadan Subrahmanian
> <dibin.moolakadan.subrahmanian@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_fbdev.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c
> b/drivers/gpu/drm/i915/display/intel_fbdev.c
> index e5449c41cfa1..7173bd1cbffd 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
> @@ -288,13 +288,18 @@ int intel_fbdev_driver_fbdev_probe(struct
> drm_fb_helper *helper,
>  		drm_framebuffer_put(&fb->base);
>  		fb = NULL;
>  	}
> +
> +	wakeref = intel_display_rpm_get(display);
> +
>  	if (!fb || drm_WARN_ON(display->drm, !intel_fb_bo(&fb-
> >base))) {
>  		drm_dbg_kms(display->drm,
>  			    "no BIOS fb, allocating a new one\n");
>  
>  		fb = __intel_fbdev_fb_alloc(display, sizes);
> -		if (IS_ERR(fb))
> -			return PTR_ERR(fb);
> +		if (IS_ERR(fb)) {
> +			ret = PTR_ERR(fb);
> +			goto out_unlock;
> +		}
>  	} else {
>  		drm_dbg_kms(display->drm, "re-using BIOS fb\n");
>  		prealloc = true;
> @@ -302,8 +307,6 @@ int intel_fbdev_driver_fbdev_probe(struct
> drm_fb_helper *helper,
>  		sizes->fb_height = fb->base.height;
>  	}
>  
> -	wakeref = intel_display_rpm_get(display);
> -
>  	/* Pin the GGTT vma for our access via info->screen_base.
>  	 * This also validates that any existing fb inherited from
> the
>  	 * BIOS is suitable for own access.