From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2403C433F5 for ; Thu, 24 Mar 2022 16:20:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 96CE710E971; Thu, 24 Mar 2022 16:20:39 +0000 (UTC) Received: from ste-pvt-msa1.bahnhof.se (ste-pvt-msa1.bahnhof.se [213.80.101.70]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7372F10E8E8; Thu, 24 Mar 2022 16:20:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ste-pvt-msa1.bahnhof.se (Postfix) with ESMTP id A79853F66C; Thu, 24 Mar 2022 17:20:35 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at bahnhof.se Authentication-Results: ste-pvt-msa1.bahnhof.se (amavisd-new); dkim=pass (1024-bit key) header.d=shipmail.org Received: from ste-pvt-msa1.bahnhof.se ([127.0.0.1]) by localhost (ste-pvt-msa1.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NQynLqPn4r-M; Thu, 24 Mar 2022 17:20:35 +0100 (CET) Received: by ste-pvt-msa1.bahnhof.se (Postfix) with ESMTPA id C808E3F641; Thu, 24 Mar 2022 17:20:34 +0100 (CET) Received: from [192.168.0.209] (unknown [192.55.54.50]) by mail1.shipmail.org (Postfix) with ESMTPSA id 3E9EA362508; Thu, 24 Mar 2022 17:20:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=shipmail.org; s=mail; t=1648138834; bh=PL/H/Cg6o+NjjCjYhpKoz5addjaflYuhMbacEi+EPlM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OlrSMpsPvwjFeC32UGS28apFDPbxVmeKgGYj7gSkfm1hu8MY8nnoDwZE0wnrpilTV wdklCKyLn1qVC7u3VfykH7pLePpEOSNVm0O0wK6vRFLmxhBes3Ry0Gckf7EYpBQd8Y H/BbUf4+l7ElHCcvIOn7saYpYrZmJUjSTvgT4ovI= Message-ID: <6eebe04c-da24-600d-1c46-8ae341d7a061@shipmail.org> Date: Thu, 24 Mar 2022 17:20:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: Ramalingam C , intel-gfx , dri-devel References: <20220321224459.12223-1-ramalingam.c@intel.com> <20220321224459.12223-7-ramalingam.c@intel.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m_=28Intel=29?= In-Reply-To: <20220321224459.12223-7-ramalingam.c@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH v5 6/9] drm/i915/gt: offset handling for multiple copy engines X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hellstrom Thomas , Matthew Auld Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 3/21/22 23:44, Ramalingam C wrote: > Handle the src and dst chunk offsets for different instances of the copy > engines. > > Signed-off-by: Ramalingam C > --- > drivers/gpu/drm/i915/gt/intel_migrate.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c > index 39a5f8ae664d..5f6341f91622 100644 > --- a/drivers/gpu/drm/i915/gt/intel_migrate.c > +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c > @@ -614,6 +614,9 @@ static int emit_copy(struct i915_request *rq, > u32 instance = rq->engine->instance; > u32 *cs; > > + src_offset += (u64)rq->engine->instance << 32; > + dst_offset += (u64)rq->engine->instance << 32; > + Again, these are nops since the offsets are 32-bit. Also the instance selection is already handled in the functon, so I think this patch can be dropped. > cs = intel_ring_begin(rq, ver >= 8 ? 10 : 6); > if (IS_ERR(cs)) > return PTR_ERR(cs);