From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/6] drm/i915/debugfs: reuse max slice/subslices already stored in sseu Date: Thu, 11 Jan 2018 11:21:06 +0000 Message-ID: <6ff059a5-886a-eac2-ed1b-d435a333e49a@linux.intel.com> References: <20171218153520.14181-1-lionel.g.landwerlin@intel.com> <20171218153520.14181-3-lionel.g.landwerlin@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id C29D96E79E for ; Thu, 11 Jan 2018 11:21:08 +0000 (UTC) In-Reply-To: <20171218153520.14181-3-lionel.g.landwerlin@intel.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lionel Landwerlin , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzEyLzIwMTcgMTU6MzUsIExpb25lbCBMYW5kd2VybGluIHdyb3RlOgo+IE5vdyB0aGF0 IHdlIGhhdmUgdGhhdCBpbmZvcm1hdGlvbiBpbiB0b3BvbG9neSBmaWVsZHMsIGxldCdzIGp1c3Qg cmV1c2VkIGl0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IExpb25lbCBMYW5kd2VybGluIDxsaW9uZWwu Zy5sYW5kd2VybGluQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZGVidWdmcy5jIHwgMjYgKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBj aGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2RlYnVnZnMuYwo+IGluZGV4IDBjNzg5MGI2OTVjNS4uNmVjNzU0M2U2OThmIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiBAQCAtNDMwOCwxMSArNDMwOCwx MSBAQCBzdGF0aWMgdm9pZCBnZW4xMF9zc2V1X2RldmljZV9zdGF0dXMoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCQkJCSAgICAgc3RydWN0IHNzZXVfZGV2X2luZm8gKnNz ZXUpCj4gICB7Cj4gICAJY29uc3Qgc3RydWN0IGludGVsX2RldmljZV9pbmZvICppbmZvID0gSU5U RUxfSU5GTyhkZXZfcHJpdik7Cj4gLQlpbnQgc19tYXggPSA2LCBzc19tYXggPSA0Owo+ICAgCWlu dCBzLCBzczsKPiAtCXUzMiBzX3JlZ1tzX21heF0sIGV1X3JlZ1syICogc19tYXhdLCBldV9tYXNr WzJdOwo+ICsJdTMyIHNfcmVnW2luZm8tPnNzZXUubWF4X3NsaWNlc10sCj4gKwkJZXVfcmVnWzIg KiBpbmZvLT5zc2V1Lm1heF9zdWJzbGljZXNdLCBldV9tYXNrWzJdOwoKVGhpcyBpcyBhIGJpdCB1 bnVzdWFsIHN0eWxlLCBwZXJoYXBzIHNwbGl0IGludG8gc2VwYXJhdGUgZGVjbGFyYXRpb25zLgoK PiAgIAo+IC0JZm9yIChzID0gMDsgcyA8IHNfbWF4OyBzKyspIHsKPiArCWZvciAocyA9IDA7IHMg PCBpbmZvLT5zc2V1Lm1heF9zbGljZXM7IHMrKykgewo+ICAgCQkvKgo+ICAgCQkgKiBGSVhNRTog VmFsaWQgU1MgTWFzayByZXNwZWN0cyB0aGUgc3BlYyBhbmQgcmVhZAo+ICAgCQkgKiBvbmx5IHZh bGlkIGJpdHMgZm9yIHRob3NlIHJlZ2lzdGVycywgZXhjbHVkaW5nIHJlc2VydmVyZAo+IEBAIC00 MzM0LDcgKzQzMzQsNyBAQCBzdGF0aWMgdm9pZCBnZW4xMF9zc2V1X2RldmljZV9zdGF0dXMoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCQkgICAgIEdFTjlfUEdDVExfU1NC X0VVMjEwX0FDSyB8Cj4gICAJCSAgICAgR0VOOV9QR0NUTF9TU0JfRVUzMTFfQUNLOwo+ICAgCj4g LQlmb3IgKHMgPSAwOyBzIDwgc19tYXg7IHMrKykgewo+ICsJZm9yIChzID0gMDsgcyA8IGluZm8t PnNzZXUubWF4X3NsaWNlczsgcysrKSB7Cj4gICAJCWlmICgoc19yZWdbc10gJiBHRU45X1BHQ1RM X1NMSUNFX0FDSykgPT0gMCkKPiAgIAkJCS8qIHNraXAgZGlzYWJsZWQgc2xpY2UgKi8KPiAgIAkJ CWNvbnRpbnVlOwo+IEBAIC00MzQyLDcgKzQzNDIsNyBAQCBzdGF0aWMgdm9pZCBnZW4xMF9zc2V1 X2RldmljZV9zdGF0dXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCQlz c2V1LT5zbGljZV9tYXNrIHw9IEJJVChzKTsKPiAgIAkJc3NldS0+c3Vic2xpY2VzX21hc2tbc10g PSBpbmZvLT5zc2V1LnN1YnNsaWNlc19tYXNrW3NdOwo+ICAgCj4gLQkJZm9yIChzcyA9IDA7IHNz IDwgc3NfbWF4OyBzcysrKSB7Cj4gKwkJZm9yIChzcyA9IDA7IHNzIDwgaW5mby0+c3NldS5tYXhf c3Vic2xpY2VzOyBzcysrKSB7Cj4gICAJCQl1bnNpZ25lZCBpbnQgZXVfY250Owo+ICAgCj4gICAJ CQlpZiAoIShzX3JlZ1tzXSAmIChHRU45X1BHQ1RMX1NTX0FDSyhzcykpKSkKPiBAQCAtNDM2Miwx NyArNDM2MiwxMSBAQCBzdGF0aWMgdm9pZCBnZW4xMF9zc2V1X2RldmljZV9zdGF0dXMoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgc3RhdGljIHZvaWQgZ2VuOV9zc2V1X2Rl dmljZV9zdGF0dXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCQkJCSAg ICBzdHJ1Y3Qgc3NldV9kZXZfaW5mbyAqc3NldSkKPiAgIHsKPiAtCWludCBzX21heCA9IDMsIHNz X21heCA9IDQ7Cj4gKwljb25zdCBzdHJ1Y3QgaW50ZWxfZGV2aWNlX2luZm8gKmluZm8gPSBJTlRF TF9JTkZPKGRldl9wcml2KTsKPiAgIAlpbnQgcywgc3M7Cj4gLQl1MzIgc19yZWdbc19tYXhdLCBl dV9yZWdbMipzX21heF0sIGV1X21hc2tbMl07Cj4gLQo+IC0JLyogQlhUIGhhcyBhIHNpbmdsZSBz bGljZSBhbmQgYXQgbW9zdCAzIHN1YnNsaWNlcy4gKi8KPiAtCWlmIChJU19HRU45X0xQKGRldl9w cml2KSkgewo+IC0JCXNfbWF4ID0gMTsKPiAtCQlzc19tYXggPSAzOwo+IC0JfQo+ICsJdTMyIHNf cmVnW2luZm8tPnNzZXUubWF4X3NsaWNlc10sIGV1X3JlZ1syKmluZm8tPnNzZXUubWF4X3N1YnNs aWNlc10sIGV1X21hc2tbMl07CgpTcGFjZXMgYXJvdW5kIG9wZXJhdG9ycyBhcmUgcHJlZmVycmVk LgoKPiAgIAo+IC0JZm9yIChzID0gMDsgcyA8IHNfbWF4OyBzKyspIHsKPiArCWZvciAocyA9IDA7 IHMgPCBpbmZvLT5zc2V1Lm1heF9zbGljZXM7IHMrKykgewo+ICAgCQlzX3JlZ1tzXSA9IEk5MTVf UkVBRChHRU45X1NMSUNFX1BHQ1RMX0FDSyhzKSk7Cj4gICAJCWV1X3JlZ1syKnNdID0gSTkxNV9S RUFEKEdFTjlfU1MwMV9FVV9QR0NUTF9BQ0socykpOwo+ICAgCQlldV9yZWdbMipzICsgMV0gPSBJ OTE1X1JFQUQoR0VOOV9TUzIzX0VVX1BHQ1RMX0FDSyhzKSk7Cj4gQEAgLTQzODcsNyArNDM4MSw3 IEBAIHN0YXRpYyB2b2lkIGdlbjlfc3NldV9kZXZpY2Vfc3RhdHVzKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiwKPiAgIAkJICAgICBHRU45X1BHQ1RMX1NTQl9FVTIxMF9BQ0sgfAo+ ICAgCQkgICAgIEdFTjlfUEdDVExfU1NCX0VVMzExX0FDSzsKPiAgIAo+IC0JZm9yIChzID0gMDsg cyA8IHNfbWF4OyBzKyspIHsKPiArCWZvciAocyA9IDA7IHMgPCBpbmZvLT5zc2V1Lm1heF9zbGlj ZXM7IHMrKykgewo+ICAgCQlpZiAoKHNfcmVnW3NdICYgR0VOOV9QR0NUTF9TTElDRV9BQ0spID09 IDApCj4gICAJCQkvKiBza2lwIGRpc2FibGVkIHNsaWNlICovCj4gICAJCQljb250aW51ZTsKPiBA QCAtNDM5OCw3ICs0MzkyLDcgQEAgc3RhdGljIHZvaWQgZ2VuOV9zc2V1X2RldmljZV9zdGF0dXMo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCQkJc3NldS0+c3Vic2xpY2Vz X21hc2tbc10gPQo+ICAgCQkJCUlOVEVMX0lORk8oZGV2X3ByaXYpLT5zc2V1LnN1YnNsaWNlc19t YXNrW3NdOwo+ICAgCj4gLQkJZm9yIChzcyA9IDA7IHNzIDwgc3NfbWF4OyBzcysrKSB7Cj4gKwkJ Zm9yIChzcyA9IDA7IHNzIDwgaW5mby0+c3NldS5tYXhfc3Vic2xpY2VzOyBzcysrKSB7Cj4gICAJ CQl1bnNpZ25lZCBpbnQgZXVfY250Owo+ICAgCj4gICAJCQlpZiAoSVNfR0VOOV9MUChkZXZfcHJp dikpIHsKPiAKCldpdGggdGhlIGZvcm1hdHRpbmcgdHdlYWtzLAoKUmV2aWV3ZWQtYnk6IFR2cnRr byBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+CgpSZWdhcmRzLAoKVHZydGtvCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=