From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v3] drm/i915: Handle RC6 counter wrap Date: Thu, 8 Feb 2018 14:31:05 +0000 Message-ID: <70c6d804-7f2d-e220-f52d-17062d137710@linux.intel.com> References: <151807682017.28809.17040553218386245341@mail.alporthouse.com151807682017.28809.17040553218386245341@mail.alporthouse.com> <20180208081842.6190-1-tvrtko.ursulin@linux.intel.com> <20180208140622.GB5453@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id ECF496E633 for ; Thu, 8 Feb 2018 14:31:07 +0000 (UTC) In-Reply-To: <20180208140622.GB5453@intel.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA4LzAyLzIwMTggMTQ6MDYsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPiBPbiBUaHUsIEZl YiAwOCwgMjAxOCBhdCAwODoxODo0MkFNICswMDAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4g RnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPj4KPj4gV2Ug Y2FuIGltcGxlbWVudCBsaW1pdGVkIFJDNiBjb3VudGVyIHdyYXAtYXJvdW5kIHByb3RlY3Rpb24g dW5kZXIgdGhlCj4+IGFzc3VtcHRpb24gdGhhdCBjbGllbnRzIHdpbGwgYmUgcmVhZGluZyB0aGlz IHZhbHVlIG1vcmUgZnJlcXVlbnRseSB0aGFuCj4+IHRoZSB3cmFwIHBlcmlvZCBvbiBhIGdpdmVu IHBsYXRmb3JtLgo+Pgo+PiBXaXRoIHRoZSB0eXBpY2FsIHdyYXAtYXJvdW5kIHBlcmlvZCBiZWlu ZyB+OTAgbWludXRlcywgZXZlbiB3aXRoIHRoZQo+PiBleGNlcHRpb24gb2YgQmF5dHJhaWwgd2hp Y2ggd3JhcHMgZXZlcnkgMTMgc2Vjb25kcywgdGhpcyBzb3VuZHMgbGlrZSBhCj4+IHJlYXNvbmFi bGUgYXNzdW1wdGlvbi4KPj4KPj4gSW1wbGVtZW50YXRpb24gd29ya3MgYnkgc3RvcmluZyBhIDY0 LWJpdCBzb2Z0d2FyZSBjb3B5IG9mIGEgaGFyZHdhcmUgUkM2Cj4+IGNvdW50ZXIsIGFsb25nIHdp dGggdGhlIHByZXZpb3VzIEhXIGNvdW50ZXIgc25hcHNob3QuIFRoaXMgZW5hYmxlcyBpdCB0bwo+ PiBkZXRlY3Qgd3JhcCBpcyBwb2xsZWQgZnJlcXVlbnRseSBlbm91Z2ggYW5kIGtlZXAgdGhlIHNv ZnR3YXJlIGNvcHkKPj4gbW9ub3RvbmljYWxseSBpbmNyZW1lbnRpbmcuCj4+Cj4+IHYyOgo+PiAg ICogTWlzc2VkIEdFTjZfR1RfR0ZYX1JDNl9MT0NLRUQgd2hlbiBjb25zaWRlcmluZyBzbG90IHNp emluZyBhbmQKPj4gICAgIGluZGV4aW5nLgo+PiAgICogRml4ZWQgb2ZmLWJ5LW9uZSBpbiB3cmFw LWFyb3VuZCBoYW5kbGluZy4gKENocmlzIFdpbHNvbikKPj4KPj4gdjM6Cj4+ICAgKiBTaW1wbGlm eSBpbmRleCBjaGVja2luZyBieSB1c2luZyB1bnNpZ25lZCBpbnQuIChDaHJpcyBXaWxzb24pCj4+ ICAgKiBFeHBhbmQgdGhlIGNvbW1lbnQgdG8gZXhwbGFpbiB3aHkgaW5kZXhpbmcgd29ya3MuCj4+ Cj4+IFNpZ25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5j b20+Cj4+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNn aT9pZD05NDg1Mgo+PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+ Cj4+IFJldmlld2VkLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4K Pj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCB8ICAyICsrCj4+ICAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyB8IDYyICsrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrLS0tLS0tCj4+ICAgMiBmaWxlcyBjaGFuZ2VkLCA1NSBpbnNlcnRpb25z KCspLCA5IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4gaW5kZXgg YWQxZmM4NDVjZDFiLi4yOGEyNjcxYTI2YzcgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZHJ2LmgKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYu aAo+PiBAQCAtOTQ2LDYgKzk0Niw4IEBAIHN0cnVjdCBpbnRlbF9ycHMgewo+PiAgIAo+PiAgIHN0 cnVjdCBpbnRlbF9yYzYgewo+PiAgIAlib29sIGVuYWJsZWQ7Cj4+ICsJdTY0IHByZXZfaHdfcmVz aWRlbmN5WzRdOwo+PiArCXU2NCBjdXJfcmVzaWRlbmN5WzRdOwo+PiAgIH07Cj4+ICAgCj4+ICAg c3RydWN0IGludGVsX2xsY19wc3RhdGUgewo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPj4gaW5k ZXggNDFmMjZhYjQ2NTAxLi4wNjNjODg1MTc1ZTcgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3BtLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cG0uYwo+PiBAQCAtOTQxNywxNSArOTQxNywxNiBAQCBzdGF0aWMgdTY0IHZsdl9yZXNpZGVuY3lf cmF3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gICAJCQkgICAgIGNvbnN0 IGk5MTVfcmVnX3QgcmVnKQo+PiAgIHsKPj4gICAJdTMyIGxvd2VyLCB1cHBlciwgdG1wOwo+PiAt CXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4+ICAgCWludCBsb29wID0gMjsKPj4gICAKPj4gLQkvKiBU aGUgcmVnaXN0ZXIgYWNjZXNzZWQgZG8gbm90IG5lZWQgZm9yY2V3YWtlLiBXZSBib3Jyb3cKPj4g KwkvKgo+PiArCSAqIFRoZSByZWdpc3RlciBhY2Nlc3NlZCBkbyBub3QgbmVlZCBmb3JjZXdha2Uu IFdlIGJvcnJvdwo+PiAgIAkgKiB1bmNvcmUgbG9jayB0byBwcmV2ZW50IGNvbmN1cnJlbnQgYWNj ZXNzIHRvIHJhbmdlIHJlZy4KPj4gICAJICovCj4+IC0Jc3Bpbl9sb2NrX2lycXNhdmUoJmRldl9w cml2LT51bmNvcmUubG9jaywgZmxhZ3MpOwo+PiArCWxvY2tkZXBfYXNzZXJ0X2hlbGQoJmRldl9w cml2LT51bmNvcmUubG9jayk7Cj4+ICAgCj4+IC0JLyogdmx2IGFuZCBjaHYgcmVzaWRlbmN5IGNv dW50ZXJzIGFyZSA0MCBiaXRzIGluIHdpZHRoLgo+PiArCS8qCj4+ICsJICogdmx2IGFuZCBjaHYg cmVzaWRlbmN5IGNvdW50ZXJzIGFyZSA0MCBiaXRzIGluIHdpZHRoLgo+PiAgIAkgKiBXaXRoIGEg Y29udHJvbCBiaXQsIHdlIGNhbiBjaG9vc2UgYmV0d2VlbiB1cHBlciBvciBsb3dlcgo+PiAgIAkg KiAzMmJpdCB3aW5kb3cgaW50byB0aGlzIGNvdW50ZXIuCj4+ICAgCSAqCj4+IEBAIC05NDQ5LDI5 ICs5NDUwLDQ5IEBAIHN0YXRpYyB1NjQgdmx2X3Jlc2lkZW5jeV9yYXcoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2LAo+PiAgIAkJdXBwZXIgPSBJOTE1X1JFQURfRlcocmVnKTsKPj4g ICAJfSB3aGlsZSAodXBwZXIgIT0gdG1wICYmIC0tbG9vcCk7Cj4+ICAgCj4+IC0JLyogRXZlcnl3 aGVyZSBlbHNlIHdlIGFsd2F5cyB1c2UgVkxWX0NPVU5URVJfQ09OVFJPTCB3aXRoIHRoZQo+PiAr CS8qCj4+ICsJICogRXZlcnl3aGVyZSBlbHNlIHdlIGFsd2F5cyB1c2UgVkxWX0NPVU5URVJfQ09O VFJPTCB3aXRoIHRoZQo+PiAgIAkgKiBWTFZfQ09VTlRfUkFOR0VfSElHSCBiaXQgc2V0IC0gc28g aXQgaXMgc2FmZSB0byBsZWF2ZSBpdCBzZXQKPj4gICAJICogbm93Lgo+PiAgIAkgKi8KPj4gICAK Pj4gLQlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZkZXZfcHJpdi0+dW5jb3JlLmxvY2ssIGZsYWdz KTsKPj4gLQo+PiAgIAlyZXR1cm4gbG93ZXIgfCAodTY0KXVwcGVyIDw8IDg7Cj4+ICAgfQo+PiAg IAo+PiAgIHU2NCBpbnRlbF9yYzZfcmVzaWRlbmN5X25zKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwKPj4gICAJCQkgICBjb25zdCBpOTE1X3JlZ190IHJlZykKPj4gICB7Cj4+IC0J dTY0IHRpbWVfaHc7Cj4+ICsJdTY0IHRpbWVfaHcsIHByZXZfaHcsIG92ZXJmbG93X2h3Owo+PiAr CXVuc2lnbmVkIGludCBmd19kb21haW5zOwo+PiArCXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4+ICsJ dW5zaWduZWQgaW50IGk7Cj4+ICAgCXUzMiBtdWwsIGRpdjsKPj4gICAKPj4gICAJaWYgKCFIQVNf UkM2KGRldl9wcml2KSkKPj4gICAJCXJldHVybiAwOwo+PiAgIAo+PiArCS8qCj4+ICsJICogU3Rv cmUgcHJldmlvdXMgaHcgY291bnRlciB2YWx1ZXMgZm9yIGNvdW50ZXIgd3JhcC1hcm91bmQgaGFu ZGxpbmcuCj4+ICsJICoKPj4gKwkgKiBUaGVyZSBhcmUgb25seSBmb3VyIGludGVyZXN0aW5nIHJl Z2lzdGVycyBhbmQgdGhleSBsaXZlIG5leHQgdG8gZWFjaAo+PiArCSAqIG90aGVyIHNvIHdlIGNh biB1c2UgdGhlIHJlbGF0aXZlIGFkZHJlc3MsIGNvbXBhcmVkIHRvIHRoZSBzbWFsbGVzdAo+PiAr CSAqIG9uZSBhcyB0aGUgaW5kZXggaW50byBkcml2ZXIgc3RvcmFnZS4KPj4gKwkgKi8KPj4gKwlp ID0gKGk5MTVfbW1pb19yZWdfb2Zmc2V0KHJlZykgLQo+PiArCSAgICAgaTkxNV9tbWlvX3JlZ19v ZmZzZXQoR0VONl9HVF9HRlhfUkM2X0xPQ0tFRCkpIC8gc2l6ZW9mKHUzMik7Cj4+ICsJaWYgKFdB Uk5fT05fT05DRShpID49IEFSUkFZX1NJWkUoZGV2X3ByaXYtPmd0X3BtLnJjNi5jdXJfcmVzaWRl bmN5KSkpCj4+ICsJCXJldHVybiAwOwo+PiArCj4+ICsJZndfZG9tYWlucyA9IGludGVsX3VuY29y ZV9mb3JjZXdha2VfZm9yX3JlZyhkZXZfcHJpdiwgcmVnLCBGV19SRUdfUkVBRCk7Cj4+ICsKPj4g KwlzcGluX2xvY2tfaXJxc2F2ZSgmZGV2X3ByaXYtPnVuY29yZS5sb2NrLCBmbGFncyk7Cj4+ICsJ aW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9nZXRfX2xvY2tlZChkZXZfcHJpdiwgZndfZG9tYWlucyk7 Cj4+ICsKPj4gICAJLyogT24gVkxWIGFuZCBDSFYsIHJlc2lkZW5jeSB0aW1lIGlzIGluIENaIHVu aXRzIHJhdGhlciB0aGFuIDEuMjh1cyAqLwo+PiAgIAlpZiAoSVNfVkFMTEVZVklFVyhkZXZfcHJp dikgfHwgSVNfQ0hFUlJZVklFVyhkZXZfcHJpdikpIHsKPj4gICAJCW11bCA9IDEwMDAwMDA7Cj4+ ICAgCQlkaXYgPSBkZXZfcHJpdi0+Y3pjbGtfZnJlcTsKPj4gKwkJb3ZlcmZsb3dfaHcgPSBCSVRf VUxMKDQwKTsKPj4gICAJCXRpbWVfaHcgPSB2bHZfcmVzaWRlbmN5X3JhdyhkZXZfcHJpdiwgcmVn KTsKPj4gICAJfSBlbHNlIHsKPj4gICAJCS8qIDgzMy4zM25zIHVuaXRzIG9uIEdlbjlMUCwgMS4y OHVzIGVsc2V3aGVyZS4gKi8KPj4gQEAgLTk0ODMsOSArOTUwNCwzMiBAQCB1NjQgaW50ZWxfcmM2 X3Jlc2lkZW5jeV9ucyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+ICAgCQkJ ZGl2ID0gMTsKPj4gICAJCX0KPj4gICAKPj4gLQkJdGltZV9odyA9IEk5MTVfUkVBRChyZWcpOwo+ PiArCQlvdmVyZmxvd19odyA9IEJJVF9VTEwoMzIpOwo+PiArCQl0aW1lX2h3ID0gSTkxNV9SRUFE X0ZXKHJlZyk7Cj4+ICAgCX0KPj4gICAKPj4gKwkvKgo+PiArCSAqIENvdW50ZXIgd3JhcCBoYW5k bGluZy4KPj4gKwkgKgo+PiArCSAqIEJ1dCByZWx5aW5nIG9uIGEgc3VmZmljaWVudCBmcmVxdWVu Y3kgb2YgcXVlcmllcyBvdGhlcndpc2UgY291bnRlcnMKPj4gKwkgKiBjYW4gc3RpbGwgd3JhcC4K Pj4gKwkgKi8KPj4gKwlwcmV2X2h3ID0gZGV2X3ByaXYtPmd0X3BtLnJjNi5wcmV2X2h3X3Jlc2lk ZW5jeVtpXTsKPj4gKwlkZXZfcHJpdi0+Z3RfcG0ucmM2LnByZXZfaHdfcmVzaWRlbmN5W2ldID0g dGltZV9odzsKPj4gKwo+PiArCS8qIFJDNiBkZWx0YSBmcm9tIGxhc3Qgc2FtcGxlLiAqLwo+PiAr CWlmICh0aW1lX2h3ID49IHByZXZfaHcpCj4+ICsJCXRpbWVfaHcgLT0gcHJldl9odzsKPj4gKwll bHNlCj4+ICsJCXRpbWVfaHcgKz0gb3ZlcmZsb3dfaHcgLSBwcmV2X2h3Owo+PiArCj4+ICsJLyog QWRkIGRlbHRhIHRvIFJDNiBleHRlbmRlZCByYXcgZHJpdmVyIGNvcHkuICovCj4+ICsJdGltZV9o dyArPSBkZXZfcHJpdi0+Z3RfcG0ucmM2LmN1cl9yZXNpZGVuY3lbaV07Cj4+ICsJZGV2X3ByaXYt Pmd0X3BtLnJjNi5jdXJfcmVzaWRlbmN5W2ldID0gdGltZV9odzsKPj4gKwo+PiArCWludGVsX3Vu Y29yZV9mb3JjZXdha2VfcHV0X19sb2NrZWQoZGV2X3ByaXYsIGZ3X2RvbWFpbnMpOwo+PiArCXNw aW5fdW5sb2NrX2lycXJlc3RvcmUoJmRldl9wcml2LT51bmNvcmUubG9jaywgZmxhZ3MpOwo+PiAr Cj4+ICAgCXJldHVybiBESVZfUk9VTkRfVVBfVUxMKHRpbWVfaHcgKiBtdWwsIGRpdik7Cj4gCj4g V2hhdCBoYXBwZW5zIHdoZW4gdGltZV9odyptdWwrZGl2LTEgb3ZlcmZsb3dzPwoKSXQgb3ZlcmZs b3dzLiA6SQoKQXBhcnQgb24gVmFsbGV5dmlldyBtdWx0aXBsZXIgaXMgMTQgYml0cyBtYXgsIHNv IHdlIHN0aWxsIGdldCA2NCAtIDE0IC0gCjEgPSA0OSBiaXRzIG9mIHNvZnR3YXJlIHN0b3JlZCBS QzYgYmVmb3JlIGl0IGhhcHBlbnMuIEdpdmVuIHRoYXQgdGhlIAppbmZvIGlmIDMyLWJpdHMgaXMg NTAgbWludXRlcyBvciBzbywgNDkgYml0cyBzb3VuZHMgZ29vZCBlbm91Z2guCgpPbiBWYWxsZXl2 aWV3IG11bHRpcGxpZXIgaXMgMjAgYml0cyBzbyA2NCAtIDIwIC0gMSA9IDQzIGJpdHMgYmVmb3Jl IApvdmVyZmxvdy4gQSBiaXQgbGVzcyB0aGFuIGFib3ZlLCBhbmQgSSBhbSBub3Qgc3VyZSB3aGF0 IHRoZSA0MC1iaXQgaHcgCmNvdW50ZXIgb3ZlcmZsb3cgcGVyaW9kIGlzIHRoZXJlIHRvIHN0YXJ0 IHdpdGg/IElzIDggdGltZXMgdGhhdCBlbm91Z2g/IApPciBub3Q/CgpTdWdnZXN0aW9ucz8KClJl Z2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==