public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Tomeu Vizoso <tomeu@tomeuvizoso.net>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] lib: Add basic support for valgrind annotations.
Date: Thu, 9 Feb 2017 11:03:13 +0100	[thread overview]
Message-ID: <72e6c769-3203-1ea7-ebb5-5760048e81a2@linux.intel.com> (raw)
In-Reply-To: <CAAObsKCUDzCe21y82venkcUMzMTLVVcop5exWjsmYwb=mf-=Sg@mail.gmail.com>

Hey,

Op 09-02-17 om 10:59 schreef Tomeu Vizoso:
> Patch looks good to me, but I think the signal changes should be in
> their own commit.
>
> On 7 February 2017 at 16:12, Maarten Lankhorst
> <maarten.lankhorst@linux.intel.com> wrote:
> ...
>> +#define VG(x) x
>> +#else
>> +#define VG(x)
>> +#endif
> Wouldn't be better to stub VALGRIND_MAKE_MEM_DEFINED instead?
This patch is slightly incomplete, after doing some tests it turns out we need to add a gem_munmap function too, which calls
VALGRIND_MAKE_MEM_NOACCESS. I only converted lib/ to use gem_munmap tests need to be fixed too.

So that's 2 at least.

~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-02-09 10:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 15:12 [PATCH i-g-t] lib: Add basic support for valgrind annotations Maarten Lankhorst
2017-02-09  9:59 ` Tomeu Vizoso
2017-02-09 10:03   ` Maarten Lankhorst [this message]
2017-02-09 10:09   ` [PATCH v2 " Maarten Lankhorst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72e6c769-3203-1ea7-ebb5-5760048e81a2@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tomeu@tomeuvizoso.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox