From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Lisovskiy, Stanislav" Subject: Re: [PATCH v14 2/2] drm/i915: Allow "max bpc" property to limit pipe_bpp Date: Mon, 15 Oct 2018 07:54:42 +0000 Message-ID: <745b2fa988a69cb4f458d5b945ecd402fd3200e5.camel@intel.com> References: <20181012184233.29250-1-radhakrishna.sripada@intel.com> <20181012184233.29250-2-radhakrishna.sripada@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181012184233.29250-2-radhakrishna.sripada@intel.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Sripada, Radhakrishna" , "intel-gfx@lists.freedesktop.org" Cc: "daniel.vetter@ffwll.ch" , "Kadiyala, Kishore" , "dri-devel@lists.freedesktop.org" , "Vivi, Rodrigo" List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAyMDE4LTEwLTEyIGF0IDExOjQyIC0wNzAwLCBSYWRoYWtyaXNobmEgU3JpcGFkYSB3 cm90ZToNCj4gVXNlIHRoZSBuZXdseSBhZGRlZCAibWF4IGJwYyIgY29ubmVjdG9yIHByb3BlcnR5 IHRvIGxpbWl0IHBpcGUgYnBwLg0KPiANCj4gVjM6IFVzZSBkcm1fY29ubmVjdG9yX3N0YXRlIHRv IGFjY2VzcyB0aGUgIm1heCBicGMiIHByb3BlcnR5DQo+IFY0OiBJbml0aWFsaXplIHRoZSBkcm0g cHJvcGVydHksIGFkZCBzdXVwb3J0IHRvIERQKFZpbGxlKQ0KPiBWNTogVXNlIHRoZSBwcm9wZXJ0 eSBpbiB0aGUgY29ubmVjdG9yIGFuZCBmaXggQ0kgZmFpbHVyZShWaWxsZSkNCj4gVjY6IFVzZSB0 aGUgY29yZSBmdW5jdGlvbiB0byBhdHRhY2ggbWF4X2JwYyBwcm9wZXJ0eSwgcmVtb3ZlIHRoZQ0K PiByZWR1bmRhbnQNCj4gICAgIGNsYW1waW5nIG9mIHBpcGUgYnBwIGJhc2VkIG9uIGNvbm5lY3Rv ciBpbmZvDQo+IFY3OiBGaXggQ2hlY2twYXRjaCB3YXJuaW5ncw0KPiBWOTogQ2xlYW51cCBjb25u ZWN0ZWRfc2lua19tYXhfYnBwIGFuZCBmaXggaW5pdGlhbCB2YWx1ZSBpbiBEUChWaWxsZSkNCj4g VjEyOiBGaXggZGVidWcgbWVzc2FnZShWaWxsZSkNCj4gVjEzOiBSZW1vdmUgdGhlIHJlZHVuZGFu dCBjaGVjayBhbmQgc2ltcGxpZnkgdGhlIGNoZWNrIGxvZ2ljKFN0YW4pDQo+IFYxNDogRml4IHRo ZSBjaGVjayBpbiBjb25uZWN0ZWRfc2lua19tYXhfYnBwKFN0YW4pDQo+IA0KPiBDYzogVmlsbGUg U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4NCj4gQ2M6IERhbmllbCBW ZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+DQo+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJp Z28udml2aUBpbnRlbC5jb20+DQo+IENjOiBLaXNob3JlIEthZGl5YWxhIDxraXNob3JlLmthZGl5 YWxhQGludGVsLmNvbT4NCj4gQ2M6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRl bC5jb20+DQo+IENjOiBTdGFuaXNsYXYgTGlzb3Zza2l5IDxzdGFuaXNsYXYubGlzb3Zza2l5QGlu dGVsLmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogUmFkaGFrcmlzaG5hIFNyaXBhZGEgPHJhZGhha3Jp c2huYS5zcmlwYWRhQGludGVsLmNvbT4NCj4gLS0tDQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMgfCA0OSArKysrKysrKysrKysrKysrKysrKy0tLS0NCj4gLS0tLS0tLS0t LS0tDQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jICAgICAgfCAgNCArKysNCj4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2hkbWkuYyAgICB8ICA1ICsrKysNCj4gIDMgZmls ZXMgY2hhbmdlZCwgMzcgaW5zZXJ0aW9ucygrKSwgMjEgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jDQo+IGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jDQo+IGluZGV4IDk4MGY0ZWE2OGU0OC4uZGRj YjdkYTNhNGUxIDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMNCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jDQo+IEBA IC0xMDc5MSwzMCArMTA3OTEsMzcgQEAgc3RhdGljIHZvaWQNCj4gaW50ZWxfbW9kZXNldF91cGRh dGVfY29ubmVjdG9yX2F0b21pY19zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQ0KPiAgCWRy bV9jb25uZWN0b3JfbGlzdF9pdGVyX2VuZCgmY29ubl9pdGVyKTsNCj4gIH0NCj4gIA0KPiAtc3Rh dGljIHZvaWQNCj4gLWNvbm5lY3RlZF9zaW5rX2NvbXB1dGVfYnBwKHN0cnVjdCBpbnRlbF9jb25u ZWN0b3IgKmNvbm5lY3RvciwNCj4gLQkJCSAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBl X2NvbmZpZykNCj4gK3N0YXRpYyBpbnQNCj4gK2Nvbm5lY3RlZF9zaW5rX21heF9icHAoY29uc3Qg c3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGUsDQo+ICsJCSAgICAgICBzdHJ1 Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcpDQo+ICB7DQo+IC0JY29uc3Qgc3RydWN0 IGRybV9kaXNwbGF5X2luZm8gKmluZm8gPSAmY29ubmVjdG9yLQ0KPiA+YmFzZS5kaXNwbGF5X2lu Zm87DQo+IC0JaW50IGJwcCA9IHBpcGVfY29uZmlnLT5waXBlX2JwcDsNCj4gKwlpbnQgYnBwOw0K PiArCXN0cnVjdCBkcm1fZGlzcGxheV9pbmZvICppbmZvID0gJmNvbm5fc3RhdGUtPmNvbm5lY3Rv ci0NCj4gPmRpc3BsYXlfaW5mbzsNCj4gIA0KPiAtCURSTV9ERUJVR19LTVMoIltDT05ORUNUT1I6 JWQ6JXNdIGNoZWNraW5nIGZvciBzaW5rIGJwcA0KPiBjb25zdHJhaW5zXG4iLA0KPiAtCQkgICAg ICBjb25uZWN0b3ItPmJhc2UuYmFzZS5pZCwNCj4gLQkJICAgICAgY29ubmVjdG9yLT5iYXNlLm5h bWUpOw0KPiAtDQo+IC0JLyogRG9uJ3QgdXNlIGFuIGludmFsaWQgRURJRCBicGMgdmFsdWUgKi8N Cj4gLQlpZiAoaW5mby0+YnBjICE9IDAgJiYgaW5mby0+YnBjICogMyA8IGJwcCkgew0KPiAtCQlE Uk1fREVCVUdfS01TKCJjbGFtcGluZyBkaXNwbGF5IGJwcCAod2FzICVkKSB0byBFRElEDQo+IHJl cG9ydGVkIG1heCBvZiAlZFxuIiwNCj4gLQkJCSAgICAgIGJwcCwgaW5mby0+YnBjICogMyk7DQo+ IC0JCXBpcGVfY29uZmlnLT5waXBlX2JwcCA9IGluZm8tPmJwYyAqIDM7DQo+ICsJc3dpdGNoIChj b25uX3N0YXRlLT5tYXhfYnBjKSB7DQo+ICsJY2FzZSA2IC4uLiA3Og0KPiArCQlicHAgPSA2ICog MzsNCj4gKwljYXNlIDggLi4uIDk6DQo+ICsJCWJwcCA9IDggKiAzOw0KPiArCQlicmVhazsNCj4g KwljYXNlIDEwIC4uLiAxMToNCj4gKwkJYnBwID0gMTAgKiAzOw0KPiArCQlicmVhazsNCj4gKwlj YXNlIDEyOg0KPiArCQlicHAgPSAxMiAqIDM7DQo+ICsJCWJyZWFrOw0KPiArCWRlZmF1bHQ6DQo+ ICsJCXJldHVybiAtRUlOVkFMOw0KPiAgCX0NCg0KU29ycnksIGJ1dCBvbmUgbW9yZSBjb21tZW50 KGp1c3Qgd2FudGVkIHRvIGdpdmUgInJldmlld2VkLWJ5IiBhbmQNCm5vdGljZWQgdGhpcyk6IHRo ZXJlIGlzIG1pc3NpbmcgYnJlYWsgaGVyZSwgYWZ0ZXIgY2FzZSA2IC4uIDcuDQoNCj4gIA0KPiAt CS8qIENsYW1wIGJwcCB0byA4IG9uIHNjcmVlbnMgd2l0aG91dCBFRElEIDEuNCAqLw0KPiAtCWlm IChpbmZvLT5icGMgPT0gMCAmJiBicHAgPiAyNCkgew0KPiAtCQlEUk1fREVCVUdfS01TKCJjbGFt cGluZyBkaXNwbGF5IGJwcCAod2FzICVkKSB0bw0KPiBkZWZhdWx0IGxpbWl0IG9mIDI0XG4iLA0K PiAtCQkJICAgICAgYnBwKTsNCj4gLQkJcGlwZV9jb25maWctPnBpcGVfYnBwID0gMjQ7DQo+ICsJ aWYgKGJwcCA8IHBpcGVfY29uZmlnLT5waXBlX2JwcCkgew0KPiArCQlEUk1fREVCVUdfS01TKCJM aW1pdGluZyBkaXNwbGF5IGJwcCB0byAlZCBpbnN0ZWFkIG9mDQo+IEVkaWQgYnBwICINCj4gKwkJ CSAgICAgICIlZCwgcmVxdWVzdGVkIGJwcCAlZCwgbWF4IHBsYXRmb3JtDQo+IGJwcCAlZFxuIiwg YnBwLA0KPiArCQkJICAgICAgMyAqIGluZm8tPmJwYywgMyAqIGNvbm5fc3RhdGUtDQo+ID5tYXhf cmVxdWVzdGVkX2JwYywNCj4gKwkJCSAgICAgIHBpcGVfY29uZmlnLT5waXBlX2JwcCk7DQo+ICsJ CXBpcGVfY29uZmlnLT5waXBlX2JwcCA9IGJwcDsNCj4gIAl9DQo+ICsJcmV0dXJuIDA7DQo+ICB9 DQo+ICANCj4gIHN0YXRpYyBpbnQNCj4gQEAgLTEwODQ1LDggKzEwODUyLDggQEAgY29tcHV0ZV9i YXNlbGluZV9waXBlX2JwcChzdHJ1Y3QgaW50ZWxfY3J0Yw0KPiAqY3J0YywNCj4gIAkJaWYgKGNv bm5lY3Rvcl9zdGF0ZS0+Y3J0YyAhPSAmY3J0Yy0+YmFzZSkNCj4gIAkJCWNvbnRpbnVlOw0KPiAg DQo+IC0JCWNvbm5lY3RlZF9zaW5rX2NvbXB1dGVfYnBwKHRvX2ludGVsX2Nvbm5lY3Rvcihjb25u ZWMNCj4gdG9yKSwNCj4gLQkJCQkJICAgcGlwZV9jb25maWcpOw0KPiArCQlpZiAoY29ubmVjdGVk X3NpbmtfbWF4X2JwcChjb25uZWN0b3Jfc3RhdGUsDQo+IHBpcGVfY29uZmlnKSA8IDApDQo+ICsJ CQlyZXR1cm4gLUVJTlZBTDsNCj4gIAl9DQo+ICANCj4gIAlyZXR1cm4gYnBwOw0KPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYw0KPiBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RwLmMNCj4gaW5kZXggMTNmZjg5YmU2YWQ2Li41ZjU5NDQzMGIyYTQgMTAw NjQ0DQo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMNCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYw0KPiBAQCAtNTczNSw2ICs1NzM1LDEwIEBAIGlu dGVsX2RwX2FkZF9wcm9wZXJ0aWVzKHN0cnVjdCBpbnRlbF9kcA0KPiAqaW50ZWxfZHAsIHN0cnVj dCBkcm1fY29ubmVjdG9yICpjb25uZWN0DQo+ICAJCWludGVsX2F0dGFjaF9mb3JjZV9hdWRpb19w cm9wZXJ0eShjb25uZWN0b3IpOw0KPiAgDQo+ICAJaW50ZWxfYXR0YWNoX2Jyb2FkY2FzdF9yZ2Jf cHJvcGVydHkoY29ubmVjdG9yKTsNCj4gKwlpZiAoSEFTX0dNQ0hfRElTUExBWShkZXZfcHJpdikp DQo+ICsJCWRybV9jb25uZWN0b3JfYXR0YWNoX21heF9icGNfcHJvcGVydHkoY29ubmVjdG9yLCA2 LA0KPiAxMCk7DQo+ICsJZWxzZSBpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA1KQ0KPiArCQlk cm1fY29ubmVjdG9yX2F0dGFjaF9tYXhfYnBjX3Byb3BlcnR5KGNvbm5lY3RvciwgNiwNCj4gMTIp Ow0KPiAgDQo+ICAJaWYgKGludGVsX2RwX2lzX2VkcChpbnRlbF9kcCkpIHsNCj4gIAkJdTMyIGFs bG93ZWRfc2NhbGVyczsNCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2hkbWkuYw0KPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2hkbWkuYw0KPiBpbmRleCAy YzUzZWZjNDYzZTYuLjMxNThhYjA4NWEzMCAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfaGRtaS5jDQo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2hk bWkuYw0KPiBAQCAtMjEwMywxMSArMjEwMywxNiBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9l bmNvZGVyX2Z1bmNzDQo+IGludGVsX2hkbWlfZW5jX2Z1bmNzID0gew0KPiAgc3RhdGljIHZvaWQN Cj4gIGludGVsX2hkbWlfYWRkX3Byb3BlcnRpZXMoc3RydWN0IGludGVsX2hkbWkgKmludGVsX2hk bWksIHN0cnVjdA0KPiBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IpDQo+ICB7DQo+ICsJc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjb25uZWN0b3ItPmRldik7DQo+ ICsNCj4gIAlpbnRlbF9hdHRhY2hfZm9yY2VfYXVkaW9fcHJvcGVydHkoY29ubmVjdG9yKTsNCj4g IAlpbnRlbF9hdHRhY2hfYnJvYWRjYXN0X3JnYl9wcm9wZXJ0eShjb25uZWN0b3IpOw0KPiAgCWlu dGVsX2F0dGFjaF9hc3BlY3RfcmF0aW9fcHJvcGVydHkoY29ubmVjdG9yKTsNCj4gIAlkcm1fY29u bmVjdG9yX2F0dGFjaF9jb250ZW50X3R5cGVfcHJvcGVydHkoY29ubmVjdG9yKTsNCj4gIAljb25u ZWN0b3ItPnN0YXRlLT5waWN0dXJlX2FzcGVjdF9yYXRpbyA9DQo+IEhETUlfUElDVFVSRV9BU1BF Q1RfTk9ORTsNCj4gKw0KPiArCWlmICghSEFTX0dNQ0hfRElTUExBWShkZXZfcHJpdikpDQo+ICsJ CWRybV9jb25uZWN0b3JfYXR0YWNoX21heF9icGNfcHJvcGVydHkoY29ubmVjdG9yLCA4LA0KPiAx Mik7DQo+ICB9DQo+ICANCj4gIC8qDQotLSANCkJlc3QgUmVnYXJkcywNCg0KTGlzb3Zza2l5IFN0 YW5pc2xhdgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK