From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 3/5] drm/i915: Call i915_pipe_update_start with uncore.lock held. Date: Mon, 12 Feb 2018 16:39:16 +0100 Message-ID: <75c049c5-64ce-ae65-32b8-560a3e3e182d@linux.intel.com> References: <20180209095404.76418-1-maarten.lankhorst@linux.intel.com> <20180209095404.76418-4-maarten.lankhorst@linux.intel.com> <151844879607.18923.15930170017428937869@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id D3B356E126 for ; Mon, 12 Feb 2018 15:39:18 +0000 (UTC) In-Reply-To: <151844879607.18923.15930170017428937869@mail.alporthouse.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMTItMDItMTggb20gMTY6MTkgc2NocmVlZiBDaHJpcyBXaWxzb246Cj4gUXVvdGluZyBNYWFy dGVuIExhbmtob3JzdCAoMjAxOC0wMi0wOSAwOTo1NDowMikKPj4gVGhpcyByZXF1aXJlcyBiZWlu ZyBhYmxlIHRvIHJlYWQgdGhlIHZibGFuayBjb3VudGVyIHdpdGggdGhlCj4+IHVuY29yZS5sb2Nr IGFscmVhZHkgaGVsZC4gVGhpcyBpcyBhbHNvIGEgcHJlcGFyYXRpb24gZm9yCj4+IGJlaW5nIGFi bGUgdG8gcnVuIHRoZSBlbnRpcmUgdmJsYW5rIHVwZGF0ZSBzZXF1ZW5jZSB3aXRoCj4+IHRoZSB1 bmNvcmUgbG9jayBoZWxkLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8 bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfaXJxLmMgICAgIHwgNjYgKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrLS0tLS0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV90cmFjZS5oICAgfCAgNSAr Ky0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgIHwgIDEgKwo+PiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgfCAgMyArLQo+PiAgNCBmaWxlcyBjaGFu Z2VkLCA2MCBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2lycS5jCj4+IGluZGV4IGVkYTk1NDNhMDE5OS4uNmM0OTFlNjNlMDdjIDEwMDY0NAo+PiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfaXJxLmMKPj4gQEAgLTczNiwxMyArNzM2LDEyIEBAIHN0YXRpYyB2b2lk IGk5MTVfZW5hYmxlX2FzbGVfcGlwZXN0YXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KQo+PiAgLyogQ2FsbGVkIGZyb20gZHJtIGdlbmVyaWMgY29kZSwgcGFzc2VkIGEgJ2NydGMn LCB3aGljaAo+PiAgICogd2UgdXNlIGFzIGEgcGlwZSBpbmRleAo+PiAgICovCj4+IC1zdGF0aWMg dTMyIGk5MTVfZ2V0X3ZibGFua19jb3VudGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2ln bmVkIGludCBwaXBlKQo+PiArc3RhdGljIHUzMiBfX2k5MTVfZ2V0X3ZibGFua19jb3VudGVyKHN0 cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+PiAgewo+PiAtICAgICAgIHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPj4gKyAgICAgICBzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNydGMtPmJhc2UuZGV2KTsKPj4gICAgICAg ICBpOTE1X3JlZ190IGhpZ2hfZnJhbWUsIGxvd19mcmFtZTsKPj4gICAgICAgICB1MzIgaGlnaDEs IGhpZ2gyLCBsb3csIHBpeGVsLCB2Ymxfc3RhcnQsIGhzeW5jX3N0YXJ0LCBodG90YWw7Cj4+IC0g ICAgICAgY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUgPSAmZGV2LT52Ymxhbmtb cGlwZV0uaHdtb2RlOwo+PiAtICAgICAgIHVuc2lnbmVkIGxvbmcgaXJxZmxhZ3M7Cj4+ICsgICAg ICAgY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUgPSAmY3J0Yy0+YmFzZS5kZXYt PnZibGFua1tjcnRjLT5waXBlXS5od21vZGU7Cj4gbG9ja2RlcF9hc3NlcnRfaGVsZCgmZGV2X3By aXYtPnVuY29yZS5sb2NrKTsKPgo+PiAgCj4+ICAgICAgICAgaHRvdGFsID0gbW9kZS0+Y3J0Y19o dG90YWw7Cj4+ICAgICAgICAgaHN5bmNfc3RhcnQgPSBtb2RlLT5jcnRjX2hzeW5jX3N0YXJ0Owo+ PiBAQCAtNzU2LDEwICs3NTUsOCBAQCBzdGF0aWMgdTMyIGk5MTVfZ2V0X3ZibGFua19jb3VudGVy KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBwaXBlKQo+PiAgICAgICAgIC8q IFN0YXJ0IG9mIHZibGFuayBldmVudCBvY2N1cnMgYXQgc3RhcnQgb2YgaHN5bmMgKi8KPj4gICAg ICAgICB2Ymxfc3RhcnQgLT0gaHRvdGFsIC0gaHN5bmNfc3RhcnQ7Cj4+ICAKPj4gLSAgICAgICBo aWdoX2ZyYW1lID0gUElQRUZSQU1FKHBpcGUpOwo+PiAtICAgICAgIGxvd19mcmFtZSA9IFBJUEVG UkFNRVBJWEVMKHBpcGUpOwo+PiAtCj4+IC0gICAgICAgc3Bpbl9sb2NrX2lycXNhdmUoJmRldl9w cml2LT51bmNvcmUubG9jaywgaXJxZmxhZ3MpOwo+PiArICAgICAgIGhpZ2hfZnJhbWUgPSBQSVBF RlJBTUUoY3J0Yy0+cGlwZSk7Cj4+ICsgICAgICAgbG93X2ZyYW1lID0gUElQRUZSQU1FUElYRUwo Y3J0Yy0+cGlwZSk7Cj4+ICAKPj4gICAgICAgICAvKgo+PiAgICAgICAgICAqIEhpZ2ggJiBsb3cg cmVnaXN0ZXIgZmllbGRzIGFyZW4ndCBzeW5jaHJvbml6ZWQsIHNvIG1ha2Ugc3VyZQo+PiBAQCAt NzcyLDggKzc2OSw2IEBAIHN0YXRpYyB1MzIgaTkxNV9nZXRfdmJsYW5rX2NvdW50ZXIoc3RydWN0 IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQgaW50IHBpcGUpCj4+ICAgICAgICAgICAgICAgICBo aWdoMiA9IEk5MTVfUkVBRF9GVyhoaWdoX2ZyYW1lKSAmIFBJUEVfRlJBTUVfSElHSF9NQVNLOwo+ PiAgICAgICAgIH0gd2hpbGUgKGhpZ2gxICE9IGhpZ2gyKTsKPj4gIAo+PiAtICAgICAgIHNwaW5f dW5sb2NrX2lycXJlc3RvcmUoJmRldl9wcml2LT51bmNvcmUubG9jaywgaXJxZmxhZ3MpOwo+PiAt Cj4+ICAgICAgICAgaGlnaDEgPj49IFBJUEVfRlJBTUVfSElHSF9TSElGVDsKPj4gICAgICAgICBw aXhlbCA9IGxvdyAmIFBJUEVfUElYRUxfTUFTSzsKPj4gICAgICAgICBsb3cgPj49IFBJUEVfRlJB TUVfTE9XX1NISUZUOwo+PiBAQCAtNzg2LDExICs3ODEsNjAgQEAgc3RhdGljIHUzMiBpOTE1X2dl dF92YmxhbmtfY291bnRlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlw ZSkKPj4gICAgICAgICByZXR1cm4gKCgoaGlnaDEgPDwgOCkgfCBsb3cpICsgKHBpeGVsID49IHZi bF9zdGFydCkpICYgMHhmZmZmZmY7Cj4+ICB9Cj4+ICAKPj4gK3N0YXRpYyB1MzIgaTkxNV9nZXRf dmJsYW5rX2NvdW50ZXIoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQgaW50IHBpcGUp Cj4+ICt7Cj4+ICsgICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9f aTkxNShkZXYpOwo+PiArICAgICAgIHVuc2lnbmVkIGxvbmcgaXJxZmxhZ3M7Cj4+ICsgICAgICAg dTMyIHJldDsKPj4gKwo+PiArICAgICAgIHNwaW5fbG9ja19pcnFzYXZlKCZkZXZfcHJpdi0+dW5j b3JlLmxvY2ssIGlycWZsYWdzKTsKPj4gKyAgICAgICByZXQgPSBpOTE1X2dldF92YmxhbmtfY291 bnRlcihkZXYsIHBpcGUpOwo+PiArICAgICAgIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmRldl9w cml2LT51bmNvcmUubG9jaywgaXJxZmxhZ3MpOwo+PiArCj4+ICsgICAgICAgcmV0dXJuIHJldDsK Pj4gK30KPj4gKwo+PiArc3RhdGljIHUzMiBfX2c0eF9nZXRfdmJsYW5rX2NvdW50ZXIoc3RydWN0 IGludGVsX2NydGMgKmNydGMpCj4+ICt7Cj4+ICsgICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2ID0gdG9faTkxNShjcnRjLT5iYXNlLmRldik7Cj4gbG9ja2RlcF9hc3NlcnRf aGVsZCgmZGV2X3ByaXYtPnVuY29yZS5sb2NrKTsgPwo+Cj4gT2ssIHdoeSBkbyB3ZSBuZWVkIHVu Y29yZS5sb2NrIGhlbGQgaGVyZSBhdCBhbGw/IFNlcmlhbGlzYXRpb24gb2YgbW1pbwo+IGFjY2Vz cyB0byB0aGUgc2FtZSBjYWNoZWxpbmUgaXMgdGhlIGFnZSBvbGQgcmVhc29uLCBjYW4gd2UgZ3Vh cmFudGVlCj4gdGhhdCBkb2Vzbid0IGhhcHBlbiBhbnl3YXk/IChQcm9iYWJseSBub3QsIGJ1dCBy ZWFsbHkgbW9zdCBjYWxsZXJzIGRvCj4gbm90IG5lZWQgdGhlIG1taW8gdy9hLikKCklzIHRoZSBz ZXJpYWxpemF0aW9uIG9ubHkgbmVlZGVkIGZvciB3cml0aW5nPwoKVGhlIG9ubHkgdGhpbmcgdGhh dCBjYW4gcmFjZSB3aXRoIG5vbmJsb2NraW5nIGF0b21pYyBjb21taXRzIGFyZSBsZWdhY3kKY3Vy c29yIHVwZGF0ZXMsIGJ1dCB0aG9zZSBjYW4gb25seSBoYXBwZW4gaWYgdGhlIGN1cnNvciBwbGFu ZSBhcmUgbm90IHBhcnQKb2YgdGhlIHByZXZpb3VzIGF0b21pYyBjb21taXQuIFRob3NlIGFyZSBh bHNvIHByb3RlY3RlZCBieSBwbGFuZS0+bXV0ZXgsCnNvIGluIHRoZW9yeSBzYW1lIGNhY2hlIGxp bmVzIG9uIHRoZSBzYW1lIHBpcGVzIHByb2JhYmx5IGNhbid0IHJhY2UuLgoKfk1hYXJ0ZW4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=