From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A900FC433F5 for ; Mon, 24 Jan 2022 11:23:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A3D010ED8A; Mon, 24 Jan 2022 11:23:28 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7E11F10ED4D; Mon, 24 Jan 2022 11:23:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643023406; x=1674559406; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=DmO5o1tSKywvbvIj51hbxGoHlz0HD9Cx4vDMYfINVaI=; b=bhq5tctPP6VUBklCFrEky387WLfWP/+YbPgE/wJuPpjit/KAin/d3pG3 gtxBRR6J8Gu2iBJlosfPtuwIggQlI2vc9OeJoaoDvwnAlHs/FVMprg8o2 O4RdopbUzNS5Ge6zBjMxM6EIsNMLOKm4WFKDIpbovxNie3sigHvrhTuiV Z4eerHyKfrT5xlhFko90IGgERsgBcVQfZXfM8OTq/MEsmGjXNA1z6USK6 6vpNstD49RzVZoG2KGtt8XbILqw/AE7jYr7rTNN47LeKlNnd4YL93eiN6 9EyBEKVmlrb8sckTNLlGRIS/t7zBsLMZdov1HjZHdWyx6F142OnebIU97 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10236"; a="306739111" X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="306739111" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2022 03:23:26 -0800 X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="695389755" Received: from rvanakke-mobl.ger.corp.intel.com (HELO [10.252.53.157]) ([10.252.53.157]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2022 03:23:24 -0800 Message-ID: <75c84bd3-8060-aed6-dafc-7bd50591ebb1@linux.intel.com> Date: Mon, 24 Jan 2022 12:23:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.5.0 Content-Language: en-US To: Andi Shyti , Intel GFX , DRI Devel References: <20220124094418.2661-1-andi.shyti@linux.intel.com> From: Maarten Lankhorst In-Reply-To: <20220124094418.2661-1-andi.shyti@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH v3] drm/i915: fix header file inclusion for might_alloc() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , Thomas Zimmermann Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Op 24-01-2022 om 10:44 schreef Andi Shyti: > Replace "linux/slab.h" with "linux/sched/mm.h" header inclusion > as the first is not required, while the second, if not included, > prodouces the following error: > > drivers/gpu/drm/i915/i915_vma_resource.c: In function ‘i915_vma_resource_bind_dep_await’: > drivers/gpu/drm/i915/i915_vma_resource.c:381:9: error: implicit declaration of function ‘might_alloc’; did you mean ‘might_lock’? [-Werror=implicit-function-declaration] > 381 | might_alloc(gfp); > | ^~~~~~~~~~~ > | might_lock > > Fixes: 2f6b90da9192 ("drm/i915: Use vma resources for async unbinding") > Signed-off-by: Andi Shyti > Cc: Thomas Hellström > Reviewed-by: Thomas Hellström > --- > Hi, > > v3: fixed a typo in the commit log (prduces/produces). (Thanks > Thomas Zimmermann) > > v2: added the 'Fixes' tag (I think I got the right commit) and > Thomas Hellström r-b. > > Andi > > drivers/gpu/drm/i915/i915_vma_resource.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_vma_resource.c b/drivers/gpu/drm/i915/i915_vma_resource.c > index 1f41c0c699eb..bbb0ff14272f 100644 > --- a/drivers/gpu/drm/i915/i915_vma_resource.c > +++ b/drivers/gpu/drm/i915/i915_vma_resource.c > @@ -4,7 +4,7 @@ > */ > > #include > -#include > +#include > > #include "i915_sw_fence.h" > #include "i915_vma_resource.h" Pushed to drm-intel-gt-next. Should fix drm-tip building, probably needs to be pulled into drm-fixes asap. :)