From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 1/4] drm/i915: Replace some open-coded i915_map_coherent_type() Date: Tue, 2 Oct 2018 12:48:39 +0100 Message-ID: <75d6ba1b-fc79-50b0-c539-e0cff2ec8820@linux.intel.com> References: <20181001194447.29910-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 848F16E2F3 for ; Tue, 2 Oct 2018 11:48:41 +0000 (UTC) In-Reply-To: <20181001194447.29910-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAxLzEwLzIwMTggMjA6NDQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBBIGZldyBjYWxsc2l0 ZXMgd2hlcmUgZGVjaWRpbmcgb24gdXNpbmcgV0Mgb3IgV0IgbWFwcyBiYXNlZCBvbgo+IEhBU19M TEMoKSwgc28gcmVwbGFjZSB0aGVtIHdpdGggdGhlIGVxdWl2YWxlbnQgaGVscGVyIGZ1bmN0aW9u Cj4gaTkxNV9tYXBfY29oZXJlbnRfdHlwZSgpLgo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdp bHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jICAgICAgICAgIHwgMyArLS0KPiAgIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L3NlbGZ0ZXN0cy9pbnRlbF9oYW5nY2hlY2suYyB8IDQgKystLQo+ICAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2ludGVsX2xyYy5jICAgICAgIHwgMiArLQo+ICAgMyBm aWxlcyBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+IGluZGV4IGMwOTJkNTA5OWViZi4uYjhh N2EwMTRkNDZkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Jpbmdi dWZmZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+ IEBAIC0xMDIzLDggKzEwMjMsNyBAQCBpOTE1X2VtaXRfYmJfc3RhcnQoc3RydWN0IGk5MTVfcmVx dWVzdCAqcnEsCj4gICBpbnQgaW50ZWxfcmluZ19waW4oc3RydWN0IGludGVsX3JpbmcgKnJpbmcp Cj4gICB7Cj4gICAJc3RydWN0IGk5MTVfdm1hICp2bWEgPSByaW5nLT52bWE7Cj4gLQllbnVtIGk5 MTVfbWFwX3R5cGUgbWFwID0KPiAtCQlIQVNfTExDKHZtYS0+dm0tPmk5MTUpID8gSTkxNV9NQVBf V0IgOiBJOTE1X01BUF9XQzsKPiArCWVudW0gaTkxNV9tYXBfdHlwZSBtYXAgPSBpOTE1X2NvaGVy ZW50X21hcF90eXBlKHZtYS0+dm0tPmk5MTUpOwo+ICAgCXVuc2lnbmVkIGludCBmbGFnczsKPiAg IAl2b2lkICphZGRyOwo+ICAgCWludCByZXQ7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L3NlbGZ0ZXN0cy9pbnRlbF9oYW5nY2hlY2suYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L3NlbGZ0ZXN0cy9pbnRlbF9oYW5nY2hlY2suYwo+IGluZGV4IGRiMzc4MjI2YWMxMC4uNTFkMGUy YmVkOWUxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pbnRl bF9oYW5nY2hlY2suYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pbnRl bF9oYW5nY2hlY2suYwo+IEBAIC03Niw3ICs3Niw3IEBAIHN0YXRpYyBpbnQgaGFuZ19pbml0KHN0 cnVjdCBoYW5nICpoLCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkKPiAgIAloLT5zZXFu byA9IG1lbXNldCh2YWRkciwgMHhmZiwgUEFHRV9TSVpFKTsKPiAgIAo+ICAgCXZhZGRyID0gaTkx NV9nZW1fb2JqZWN0X3Bpbl9tYXAoaC0+b2JqLAo+IC0JCQkJCUhBU19MTEMoaTkxNSkgPyBJOTE1 X01BUF9XQiA6IEk5MTVfTUFQX1dDKTsKPiArCQkJCQlpOTE1X2NvaGVyZW50X21hcF90eXBlKGk5 MTUpKTsKPiAgIAlpZiAoSVNfRVJSKHZhZGRyKSkgewo+ICAgCQllcnIgPSBQVFJfRVJSKHZhZGRy KTsKPiAgIAkJZ290byBlcnJfdW5waW5faHdzOwo+IEBAIC0yMzQsNyArMjM0LDcgQEAgaGFuZ19j cmVhdGVfcmVxdWVzdChzdHJ1Y3QgaGFuZyAqaCwgc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5n aW5lKQo+ICAgCQkJcmV0dXJuIEVSUl9DQVNUKG9iaik7Cj4gICAKPiAgIAkJdmFkZHIgPSBpOTE1 X2dlbV9vYmplY3RfcGluX21hcChvYmosCj4gLQkJCQkJCUhBU19MTEMoaC0+aTkxNSkgPyBJOTE1 X01BUF9XQiA6IEk5MTVfTUFQX1dDKTsKPiArCQkJCQkJaTkxNV9jb2hlcmVudF9tYXBfdHlwZSho LT5pOTE1KSk7Cj4gICAJCWlmIChJU19FUlIodmFkZHIpKSB7Cj4gICAJCQlpOTE1X2dlbV9vYmpl Y3RfcHV0KG9iaik7Cj4gICAJCQlyZXR1cm4gRVJSX0NBU1QodmFkZHIpOwo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9zZWxmdGVzdHMvaW50ZWxfbHJjLmMKPiBpbmRleCBjOGI3ZjAzYzM1YmQuLjlm MjQxZDFjNzJkYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMv aW50ZWxfbHJjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvaW50ZWxf bHJjLmMKPiBAQCAtNDksNyArNDksNyBAQCBzdGF0aWMgaW50IHNwaW5uZXJfaW5pdChzdHJ1Y3Qg c3Bpbm5lciAqc3Bpbiwgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4gICAJfQo+ICAg CXNwaW4tPnNlcW5vID0gbWVtc2V0KHZhZGRyLCAweGZmLCBQQUdFX1NJWkUpOwo+ICAgCj4gLQlt b2RlID0gSEFTX0xMQyhpOTE1KSA/IEk5MTVfTUFQX1dCIDogSTkxNV9NQVBfV0M7Cj4gKwltb2Rl ID0gaTkxNV9jb2hlcmVudF9tYXBfdHlwZShpOTE1KTsKPiAgIAl2YWRkciA9IGk5MTVfZ2VtX29i amVjdF9waW5fbWFwKHNwaW4tPm9iaiwgbW9kZSk7Cj4gICAJaWYgKElTX0VSUih2YWRkcikpIHsK PiAgIAkJZXJyID0gUFRSX0VSUih2YWRkcik7Cj4gCgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3Vs aW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==