From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH] drm/i915/vlv: Fix off-by-1 error in calculating num_levels. Date: Mon, 25 Jul 2016 14:46:01 +0200 Message-ID: <77076f1b-a757-eccf-fbae-d6638318f3df@linux.intel.com> References: <1466685388-16504-1-git-send-email-chix.ding@intel.com> <20160719152542.GN4329@intel.com> <20160719155049.GL17604@nuc-i3427.alporthouse.com> <20160719162132.GO4329@intel.com> <12173c41-da78-99df-dec6-33b41deab9db@linux.intel.com> <20160725115107.GC4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 5EE5C6E1F5 for ; Mon, 25 Jul 2016 12:46:03 +0000 (UTC) In-Reply-To: <20160725115107.GC4329@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: yetundex.adebisi@intel.com, isg-gms@eclists.intel.com, intel-gfx@lists.freedesktop.org, Chi Ding List-Id: intel-gfx@lists.freedesktop.org T3AgMjUtMDctMTYgb20gMTM6NTEgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gTW9uLCBK dWwgMjUsIDIwMTYgYXQgMDE6MzI6NDVQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IEhleSwKPj4KPj4gT3AgMTktMDctMTYgb20gMTg6MjEgc2NocmVlZiBWaWxsZSBTeXJqw6Rs w6Q6Cj4+PiBPbiBUdWUsIEp1bCAxOSwgMjAxNiBhdCAwNDo1MDo0OVBNICswMTAwLCBDaHJpcyBX aWxzb24gd3JvdGU6Cj4+Pj4gT24gVHVlLCBKdWwgMTksIDIwMTYgYXQgMDY6MjU6NDJQTSArMDMw MCwgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+Pj4+PiBPbiBUdWUsIEp1bCAxOSwgMjAxNiBhdCAw NToxNDoyM1BNICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToKPj4+Pj4+IG51bV9sZXZl bHMgc2hvdWxkIGJlIGxldmVsKzEsIG5vdCBsZXZlbCwgZWxzZSBudW1fbGV2ZWxzIC0gMSBiZWNv bWVzCj4+Pj4+PiBuZWdhdGl2ZS4gVGhpcyByZXN1bHRlZCBpbiBib2d1cyB3YXRlcm1hcmtzIGJl aW5nIHdyaXR0ZW4gdG8gdGhlIGZpcnN0Cj4+Pj4+PiAyNTUgbGV2ZWxzIGxpa2UgYmVsb3c6Cj4+ Pj4+Pgo+Pj4+Pj4gW2RybV0gU2V0dGluZyBGSUZPIHdhdGVybWFya3MgLSBDOiBwbGFuZT0wLCBj dXJzb3I9MCwgc3ByaXRlMD0wLCBzcHJpdGUxPTAsIFNSOiBwbGFuZT0wLCBjdXJzb3I9MCBsZXZl bD0yNTUgY3hzcj0wCj4+Pj4+PiBbZHJtOmNodl9zZXRfbWVtb3J5X2R2ZnMgW2k5MTVdXSAqRVJS T1IqIHRpbWVkIG91dCB3YWl0aW5nIGZvciBQdW5pdCBERFIgRFZGUyByZXF1ZXN0Cj4+Pj4+PiBb ZHJtOmludGVsX2NwdV9maWZvX3VuZGVycnVuX2lycV9oYW5kbGVyIFtpOTE1XV0gKkVSUk9SKiBD UFUgcGlwZSBDIEZJRk8gdW5kZXJydW4KPj4+Pj4+IFtkcm06Y2h2X3NldF9tZW1vcnlfZHZmcyBb aTkxNV1dICpFUlJPUiogdGltZWQgb3V0IHdhaXRpbmcgZm9yIFB1bml0IEREUiBEVkZTIHJlcXVl c3QKPj4+Pj4+Cj4+Pj4+PiBUZXN0Y2FzZToga21zX2F0b21pY190cmFuc2l0aW9uCj4+Pj4+PiBG aXhlczogMjYyY2QyZTE1NGMyICgiZHJtL2k5MTU6IENIViBERFIgRFZGUyBzdXBwb3J0IGFuZCBh bm90aGVyIHdhdGVybWFyayByZXdyaXRlIikKPj4+Pj4+IENjOiBzdGFibGVAdmdlci5rZXJuZWwu b3JnCj4+Pj4+PiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KPj4+Pj4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxh bmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4+Pj4+PiAtLS0KPj4+Pj4+IFVyZ2VudCBmaXggZm9y IHdhdGVybWFyayBzdXBwb3J0LiBUaGlzIGlzIGRlZmluaXRlbHkgYSBwcmUtcmVxdWlzaXRlIGZv ciB0aGlzIHNlcmllcy4KPj4+Pj4+IFdpdGggdGhpcyBJJ3ZlIG5vdGljZWQgdGhhdCBwYXRjaCAi W1JGQyAzLzhdIGRybS9pOTE1L3ZsdjogTW92ZSBmaWZvX3NpemUgZnJvbQo+Pj4+Pj4gaW50ZWxf cGxhbmVfd21fcGFyYW1ldGVycyB0byB2bHZfd21fc3RhdGUiIGludHJvZHVjZXMgYSByZWdyZXNz aW9uIHdpdGggaW52YWxpZCBGSUZPIHNwbGl0Lgo+Pj4+Pj4KPj4+Pj4+IEkgbmVlZCB0byBmaW5k IG91dCB3aGF0J3MgZ29pbmcgd3JvbmcgaW4gdGhhdCBwYXRjaCBiZWZvcmUgdGhpcyBzZXJpZXMg Y2FuIGJlIGFwcGxpZWQuCj4+Pj4+Pgo+Pj4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3BtLmMgfCAyICstCj4+Pj4+PiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRl bGV0aW9uKC0pCj4+Pj4+Pgo+Pj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4+Pj4+PiBpbmRl eCAzNzZjNjBiOTg1MTUuLjhkZWZkY2M1NDUyOSAxMDA2NDQKPj4+Pj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPj4+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3BtLmMKPj4+Pj4+IEBAIC0xMTQ4LDcgKzExNDgsNyBAQCBzdGF0aWMgdm9pZCB2bHZf Y29tcHV0ZV93bShzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPj4+Pj4+ICAJCQl9Cj4+Pj4+PiAg CQl9Cj4+Pj4+PiAgCj4+Pj4+PiAtCQl3bV9zdGF0ZS0+bnVtX2xldmVscyA9IGxldmVsOwo+Pj4+ Pj4gKwkJd21fc3RhdGUtPm51bV9sZXZlbHMgPSBsZXZlbCArIDE7Cj4+Pj4+IE5vcGUuIFRoZSBs b29wIGFib3ZlIGJyZWFrcyB3aGVuIHRoZSBjdXJyZW50IGxldmVsIGlzIGJhZCwgaGVuY2UgbGV2 ZWwtMQo+Pj4+PiBpcyBhY3R1YWxseSB0aGUgaGlnaGVyIHVzYWJsZSBsZXZlbC4KPj4+PiBXaXRo b3V0IGtub3dpbmcgdGhlIGxpbWl0cyBvZiBwbGFuZS0+d20uZmlmb19zaXplLCBpdCBsb29rcyBs aWtlIGl0IGNhbgo+Pj4+IGJyZWFrIG9uIGxldmVsID09IDAgdGhvdWdoLgo+Pj4gSG1tLiBUaGF0 IHNob3VsZG4ndCBiZSBwb3NzaWJsZS4gU28gbG9va3MgbGlrZSBhIGJ1ZyBzbnVjayBpbi4KPj4+ Cj4+Pj4gTWlnaHQgYXMgd2VsbCBzZXQgdGhhdCBoYWNrIHRvIHBhcmFub2lkIGxldmVsczoKPj4+ Pgo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+Pj4+IGluZGV4IDYzMGIxMTY5ODhmNi4uZThj Mjg3NGI4NjI5IDEwMDY0NAo+Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bt LmMKPj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4+Pj4gQEAgLTEx MjQsMTEgKzExMjQsMTMgQEAgc3RhdGljIHZvaWQgdmx2X2NvbXB1dGVfd20oc3RydWN0IGludGVs X2NydGMgKmNydGMpCj4+Pj4gICAgICAgICAgICAgICAgIC8qIG5vcm1hbCB3YXRlcm1hcmtzICov Cj4+Pj4gICAgICAgICAgICAgICAgIGZvciAobGV2ZWwgPSAwOyBsZXZlbCA8IHdtX3N0YXRlLT5u dW1fbGV2ZWxzOyBsZXZlbCsrKSB7CQo+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgIGludCB3 bSA9IHZsdl9jb21wdXRlX3dtX2xldmVsKHBsYW5lLCBjcnRjLCBzdGF0ZSwgbGV2ZWwpOwo+Pj4+ IC0gICAgICAgICAgICAgICAgICAgICAgIGludCBtYXhfd20gPSBwbGFuZS0+YmFzZS50eXBlID09 IERSTV9QTEFORV9UWVBFX0NVUlNPUiA/IDYzIDogNTExOwo+Pj4+IC0KPj4+PiAgICAgICAgICAg ICAgICAgICAgICAgICAvKiBoYWNrICovCj4+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgaWYg KFdBUk5fT04obGV2ZWwgPT0gMCAmJiB3bSA+IG1heF93bSkpCj4+Pj4gLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB3bSA9IG1heF93bTsKPj4+IEFjdHVhbGx5IHRoaXMgc2hvdWxkIGp1 c3QgYmUgCj4+Pgo+Pj4gaWYgKFdBUk5fT04obGV2ZWwgPT0gMCAmJiB3bSA+IGZpZm9fc2l6ZSkp Cj4+PiAJd20gPSBmaWZvX3NpemU7Cj4+Pgo+Pj4gYXNzdW1pbmcgd2Ugd2FudCB0byBrZWVwIHRo ZSBoYWNrIGFyb3VuZCBmb3Igbm93Lgo+Pj4KPj4+IEV2ZW50dWFsbHkgd2UnbGwgd2FudCB0byBt YWtlIGl0IGp1c3QgcmV0dXJuIGFuIGVycm9yIHRob3VnaC4KPj4gWWVzLCB0aGF0J3Mgd2hhdCBJ IGNhbWUgdXAgd2l0aC4KPj4KPj4gQnV0IHdlIHN0aWxsIG5lZWQgdG8gY2xhbXAgZnVydGhlciwg cHJvYmFibHkgdG8gcGxhbmUtPndtLmZpZm9fc2l6ZS4KPj4gSG93ZXZlciBzcl9maWZvX3NpemUg aXMgYWxzbyBjbGFtcGVkIHRvIDUxMSBiZWNhdXNlIG9mIHRoZSBsZXZlbCBjYWxjdWxhdGlvbnMg aGVyZS4KPj4KPj4gQmVsb3cgaXQgc2V0cyBzcltsZXZlbF0ucGxhbmUgPSBtaW4oc3JfZmlmb19z aXplLCB3bVtsZXZlbF0ucGxhbmUpLAo+PiB3aGljaCBzZWVtcyB3ZWlyZC4gSG93IGNhbiB0aGlz IGV2ZXIgZW5kIHVwIGJlaW5nIHNvbWV0aGluZyBvdGhlciB0aGFuIHdtW2xldmVsXS5wbGFuZT8K PiBUaGVyZSBhcmUgdGhyZWUgcGxhbmVzLiBDSFYgd2FzIHN1cHBvc2VkIHRvIGhhdmUgbWF4Zmlm byB3aXRoIHVwIHRvIDIgYWN0aXZlCj4gcGxhbmVzLiBCdXQgSSdtIG5vdCBzdXJlIHRoYXQgZmVh dHVyZSBtYWRlIGl0IGluLiBJIG5ldmVyIGdvdCBhcm91bmQKPiB0ZXN0aW5nIGl0LgpJIGRvbid0 IGtub3csIHdlIG9ubHkgZW5hYmxlIGl0IHdpdGggYSBzaW5nbGUgcGxhbmUsIHBsdXMgY3Vyc29y LiBJIGRvbid0IHNlZSB3aGVyZSB0aGUgb3RoZXIKcGxhbmUgd20ncyB3b3VsZCBmaXQgaW4/Cgp+ TWFhcnRlbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK