From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 08/10] drm/i915: Move the irq_counter inside
 the spinlock
Date: Wed, 17 Jan 2018 12:12:04 +0000
Message-ID: <7766d39f-e066-1ada-1e27-189646672d34@linux.intel.com>
References: <20180115212455.24046-1-chris@chris-wilson.co.uk>
 <20180115212455.24046-9-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 1219E6E419
 for <intel-gfx@lists.freedesktop.org>; Wed, 17 Jan 2018 12:12:07 +0000 (UTC)
In-Reply-To: <20180115212455.24046-9-chris@chris-wilson.co.uk>
Content-Language: en-GB
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDE1LzAxLzIwMTggMjE6MjQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBSYXRoZXIgdGhhbiBo
YXZlIG11bHRpcGxlIGxvY2tlZCBpbnN0cnVjdGlvbnMgaW5zaWRlIHRoZSBub3RpZnlfcmluZygp
Cj4gaXJxIGhhbmRsZXIsIG1vdmUgdGhlbSBpbnNpZGUgdGhlIHNwaW5sb2NrIGFuZCByZWR1Y2Ug
dGhlaXIgaW50cmluc2ljCj4gbG9ja2luZy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxz
b24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9p
OTE1L2k5MTVfZ2VtX3JlcXVlc3QuYyAgfCAgNCArKy0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkx
NS9pOTE1X2lycS5jICAgICAgICAgIHwgIDYgKysrLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9icmVhZGNydW1icy5jIHwgMTMgKysrKysrKystLS0tLQo+ICAgZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oICB8ICAyICstCj4gICA0IGZpbGVzIGNoYW5nZWQs
IDE0IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pOTE1X2dlbV9yZXF1ZXN0LmMKPiBpbmRleCA4MzZkYjkwZWY4MWIuLjA4YmJkNTYyNzdlNSAx
MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmMKPiAr
KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmMKPiBAQCAtMTEyOCw3
ICsxMTI4LDcgQEAgc3RhdGljIGJvb2wgX19pOTE1X3NwaW5fcmVxdWVzdChjb25zdCBzdHJ1Y3Qg
ZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwKPiAgIAkgKiB0YWtlcyB0byBzbGVlcCBvbiBhIHJl
cXVlc3QsIG9uIHRoZSBvcmRlciBvZiBhIG1pY3Jvc2Vjb25kLgo+ICAgCSAqLwo+ICAgCj4gLQlp
cnEgPSBhdG9taWNfcmVhZCgmZW5naW5lLT5pcnFfY291bnQpOwo+ICsJaXJxID0gUkVBRF9PTkNF
KGVuZ2luZS0+YnJlYWRjcnVtYnMuaXJxX2NvdW50KTsKPiAgIAl0aW1lb3V0X3VzICs9IGxvY2Fs
X2Nsb2NrX3VzKCZjcHUpOwo+ICAgCWRvIHsKPiAgIAkJaWYgKGk5MTVfc2Vxbm9fcGFzc2VkKGlu
dGVsX2VuZ2luZV9nZXRfc2Vxbm8oZW5naW5lKSwgc2Vxbm8pKQo+IEBAIC0xMTM5LDcgKzExMzks
NyBAQCBzdGF0aWMgYm9vbCBfX2k5MTVfc3Bpbl9yZXF1ZXN0KGNvbnN0IHN0cnVjdCBkcm1faTkx
NV9nZW1fcmVxdWVzdCAqcmVxLAo+ICAgCQkgKiBhc3N1bWUgd2Ugd29uJ3Qgc2VlIG9uZSBpbiB0
aGUgbmVhciBmdXR1cmUgYnV0IHJlcXVpcmUKPiAgIAkJICogdGhlIGVuZ2luZS0+c2Vxbm9fYmFy
cmllcigpIHRvIGZpeHVwIGNvaGVyZW5jeS4KPiAgIAkJICovCj4gLQkJaWYgKGF0b21pY19yZWFk
KCZlbmdpbmUtPmlycV9jb3VudCkgIT0gaXJxKQo+ICsJCWlmIChSRUFEX09OQ0UoZW5naW5lLT5i
cmVhZGNydW1icy5pcnFfY291bnQpICE9IGlycSkKPiAgIAkJCWJyZWFrOwo+ICAgCj4gICAJCWlm
IChzaWduYWxfcGVuZGluZ19zdGF0ZShzdGF0ZSwgY3VycmVudCkpCj4gZGlmZiAtLWdpdCBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1
X2lycS5jCj4gaW5kZXggMGIyNzI1MDFiNzM4Li5lNWY3NmQ1ODAwMTAgMTAwNjQ0Cj4gLS0tIGEv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2k5MTVfaXJxLmMKPiBAQCAtMTA3Myw5ICsxMDczLDYgQEAgc3RhdGljIHZvaWQgbm90aWZ5
X3Jpbmcoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCWlmICh1bmxpa2VseSgh
ZW5naW5lLT5icmVhZGNydW1icy5pcnFfYXJtZWQpKQo+ICAgCQlyZXR1cm47Cj4gICAKPiAtCWF0
b21pY19pbmMoJmVuZ2luZS0+aXJxX2NvdW50KTsKPiAtCXNldF9iaXQoRU5HSU5FX0lSUV9CUkVB
RENSVU1CLCAmZW5naW5lLT5pcnFfcG9zdGVkKTsKPiAtCj4gICAJcmN1X3JlYWRfbG9jaygpOwo+
ICAgCj4gICAJc3Bpbl9sb2NrKCZlbmdpbmUtPmJyZWFkY3J1bWJzLmlycV9sb2NrKTsKPiBAQCAt
MTEwNyw2ICsxMTA0LDkgQEAgc3RhdGljIHZvaWQgbm90aWZ5X3Jpbmcoc3RydWN0IGludGVsX2Vu
Z2luZV9jcyAqZW5naW5lKQo+ICAgCQkJICAgIGk5MTVfc2Vxbm9fcGFzc2VkKHNlcW5vLCB3YWl0
LT5zZXFubyAtIDEpKQo+ICAgCQkJCXRzayA9IHdhaXQtPnRzazsKPiAgIAkJfQo+ICsKPiArCQll
bmdpbmUtPmJyZWFkY3J1bWJzLmlycV9jb3VudCsrOwo+ICsJCV9fc2V0X2JpdChFTkdJTkVfSVJR
X0JSRUFEQ1JVTUIsICZlbmdpbmUtPmlycV9wb3N0ZWQpOwoKSSdtIG5lcnZvdXMgYWJvdXQgbW92
aW5nIHRoZSBFTkdJTkVfSVJRX0JSRUFEQ1JVTUIgc2V0dGluZyB0byBiZSAKY29uZGl0aW9uYWwu
IF9faTkxNV9yZXF1ZXN0X2lycV9jb21wbGV0ZSBkb2N1bWVudHMgdGhlIG9yZGVyaW5nIG9mIHRo
ZXNlIAp0aGluZ3MgaXMgY3J1Y2lhbCBzbyBJIHdvcnJ5IHdlIGRvbid0IG1pc3MgYSB3YWtldXAu
IE9uY2UgYml0dGVuIHR3aWNlIApzaHk/IERvbid0IGtub3cuLgoKaXJxX2NvdW50IGNoYW5nZSBs
b29rcyBzYWZlLCBzbyBjYW4gSSwgb25jZSBhZ2Fpbiwgc3VnZ2VzdCB0byBzcGxpdCBpbnRvIAp0
d28gcGF0Y2hlcz8gOi8KClJlZ2FyZHMsCgpUdnJ0a28KCj4gICAJfSBlbHNlIHsKPiAgIAkJaWYg
KGVuZ2luZS0+YnJlYWRjcnVtYnMuaXJxX2FybWVkKQo+ICAgCQkJX19pbnRlbF9lbmdpbmVfZGlz
YXJtX2JyZWFkY3J1bWJzKGVuZ2luZSk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2JyZWFkY3J1bWJzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9icmVh
ZGNydW1icy5jCj4gaW5kZXggZTM2NjdkYzFlOTZkLi43YzgyY2ZlMjM5MjIgMTAwNjQ0Cj4gLS0t
IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYwo+ICsrKyBiL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1bWJzLmMKPiBAQCAtOTgsMTIgKzk4LDE0IEBA
IHN0YXRpYyB2b2lkIGludGVsX2JyZWFkY3J1bWJzX2hhbmdjaGVjayhzdHJ1Y3QgdGltZXJfbGlz
dCAqdCkKPiAgIAlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUgPQo+ICAgCQlmcm9tX3Rp
bWVyKGVuZ2luZSwgdCwgYnJlYWRjcnVtYnMuaGFuZ2NoZWNrKTsKPiAgIAlzdHJ1Y3QgaW50ZWxf
YnJlYWRjcnVtYnMgKmIgPSAmZW5naW5lLT5icmVhZGNydW1iczsKPiArCXVuc2lnbmVkIGludCBp
cnFfY291bnQ7Cj4gICAKPiAgIAlpZiAoIWItPmlycV9hcm1lZCkKPiAgIAkJcmV0dXJuOwo+ICAg
Cj4gLQlpZiAoYi0+aGFuZ2NoZWNrX2ludGVycnVwdHMgIT0gYXRvbWljX3JlYWQoJmVuZ2luZS0+
aXJxX2NvdW50KSkgewo+IC0JCWItPmhhbmdjaGVja19pbnRlcnJ1cHRzID0gYXRvbWljX3JlYWQo
JmVuZ2luZS0+aXJxX2NvdW50KTsKPiArCWlycV9jb3VudCA9IFJFQURfT05DRShiLT5pcnFfY291
bnQpOwo+ICsJaWYgKGItPmhhbmdjaGVja19pbnRlcnJ1cHRzICE9IGlycV9jb3VudCkgewo+ICsJ
CWItPmhhbmdjaGVja19pbnRlcnJ1cHRzID0gaXJxX2NvdW50Owo+ICAgCQltb2RfdGltZXIoJmIt
PmhhbmdjaGVjaywgd2FpdF90aW1lb3V0KCkpOwo+ICAgCQlyZXR1cm47Cj4gICAJfQo+IEBAIC0x
NzYsNyArMTc4LDcgQEAgc3RhdGljIHZvaWQgaXJxX2VuYWJsZShzdHJ1Y3QgaW50ZWxfZW5naW5l
X2NzICplbmdpbmUpCj4gICAJICogd2Ugc3RpbGwgbmVlZCB0byBmb3JjZSB0aGUgYmFycmllciBi
ZWZvcmUgcmVhZGluZyB0aGUgc2Vxbm8sCj4gICAJICoganVzdCBpbiBjYXNlLgo+ICAgCSAqLwo+
IC0Jc2V0X2JpdChFTkdJTkVfSVJRX0JSRUFEQ1JVTUIsICZlbmdpbmUtPmlycV9wb3N0ZWQpOwo+
ICsJX19zZXRfYml0KEVOR0lORV9JUlFfQlJFQURDUlVNQiwgJmVuZ2luZS0+aXJxX3Bvc3RlZCk7
Cj4gICAKPiAgIAkvKiBDYWxsZXIgZGlzYWJsZXMgaW50ZXJydXB0cyAqLwo+ICAgCXNwaW5fbG9j
aygmZW5naW5lLT5pOTE1LT5pcnFfbG9jayk7Cj4gQEAgLTI3MCwxMyArMjcyLDE0IEBAIHN0YXRp
YyBib29sIHVzZV9mYWtlX2lycShjb25zdCBzdHJ1Y3QgaW50ZWxfYnJlYWRjcnVtYnMgKmIpCj4g
ICAJaWYgKCF0ZXN0X2JpdChlbmdpbmUtPmlkLCAmZW5naW5lLT5pOTE1LT5ncHVfZXJyb3IubWlz
c2VkX2lycV9yaW5ncykpCj4gICAJCXJldHVybiBmYWxzZTsKPiAgIAo+IC0JLyogT25seSBzdGFy
dCB3aXRoIHRoZSBoZWF2eSB3ZWlnaHQgZmFrZSBpcnEgdGltZXIgaWYgd2UgaGF2ZSBub3QKPiAr
CS8qCj4gKwkgKiBPbmx5IHN0YXJ0IHdpdGggdGhlIGhlYXZ5IHdlaWdodCBmYWtlIGlycSB0aW1l
ciBpZiB3ZSBoYXZlIG5vdAo+ICAgCSAqIHNlZW4gYW55IGludGVycnVwdHMgc2luY2UgZW5hYmxp
bmcgaXQgdGhlIGZpcnN0IHRpbWUuIElmIHRoZQo+ICAgCSAqIGludGVycnVwdHMgYXJlIHN0aWxs
IGFycml2aW5nLCBpdCBtZWFucyB3ZSBtYWRlIGEgbWlzdGFrZSBpbiBvdXIKPiAgIAkgKiBlbmdp
bmUtPnNlcW5vX2JhcnJpZXIoKSwgYSB0aW1pbmcgZXJyb3IgdGhhdCBzaG91bGQgYmUgdHJhbnNp
ZW50Cj4gICAJICogYW5kIHVubGlrZWx5IHRvIHJlb2NjdXIuCj4gICAJICovCj4gLQlyZXR1cm4g
YXRvbWljX3JlYWQoJmVuZ2luZS0+aXJxX2NvdW50KSA9PSBiLT5oYW5nY2hlY2tfaW50ZXJydXB0
czsKPiArCXJldHVybiBSRUFEX09OQ0UoYi0+aXJxX2NvdW50KSA9PSBiLT5oYW5nY2hlY2tfaW50
ZXJydXB0czsKPiAgIH0KPiAgIAo+ICAgc3RhdGljIHZvaWQgZW5hYmxlX2Zha2VfaXJxKHN0cnVj
dCBpbnRlbF9icmVhZGNydW1icyAqYikKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfcmluZ2J1ZmZlci5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1
ZmZlci5oCj4gaW5kZXggYzVmZjIwM2U0MmQ2Li5mNDA2ZDBmZjQ2MTIgMTAwNjQ0Cj4gLS0tIGEv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gKysrIGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gQEAgLTMwNSw3ICszMDUsNiBAQCBzdHJ1
Y3QgaW50ZWxfZW5naW5lX2NzIHsKPiAgIAo+ICAgCXN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0
ICpkZWZhdWx0X3N0YXRlOwo+ICAgCj4gLQlhdG9taWNfdCBpcnFfY291bnQ7Cj4gICAJdW5zaWdu
ZWQgbG9uZyBpcnFfcG9zdGVkOwo+ICAgI2RlZmluZSBFTkdJTkVfSVJRX0JSRUFEQ1JVTUIgMAo+
ICAgI2RlZmluZSBFTkdJTkVfSVJRX0VYRUNMSVNUIDEKPiBAQCAtMzQwLDYgKzMzOSw3IEBAIHN0
cnVjdCBpbnRlbF9lbmdpbmVfY3Mgewo+ICAgCj4gICAJCXVuc2lnbmVkIGludCBoYW5nY2hlY2tf
aW50ZXJydXB0czsKPiAgIAkJdW5zaWduZWQgaW50IGlycV9lbmFibGVkOwo+ICsJCXVuc2lnbmVk
IGludCBpcnFfY291bnQ7Cj4gICAKPiAgIAkJYm9vbCBpcnFfYXJtZWQgOiAxOwo+ICAgCQlJOTE1
X1NFTEZURVNUX0RFQ0xBUkUoYm9vbCBtb2NrIDogMSk7Cj4gCl9fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt
Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t
YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=