* [Intel-gfx] [PATCH] drm/i915: Hold onto an explicit ref to i915_vma_work.pinned
@ 2020-11-02 16:19 Chris Wilson
2020-11-02 16:38 ` Tvrtko Ursulin
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Chris Wilson @ 2020-11-02 16:19 UTC (permalink / raw)
To: intel-gfx; +Cc: stable, Chris Wilson
Since __vma_release is run by a kworker after the fence has been
signaled, it is no longer protected by the active reference on the vma,
and so the alias of vw->pinned to vma->obj is also not protected by a
reference on the object. Add an explicit reference for vw->pinned so it
will always be safe.
Found by inspection.
Fixes: 54d7195f8c64 ("drm/i915: Unpin vma->obj on early error")
Reported-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: <stable@vger.kernel.org> # v5.6+
---
drivers/gpu/drm/i915/i915_vma.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index ffb5287e055a..caa9b041616b 100644
--- a/drivers/gpu/drm/i915/i915_vma.c
+++ b/drivers/gpu/drm/i915/i915_vma.c
@@ -314,8 +314,10 @@ static void __vma_release(struct dma_fence_work *work)
{
struct i915_vma_work *vw = container_of(work, typeof(*vw), base);
- if (vw->pinned)
+ if (vw->pinned) {
__i915_gem_object_unpin_pages(vw->pinned);
+ i915_gem_object_put(vw->pinned);
+ }
i915_vm_free_pt_stash(vw->vm, &vw->stash);
i915_vm_put(vw->vm);
@@ -431,7 +433,7 @@ int i915_vma_bind(struct i915_vma *vma,
if (vma->obj) {
__i915_gem_object_pin_pages(vma->obj);
- work->pinned = vma->obj;
+ work->pinned = i915_gem_object_get(vma->obj);
}
} else {
vma->ops->bind_vma(vma->vm, NULL, vma, cache_level, bind_flags);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Hold onto an explicit ref to i915_vma_work.pinned
2020-11-02 16:19 [Intel-gfx] [PATCH] drm/i915: Hold onto an explicit ref to i915_vma_work.pinned Chris Wilson
@ 2020-11-02 16:38 ` Tvrtko Ursulin
2020-11-02 17:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Tvrtko Ursulin @ 2020-11-02 16:38 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: stable
On 02/11/2020 16:19, Chris Wilson wrote:
> Since __vma_release is run by a kworker after the fence has been
> signaled, it is no longer protected by the active reference on the vma,
> and so the alias of vw->pinned to vma->obj is also not protected by a
> reference on the object. Add an explicit reference for vw->pinned so it
> will always be safe.
>
> Found by inspection.
>
> Fixes: 54d7195f8c64 ("drm/i915: Unpin vma->obj on early error")
> Reported-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: <stable@vger.kernel.org> # v5.6+
> ---
> drivers/gpu/drm/i915/i915_vma.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
> index ffb5287e055a..caa9b041616b 100644
> --- a/drivers/gpu/drm/i915/i915_vma.c
> +++ b/drivers/gpu/drm/i915/i915_vma.c
> @@ -314,8 +314,10 @@ static void __vma_release(struct dma_fence_work *work)
> {
> struct i915_vma_work *vw = container_of(work, typeof(*vw), base);
>
> - if (vw->pinned)
> + if (vw->pinned) {
> __i915_gem_object_unpin_pages(vw->pinned);
> + i915_gem_object_put(vw->pinned);
> + }
>
> i915_vm_free_pt_stash(vw->vm, &vw->stash);
> i915_vm_put(vw->vm);
> @@ -431,7 +433,7 @@ int i915_vma_bind(struct i915_vma *vma,
>
> if (vma->obj) {
> __i915_gem_object_pin_pages(vma->obj);
> - work->pinned = vma->obj;
> + work->pinned = i915_gem_object_get(vma->obj);
> }
> } else {
> vma->ops->bind_vma(vma->vm, NULL, vma, cache_level, bind_flags);
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Hold onto an explicit ref to i915_vma_work.pinned
2020-11-02 16:19 [Intel-gfx] [PATCH] drm/i915: Hold onto an explicit ref to i915_vma_work.pinned Chris Wilson
2020-11-02 16:38 ` Tvrtko Ursulin
@ 2020-11-02 17:01 ` Patchwork
2020-11-02 17:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-11-02 23:44 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-11-02 17:01 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Hold onto an explicit ref to i915_vma_work.pinned
URL : https://patchwork.freedesktop.org/series/83362/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
906ed3e10d17 drm/i915: Hold onto an explicit ref to i915_vma_work.pinned
-:18: WARNING:BAD_SIGN_OFF: email address '<stable@vger.kernel.org> # v5.6+' might be better as 'stable@vger.kernel.org# v5.6+'
#18:
Cc: <stable@vger.kernel.org> # v5.6+
total: 0 errors, 1 warnings, 0 checks, 19 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Hold onto an explicit ref to i915_vma_work.pinned
2020-11-02 16:19 [Intel-gfx] [PATCH] drm/i915: Hold onto an explicit ref to i915_vma_work.pinned Chris Wilson
2020-11-02 16:38 ` Tvrtko Ursulin
2020-11-02 17:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2020-11-02 17:26 ` Patchwork
2020-11-02 23:44 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-11-02 17:26 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 4777 bytes --]
== Series Details ==
Series: drm/i915: Hold onto an explicit ref to i915_vma_work.pinned
URL : https://patchwork.freedesktop.org/series/83362/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9246 -> Patchwork_18828
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/index.html
New tests
---------
New tests have been introduced between CI_DRM_9246 and Patchwork_18828:
### New CI tests (1) ###
* boot:
- Statuses : 39 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18828 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- fi-icl-u2: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-icl-u2/igt@core_hotunplug@unbind-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/fi-icl-u2/igt@core_hotunplug@unbind-rebind.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-kefka: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-icl-u2: [DMESG-WARN][5] ([i915#1982]) -> [PASS][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-icl-u2/igt@i915_module_load@reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/fi-icl-u2/igt@i915_module_load@reload.html
- fi-tgl-u2: [DMESG-WARN][7] ([i915#1982] / [k.org#205379]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-tgl-u2/igt@i915_module_load@reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/fi-tgl-u2/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-apl-guc: [DMESG-WARN][9] ([i915#1635] / [i915#1982]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-apl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/fi-apl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_selftest@live@gt_heartbeat:
- {fi-tgl-dsi}: [INCOMPLETE][11] ([i915#2601]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-tgl-dsi/igt@i915_selftest@live@gt_heartbeat.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/fi-tgl-dsi/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_chamelium@dp-crc-fast:
- fi-cml-u2: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- {fi-tgl-dsi}: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-tgl-dsi/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/fi-tgl-dsi/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2601]: https://gitlab.freedesktop.org/drm/intel/issues/2601
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (44 -> 39)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-tgl-y fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9246 -> Patchwork_18828
CI-20190529: 20190529
CI_DRM_9246: b870a15d5fca59aa694df1d2e42446c757f134ac @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5830: 12d370cb57e0cfcb781c87ad9e15e68b17a1f41f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18828: 906ed3e10d179d70f4deb79866c607c43470ee1e @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
906ed3e10d17 drm/i915: Hold onto an explicit ref to i915_vma_work.pinned
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/index.html
[-- Attachment #1.2: Type: text/html, Size: 6006 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Hold onto an explicit ref to i915_vma_work.pinned
2020-11-02 16:19 [Intel-gfx] [PATCH] drm/i915: Hold onto an explicit ref to i915_vma_work.pinned Chris Wilson
` (2 preceding siblings ...)
2020-11-02 17:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-11-02 23:44 ` Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-11-02 23:44 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 21127 bytes --]
== Series Details ==
Series: drm/i915: Hold onto an explicit ref to i915_vma_work.pinned
URL : https://patchwork.freedesktop.org/series/83362/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9246_full -> Patchwork_18828_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18828_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18828_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18828_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_fence@invalid-fence-array:
- shard-snb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-snb6/igt@gem_exec_fence@invalid-fence-array.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-snb7/igt@gem_exec_fence@invalid-fence-array.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size:
- shard-glk: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-glk1/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-glk3/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html
### Piglit changes ###
#### Possible regressions ####
* spec@glsl-1.30@execution@built-in-functions@vs-op-bitxor-abs-neg-ivec3-ivec3 (NEW):
- {pig-icl-1065g7}: NOTRUN -> [INCOMPLETE][5] +6 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/pig-icl-1065g7/spec@glsl-1.30@execution@built-in-functions@vs-op-bitxor-abs-neg-ivec3-ivec3.html
* spec@glsl-1.30@execution@built-in-functions@vs-op-rshift-ivec3-uint (NEW):
- {pig-icl-1065g7}: NOTRUN -> [CRASH][6] +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/pig-icl-1065g7/spec@glsl-1.30@execution@built-in-functions@vs-op-rshift-ivec3-uint.html
New tests
---------
New tests have been introduced between CI_DRM_9246_full and Patchwork_18828_full:
### New CI tests (1) ###
* boot:
- Statuses : 174 pass(s)
- Exec time: [0.0] s
### New Piglit tests (9) ###
* spec@glsl-1.30@execution@built-in-functions@fs-op-bitand-not-abs-ivec3-ivec3:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@glsl-1.30@execution@built-in-functions@vs-op-assign-rshift-ivec2-ivec2:
- Statuses : 1 crash(s)
- Exec time: [0.53] s
* spec@glsl-1.30@execution@built-in-functions@vs-op-bitor-uint-uvec4:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@glsl-1.30@execution@built-in-functions@vs-op-bitxor-abs-neg-ivec3-ivec3:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@glsl-1.30@execution@built-in-functions@vs-op-bitxor-not-abs-ivec3-ivec3:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@glsl-1.30@execution@built-in-functions@vs-op-lshift-ivec3-int:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@glsl-1.30@execution@built-in-functions@vs-op-lshift-ivec3-uvec3:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@glsl-1.30@execution@built-in-functions@vs-op-rshift-ivec2-uint:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@glsl-1.30@execution@built-in-functions@vs-op-rshift-ivec3-uint:
- Statuses : 1 crash(s)
- Exec time: [0.53] s
Known issues
------------
Here are the changes found in Patchwork_18828_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@hotrebind-lateclose:
- shard-snb: [PASS][7] -> [INCOMPLETE][8] ([i915#82])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-snb6/igt@core_hotunplug@hotrebind-lateclose.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-snb7/igt@core_hotunplug@hotrebind-lateclose.html
* igt@core_hotunplug@unbind-rebind:
- shard-tglb: [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-tglb1/igt@core_hotunplug@unbind-rebind.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-tglb7/igt@core_hotunplug@unbind-rebind.html
* igt@gem_exec_whisper@basic-contexts-priority-all:
- shard-glk: [PASS][11] -> [DMESG-WARN][12] ([i915#118] / [i915#95])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-glk8/igt@gem_exec_whisper@basic-contexts-priority-all.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-glk8/igt@gem_exec_whisper@basic-contexts-priority-all.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-skl: [PASS][13] -> [DMESG-WARN][14] ([i915#1982]) +12 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl2/igt@i915_module_load@reload-with-fault-injection.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-skl2/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][15] -> [FAIL][16] ([i915#454])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-iclb5/igt@i915_pm_dc@dc6-psr.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-iclb4/igt@i915_pm_dc@dc6-psr.html
* igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#54]) +4 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-skl7/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html
* igt@kms_cursor_edge_walk@pipe-c-256x256-right-edge:
- shard-glk: [PASS][19] -> [DMESG-WARN][20] ([i915#1982]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-glk9/igt@kms_cursor_edge_walk@pipe-c-256x256-right-edge.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-glk2/igt@kms_cursor_edge_walk@pipe-c-256x256-right-edge.html
* igt@kms_flip@absolute-wf_vblank-interruptible@a-dp1:
- shard-apl: [PASS][21] -> [DMESG-WARN][22] ([i915#1635] / [i915#1982]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-apl6/igt@kms_flip@absolute-wf_vblank-interruptible@a-dp1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-apl4/igt@kms_flip@absolute-wf_vblank-interruptible@a-dp1.html
* igt@kms_flip@absolute-wf_vblank@a-dp1:
- shard-kbl: [PASS][23] -> [DMESG-WARN][24] ([i915#1982])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-kbl6/igt@kms_flip@absolute-wf_vblank@a-dp1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-kbl3/igt@kms_flip@absolute-wf_vblank@a-dp1.html
* igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1:
- shard-skl: [PASS][25] -> [FAIL][26] ([i915#2122]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl6/igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-skl4/igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-tglb: [PASS][27] -> [FAIL][28] ([i915#2598])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-tglb2/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-tglb8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-suspend@b-dp1:
- shard-kbl: [PASS][29] -> [DMESG-WARN][30] ([i915#180])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-kbl6/igt@kms_flip@flip-vs-suspend@b-dp1.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-kbl7/igt@kms_flip@flip-vs-suspend@b-dp1.html
* igt@kms_flip@flip-vs-suspend@c-edp1:
- shard-skl: [PASS][31] -> [INCOMPLETE][32] ([i915#198])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl3/igt@kms_flip@flip-vs-suspend@c-edp1.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-skl8/igt@kms_flip@flip-vs-suspend@c-edp1.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [PASS][33] -> [INCOMPLETE][34] ([i915#123])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl3/igt@kms_frontbuffer_tracking@psr-suspend.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-skl10/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][35] -> [FAIL][36] ([fdo#108145] / [i915#265]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109441]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-iclb7/igt@kms_psr@psr2_primary_mmap_gtt.html
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][39] ([i915#658]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-iclb4/igt@feature_discovery@psr2.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [DMESG-WARN][41] ([i915#1436] / [i915#716]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl6/igt@gen9_exec_parse@allowed-single.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-skl1/igt@gen9_exec_parse@allowed-single.html
* {igt@kms_async_flips@async-flip-with-page-flip-events}:
- shard-kbl: [FAIL][43] ([i915#2521]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-kbl3/igt@kms_async_flips@async-flip-with-page-flip-events.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-kbl3/igt@kms_async_flips@async-flip-with-page-flip-events.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-0:
- shard-skl: [DMESG-WARN][45] ([i915#1982]) -> [PASS][46] +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl4/igt@kms_big_fb@x-tiled-8bpp-rotate-0.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-skl10/igt@kms_big_fb@x-tiled-8bpp-rotate-0.html
* igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen:
- shard-skl: [FAIL][47] ([i915#54]) -> [PASS][48] +3 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl7/igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [FAIL][49] ([i915#79]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip_tiling@flip-to-yf-tiled:
- shard-kbl: [DMESG-WARN][51] ([i915#1982]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-kbl4/igt@kms_flip_tiling@flip-to-yf-tiled.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-kbl2/igt@kms_flip_tiling@flip-to-yf-tiled.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-iclb: [INCOMPLETE][53] ([i915#1185] / [i915#250]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-iclb3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-iclb1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][55] ([fdo#109441]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-iclb4/igt@kms_psr@psr2_sprite_plane_move.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][57] ([i915#1635] / [i915#31]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-apl7/igt@kms_setmode@basic.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-apl7/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-b-wait-forked-busy-hang:
- shard-apl: [DMESG-WARN][59] ([i915#1635] / [i915#1982]) -> [PASS][60] +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-apl4/igt@kms_vblank@pipe-b-wait-forked-busy-hang.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-apl6/igt@kms_vblank@pipe-b-wait-forked-busy-hang.html
* igt@kms_vblank@pipe-d-accuracy-idle:
- shard-tglb: [DMESG-WARN][61] ([i915#1982]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-tglb7/igt@kms_vblank@pipe-d-accuracy-idle.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-tglb3/igt@kms_vblank@pipe-d-accuracy-idle.html
* igt@perf_pmu@module-unload:
- shard-iclb: [DMESG-WARN][63] ([i915#1982]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-iclb5/igt@perf_pmu@module-unload.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-iclb4/igt@perf_pmu@module-unload.html
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][65] ([i915#588]) -> [SKIP][66] ([i915#658])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-iclb5/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-skl: [DMESG-FAIL][67] ([i915#1982]) -> [DMESG-WARN][68] ([i915#1982])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][69] ([i915#1226]) -> [SKIP][70] ([fdo#109349])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-iclb5/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
- shard-tglb: [DMESG-WARN][71] ([i915#2411]) -> [INCOMPLETE][72] ([i915#1436] / [i915#456])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-tglb1/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-tglb1/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
* igt@kms_flip_tiling@flip-x-tiled:
- shard-skl: [DMESG-WARN][73] ([i915#1982]) -> [DMESG-FAIL][74] ([fdo#108145] / [i915#1982])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl10/igt@kms_flip_tiling@flip-x-tiled.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-skl8/igt@kms_flip_tiling@flip-x-tiled.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: [FAIL][75] ([fdo#108145] / [i915#1635] / [i915#265]) -> [DMESG-FAIL][76] ([fdo#108145] / [i915#1635] / [i915#1982])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-apl1/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-skl: [FAIL][77] ([fdo#108145] / [i915#265]) -> [DMESG-FAIL][78] ([fdo#108145] / [i915#1982])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
* igt@runner@aborted:
- shard-tglb: [FAIL][79] ([i915#2439]) -> ([FAIL][80], [FAIL][81]) ([i915#2248] / [i915#2439])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-tglb6/igt@runner@aborted.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-tglb5/igt@runner@aborted.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-tglb1/igt@runner@aborted.html
* igt@sysfs_heartbeat_interval@mixed@rcs0:
- shard-skl: [DMESG-WARN][82] ([i915#1982]) -> [DMESG-FAIL][83] ([i915#1982]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl6/igt@sysfs_heartbeat_interval@mixed@rcs0.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/shard-skl1/igt@sysfs_heartbeat_interval@mixed@rcs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2248]: https://gitlab.freedesktop.org/drm/intel/issues/2248
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439
[i915#250]: https://gitlab.freedesktop.org/drm/intel/issues/250
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9246 -> Patchwork_18828
CI-20190529: 20190529
CI_DRM_9246: b870a15d5fca59aa694df1d2e42446c757f134ac @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5830: 12d370cb57e0cfcb781c87ad9e15e68b17a1f41f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18828: 906ed3e10d179d70f4deb79866c607c43470ee1e @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18828/index.html
[-- Attachment #1.2: Type: text/html, Size: 25294 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-02 23:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-02 16:19 [Intel-gfx] [PATCH] drm/i915: Hold onto an explicit ref to i915_vma_work.pinned Chris Wilson
2020-11-02 16:38 ` Tvrtko Ursulin
2020-11-02 17:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-11-02 17:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-11-02 23:44 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).