From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org,
Rafael Ristovski <rafael.ristovski@gmail.com>,
Steven Newbury <steve@snewbury.org.uk>
Subject: Re: [PATCH] drm/i915: Use atomic page flip for intel again.
Date: Mon, 23 Jan 2017 16:02:18 +0100 [thread overview]
Message-ID: <790e05f2-4a37-3fd5-1b5a-d4adc2beee4f@linux.intel.com> (raw)
In-Reply-To: <20161227144819.GD31952@dvetter-linux.ger.corp.intel.com>
Op 27-12-16 om 15:48 schreef Daniel Vetter:
> On Thu, Dec 22, 2016 at 11:33:23AM +0100, Maarten Lankhorst wrote:
>> This reverts commit 527b6abe5fd2d2
>> (Revert "drm/i915: Use atomic commits for legacy page_flips")
>>
>> and reapplies commit ee042aa40b66d1.
>> ("drm/i915: Use atomic commits for legacy page_flips")
>>
>> The reason for the revert was because legacy cursor updates were
>> forced to wait for pending page flips and rendering after they
>> were converted to atomic.
>>
>> Commit f79f26921ee12c6f
>> (drm/i915: Add a cursor hack to allow converting legacy page flip to atomic, v3)
>> adds a fastpath to cursor updates, which fixes the stuttering issues.
>> With these changes I feel confident enough to re-enable cursor updates.
>>
>> Legacy cursor update won't block in the following cases:
>> - Moving cursor
>> - Changing cursor fb
>>
>> The legacy cursor update will still block in the following cases:
>> - Showing/hiding cursor.
>> - Cursor size or scaling changes.
>> - cursor update while cursor is invisible (could be fixed, if it turns out to be important).
>> - Cursor tiling changes (Not sure we support tiled cursors.)
>> - Last update was a modeset.
>>
>> Cc: Steven Newbury <steve@snewbury.org.uk>
>> Cc: Rafael Ristovski <rafael.ristovski@gmail.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Tested-by: Rafael Ristovski <rafael.ristovski@gmail.com>
>> Testcase: igt/kms_cursor_legacy
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> I'm going to regret this again ;-)
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
But we have testcases now! That pass!! So pushed, thanks for review. ;)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-01-23 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 10:33 [PATCH] drm/i915: Use atomic page flip for intel again Maarten Lankhorst
2016-12-22 17:52 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-12-27 14:48 ` [PATCH] " Daniel Vetter
2017-01-23 15:02 ` Maarten Lankhorst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=790e05f2-4a37-3fd5-1b5a-d4adc2beee4f@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rafael.ristovski@gmail.com \
--cc=steve@snewbury.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox